2021-11-24 17:00:03

by kernel test robot

Subject: [PATCH] tsnep: fix platform_no_drv_owner.cocci warnings

From: kernel test robot <[email protected]>

drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Gerhard Engleder <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4b74e088fef6ce8cc513f935ce236c38bdf5f67b
commit: 403f69bbdbadb2e601f725be2d00b4ccc7b61c9d [2745/3376] tsnep: Add TSN endpoint Ethernet MAC driver
:::::: branch date: 11 hours ago
:::::: commit date: 2 days ago

tsnep_main.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/net/ethernet/engleder/tsnep_main.c
+++ b/drivers/net/ethernet/engleder/tsnep_main.c
@@ -1260,7 +1260,6 @@ MODULE_DEVICE_TABLE(of, tsnep_of_match);
static struct platform_driver tsnep_driver = {
.driver = {
.name = TSNEP,
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(tsnep_of_match),
},
.probe = tsnep_probe,

2021-11-24 20:36:19

by Gerhard Engleder

Subject: Re: [PATCH] tsnep: fix platform_no_drv_owner.cocci warnings

>
> From: kernel test robot <[email protected]>
>
> drivers/net/ethernet/engleder/tsnep_main.c:1263:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Gerhard Engleder <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: kernel test robot <[email protected]>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 4b74e088fef6ce8cc513f935ce236c38bdf5f67b
> commit: 403f69bbdbadb2e601f725be2d00b4ccc7b61c9d [2745/3376] tsnep: Add TSN endpoint Ethernet MAC driver
> :::::: branch date: 11 hours ago
> :::::: commit date: 2 days ago
>
> tsnep_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/net/ethernet/engleder/tsnep_main.c
> +++ b/drivers/net/ethernet/engleder/tsnep_main.c
> @@ -1260,7 +1260,6 @@ MODULE_DEVICE_TABLE(of, tsnep_of_match);
> static struct platform_driver tsnep_driver = {
> .driver = {
> .name = TSNEP,
> - .owner = THIS_MODULE,
> .of_match_table = of_match_ptr(tsnep_of_match),
> },
> .probe = tsnep_probe,

Reviewed-by: Gerhard Engleder <[email protected]>