2018-08-30 22:37:55

by Igor Stoppa

Subject: [PATCH 18/23] infiniband: scsi: remove unnecessary unlikely()

WARN_ON() already contains an unlikely(), so it's not necessary to
wrap it into another.

Signed-off-by: Igor Stoppa <[email protected]>
Cc: Bart Van Assche <[email protected]>
---
drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index f37cbad022a2..447d21ea479a 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -2708,7 +2708,7 @@ static void srpt_queue_response(struct se_cmd *cmd)
break;
}

- if (unlikely(WARN_ON_ONCE(state == SRPT_STATE_CMD_RSP_SENT)))
+ if (WARN_ON_ONCE(state == SRPT_STATE_CMD_RSP_SENT))
return;

/* For read commands, transfer the data to the initiator. */
--
2.17.1

2018-08-30 22:55:15

by Bart Van Assche

Subject: Re: [PATCH 18/23] infiniband: scsi: remove unnecessary unlikely()

On Thu, Aug 30, 2018 at 3:35 PM Igor Stoppa <[email protected]> wrote:
>
> WARN_ON() already contains an unlikely(), so it's not necessary to
> wrap it into another.

Reviewed-by: Bart Van Assche <[email protected]>