Fix below warnings reported by coccicheck:
drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.
Signed-off-by: Lucas Tanure <[email protected]>
---
drivers/hid/hid-hyperv.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index dddfca555df9..0b6ee1dee625 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -193,8 +193,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
goto cleanup;
/* The pointer is not NULL when we resume from hibernation */
- if (input_device->hid_desc != NULL)
- kfree(input_device->hid_desc);
+ kfree(input_device->hid_desc);
input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
if (!input_device->hid_desc)
@@ -207,8 +206,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
}
/* The pointer is not NULL when we resume from hibernation */
- if (input_device->report_desc != NULL)
- kfree(input_device->report_desc);
+ kfree(input_device->report_desc);
input_device->report_desc = kzalloc(input_device->report_desc_size,
GFP_ATOMIC);
--
2.25.1
From: Lucas Tanure <[email protected]> Sent: Saturday, February 29, 2020 9:30 AM
>
> Fix below warnings reported by coccicheck:
> drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is
> not needed.
> drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is
> not needed.
>
> Signed-off-by: Lucas Tanure <[email protected]>
Reviewed-by: Michael Kelley <[email protected]>
> ---
> drivers/hid/hid-hyperv.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index dddfca555df9..0b6ee1dee625 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -193,8 +193,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev
> *input_device,
> goto cleanup;
>
> /* The pointer is not NULL when we resume from hibernation */
> - if (input_device->hid_desc != NULL)
> - kfree(input_device->hid_desc);
> + kfree(input_device->hid_desc);
> input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
>
> if (!input_device->hid_desc)
> @@ -207,8 +206,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev
> *input_device,
> }
>
> /* The pointer is not NULL when we resume from hibernation */
> - if (input_device->report_desc != NULL)
> - kfree(input_device->report_desc);
> + kfree(input_device->report_desc);
> input_device->report_desc = kzalloc(input_device->report_desc_size,
> GFP_ATOMIC);
>
> --
> 2.25.1
On Sat, Feb 29, 2020 at 05:30:07PM +0000, Lucas Tanure wrote:
> Fix below warnings reported by coccicheck:
> drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
> drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.
>
> Signed-off-by: Lucas Tanure <[email protected]>
Reviewed-by: Wei Liu <[email protected]>
On Sat, Feb 29, 2020 at 6:30 PM Lucas Tanure <[email protected]> wrote:
>
> Fix below warnings reported by coccicheck:
> drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
> drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.
>
> Signed-off-by: Lucas Tanure <[email protected]>
> ---
Acked-by: Benjamin Tissoires <[email protected]>
Sasha, do you prefer taking this through your tree or through the HID
one. I don't think we have much scheduled for hyperv, so it's up to
you.
Cheers,
Benjamin
> drivers/hid/hid-hyperv.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index dddfca555df9..0b6ee1dee625 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -193,8 +193,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
> goto cleanup;
>
> /* The pointer is not NULL when we resume from hibernation */
> - if (input_device->hid_desc != NULL)
> - kfree(input_device->hid_desc);
> + kfree(input_device->hid_desc);
> input_device->hid_desc = kmemdup(desc, desc->bLength, GFP_ATOMIC);
>
> if (!input_device->hid_desc)
> @@ -207,8 +206,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
> }
>
> /* The pointer is not NULL when we resume from hibernation */
> - if (input_device->report_desc != NULL)
> - kfree(input_device->report_desc);
> + kfree(input_device->report_desc);
> input_device->report_desc = kzalloc(input_device->report_desc_size,
> GFP_ATOMIC);
>
> --
> 2.25.1
>
Hi Benjamin
On Mon, Mar 02, 2020 at 11:16:30AM +0100, Benjamin Tissoires wrote:
> On Sat, Feb 29, 2020 at 6:30 PM Lucas Tanure <[email protected]> wrote:
> >
> > Fix below warnings reported by coccicheck:
> > drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
> > drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.
> >
> > Signed-off-by: Lucas Tanure <[email protected]>
> > ---
>
> Acked-by: Benjamin Tissoires <[email protected]>
>
> Sasha, do you prefer taking this through your tree or through the HID
> one. I don't think we have much scheduled for hyperv, so it's up to
> you.
Sasha stepped down as a hyperv maintainer a few days back. I will be
taking over maintenance of the hyperv tree.
The problem is at the moment I haven't got write access to the
repository hosted on git.kernel.org. That's something I will need to
sort out as soon as possible.
In the meantime, it would be great if you can pick up this patch so that
it doesn't get lost while I sort out access on my side.
Thanks,
Wei.
On Mon, Mar 02, 2020 at 12:09:51PM +0000, Wei Liu wrote:
> Hi Benjamin
>
> On Mon, Mar 02, 2020 at 11:16:30AM +0100, Benjamin Tissoires wrote:
> > On Sat, Feb 29, 2020 at 6:30 PM Lucas Tanure <[email protected]> wrote:
> > >
> > > Fix below warnings reported by coccicheck:
> > > drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
> > > drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.
> > >
> > > Signed-off-by: Lucas Tanure <[email protected]>
> > > ---
> >
> > Acked-by: Benjamin Tissoires <[email protected]>
> >
> > Sasha, do you prefer taking this through your tree or through the HID
> > one. I don't think we have much scheduled for hyperv, so it's up to
> > you.
>
> Sasha stepped down as a hyperv maintainer a few days back. I will be
> taking over maintenance of the hyperv tree.
>
> The problem is at the moment I haven't got write access to the
> repository hosted on git.kernel.org. That's something I will need to
> sort out as soon as possible.
>
> In the meantime, it would be great if you can pick up this patch so that
> it doesn't get lost while I sort out access on my side.
Hi Benjamin
I got access to the Hyper-V tree. I will be picking this patch up since
I haven't got a confirmation from your side.
Wei.
>
> Thanks,
> Wei.
On Wed, Mar 4, 2020 at 3:49 PM Wei Liu <[email protected]> wrote:
>
> On Mon, Mar 02, 2020 at 12:09:51PM +0000, Wei Liu wrote:
> > Hi Benjamin
> >
> > On Mon, Mar 02, 2020 at 11:16:30AM +0100, Benjamin Tissoires wrote:
> > > On Sat, Feb 29, 2020 at 6:30 PM Lucas Tanure <[email protected]> wrote:
> > > >
> > > > Fix below warnings reported by coccicheck:
> > > > drivers/hid/hid-hyperv.c:197:2-7: WARNING: NULL check before some freeing functions is not needed.
> > > > drivers/hid/hid-hyperv.c:211:2-7: WARNING: NULL check before some freeing functions is not needed.
> > > >
> > > > Signed-off-by: Lucas Tanure <[email protected]>
> > > > ---
> > >
> > > Acked-by: Benjamin Tissoires <[email protected]>
> > >
> > > Sasha, do you prefer taking this through your tree or through the HID
> > > one. I don't think we have much scheduled for hyperv, so it's up to
> > > you.
> >
> > Sasha stepped down as a hyperv maintainer a few days back. I will be
> > taking over maintenance of the hyperv tree.
> >
> > The problem is at the moment I haven't got write access to the
> > repository hosted on git.kernel.org. That's something I will need to
> > sort out as soon as possible.
> >
> > In the meantime, it would be great if you can pick up this patch so that
> > it doesn't get lost while I sort out access on my side.
>
> Hi Benjamin
>
> I got access to the Hyper-V tree. I will be picking this patch up since
> I haven't got a confirmation from your side.
>
Great, thanks.
Sorry, I am pulled in freedesktop tasks right now that are a little bit urgent.
Glad you quickly set up the access rights.
Cheers,
Benjamin