Hi,
On 10/21/21 15:09, Maximilian Luz wrote:
> This series adds Surface Aggregator Module (SAM) support for the new
> Surface Laptop Studio (SLS).
>
> This is mostly straight-forward addition of devices to the Surface
> Aggregator registry, but the Surface HID driver needs a couple of small
> changes. Specifically, we need to allow it to probe against SAM devices
> with target ID 1 and also need to use the corresponding registry for
> those.
>
> I hope it's okay that I've CCed stable to get these included in v5.14+
> stable kernels. The changes are fairly small and enable keyboard and
> touchpad on the SLS. Most other things (except touch) should already
> work well on the latest stable kernels, so back-porting this series
> would make the SLS a usable device on those.
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>
> Maximilian Luz (3):
> platform/surface: aggregator_registry: Add support for Surface Laptop
> Studio
> HID: surface-hid: Use correct event registry for managing HID events
> HID: surface-hid: Allow driver matching for target ID 1 devices
>
> drivers/hid/surface-hid/surface_hid.c | 4 +-
> .../surface/surface_aggregator_registry.c | 54 +++++++++++++++++++
> include/linux/surface_aggregator/controller.h | 4 +-
> 3 files changed, 58 insertions(+), 4 deletions(-)
>
On Thu, Oct 21, 2021 at 8:33 PM Hans de Goede <[email protected]> wrote:
>
> Hi,
>
> On 10/21/21 15:09, Maximilian Luz wrote:
> > This series adds Surface Aggregator Module (SAM) support for the new
> > Surface Laptop Studio (SLS).
> >
> > This is mostly straight-forward addition of devices to the Surface
> > Aggregator registry, but the Surface HID driver needs a couple of small
> > changes. Specifically, we need to allow it to probe against SAM devices
> > with target ID 1 and also need to use the corresponding registry for
> > those.
> >
> > I hope it's okay that I've CCed stable to get these included in v5.14+
> > stable kernels. The changes are fairly small and enable keyboard and
> > touchpad on the SLS. Most other things (except touch) should already
> > work well on the latest stable kernels, so back-porting this series
> > would make the SLS a usable device on those.
>
> Thank you for your patch-series, I've applied the series to my
> review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
I was surprised to see you taking this series when the 2 patches I
received are HID only.
But it turns out that the patch 1/3 (which I am missing) is actually
about platform, so it makes sense to have you take the full series.
The HID changes are relatively small and are not conflicting with
anything in the HID tree.
For the HID part:
Acked-by: Benjamin Tissoires <[email protected]>
Cheers,
Benjamin
>
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.
>
> Regards,
>
> Hans
>
>
>
> >
> > Maximilian Luz (3):
> > platform/surface: aggregator_registry: Add support for Surface Laptop
> > Studio
> > HID: surface-hid: Use correct event registry for managing HID events
> > HID: surface-hid: Allow driver matching for target ID 1 devices
> >
> > drivers/hid/surface-hid/surface_hid.c | 4 +-
> > .../surface/surface_aggregator_registry.c | 54 +++++++++++++++++++
> > include/linux/surface_aggregator/controller.h | 4 +-
> > 3 files changed, 58 insertions(+), 4 deletions(-)
> >
>
Hi,
On 10/22/21 08:55, Benjamin Tissoires wrote:
> On Thu, Oct 21, 2021 at 8:33 PM Hans de Goede <[email protected]> wrote:
>>
>> Hi,
>>
>> On 10/21/21 15:09, Maximilian Luz wrote:
>>> This series adds Surface Aggregator Module (SAM) support for the new
>>> Surface Laptop Studio (SLS).
>>>
>>> This is mostly straight-forward addition of devices to the Surface
>>> Aggregator registry, but the Surface HID driver needs a couple of small
>>> changes. Specifically, we need to allow it to probe against SAM devices
>>> with target ID 1 and also need to use the corresponding registry for
>>> those.
>>>
>>> I hope it's okay that I've CCed stable to get these included in v5.14+
>>> stable kernels. The changes are fairly small and enable keyboard and
>>> touchpad on the SLS. Most other things (except touch) should already
>>> work well on the latest stable kernels, so back-porting this series
>>> would make the SLS a usable device on those.
>>
>> Thank you for your patch-series, I've applied the series to my
>> review-hans branch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>>
>> Note it will show up in my review-hans branch once I've pushed my
>> local branch there, which might take a while.
>
> I was surprised to see you taking this series when the 2 patches I
> received are HID only.
> But it turns out that the patch 1/3 (which I am missing) is actually
> about platform, so it makes sense to have you take the full series.
> The HID changes are relatively small and are not conflicting with
> anything in the HID tree.
>
> For the HID part:
> Acked-by: Benjamin Tissoires <[email protected]>
Thanks I'll add your Ack before moving this for-next and sorry for
not coordinating this before hand.
TBH I completely missed that the 2 other patches where under drivers/hid
since 90% or so of all surface stuff is under drivers/platform/surface
I sorta assumed all patches where for there. My bad, sorry.
(Note to self: Next time not only review the contents of the diff but
also look at the file-paths).
Regards,
Hans
>
> Cheers,
> Benjamin
>
>>
>> Once I've run some tests on this branch the patches there will be
>> added to the platform-drivers-x86/for-next branch and eventually
>> will be included in the pdx86 pull-request to Linus for the next
>> merge-window.
>>
>> Regards,
>>
>> Hans
>>
>>
>>
>>>
>>> Maximilian Luz (3):
>>> platform/surface: aggregator_registry: Add support for Surface Laptop
>>> Studio
>>> HID: surface-hid: Use correct event registry for managing HID events
>>> HID: surface-hid: Allow driver matching for target ID 1 devices
>>>
>>> drivers/hid/surface-hid/surface_hid.c | 4 +-
>>> .../surface/surface_aggregator_registry.c | 54 +++++++++++++++++++
>>> include/linux/surface_aggregator/controller.h | 4 +-
>>> 3 files changed, 58 insertions(+), 4 deletions(-)
>>>
>>
>