2018-06-09 06:07:52

by Hyunil Kim

[permalink] [raw]
Subject: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

* fix checkpatch.pl warning:
WARNING: braces { are not necessary for single statement blocks

Signed-off-by: Hyunil Kim <[email protected]>
---
drivers/staging/rtl8192e/rtllib_softmac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 919231f..d172e87 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1355,9 +1355,8 @@ rtllib_association_req(struct rtllib_network *beacon,
rtllib_WMM_Info(ieee, &tag);
}

- if (wps_ie_len && ieee->wps_ie) {
+ if (wps_ie_len && ieee->wps_ie)
skb_put_data(skb, ieee->wps_ie, wps_ie_len);
- }

if (turbo_info_len) {
tag = skb_put(skb, turbo_info_len);
--
2.7.4




2018-06-15 11:09:32

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

On Sat, Jun 09, 2018 at 03:05:56PM +0900, [email protected] wrote:
> * fix checkpatch.pl warning:
> WARNING: braces { are not necessary for single statement blocks
>
> Signed-off-by: Hyunil Kim <[email protected]>

This does not match your "From:" line in your email headers :(


2018-06-16 04:24:44

by Hyunil Kim

[permalink] [raw]
Subject: Re: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

Thanks greg.
Let me check and send again
regards
Hyunil Kim

On Fri, Jun 15, 2018 at 8:08 PM, Greg KH <[email protected]> wrote:
> On Sat, Jun 09, 2018 at 03:05:56PM +0900, [email protected] wrote:
>> * fix checkpatch.pl warning:
>> WARNING: braces { are not necessary for single statement blocks
>>
>> Signed-off-by: Hyunil Kim <[email protected]>
>
> This does not match your "From:" line in your email headers :(
>