2012-08-22 23:49:50

by Tejun Heo

Subject: [PATCH] omapdrm: use alloc_ordered_workqueue() instead of UNBOUND w/ max_active = 1

This is an equivalent conversion and will ease scheduled removal of
WQ_NON_REENTRANT.

Only compile tested.

Signed-off-by: Tejun Heo <[email protected]>
---
drivers/staging/omapdrm/omap_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c
index 4beab94..672cb3a 100644
--- a/drivers/staging/omapdrm/omap_drv.c
+++ b/drivers/staging/omapdrm/omap_drv.c
@@ -571,8 +571,7 @@ static int dev_load(struct drm_device *dev, unsigned long flags)

dev->dev_private = priv;

- priv->wq = alloc_workqueue("omapdrm",
- WQ_UNBOUND | WQ_NON_REENTRANT, 1);
+ priv->wq = alloc_ordered_workqueue("omapdrm", 0);

INIT_LIST_HEAD(&priv->obj_list);

2012-08-23 20:09:03

by Clark, Rob

Subject: Re: [PATCH] omapdrm: use alloc_ordered_workqueue() instead of UNBOUND w/ max_active = 1

On Wed, Aug 22, 2012 at 6:49 PM, Tejun Heo <[email protected]> wrote:
> This is an equivalent conversion and will ease scheduled removal of
> WQ_NON_REENTRANT.
>
> Only compile tested.
>
> Signed-off-by: Tejun Heo <[email protected]>

I've tested it

Signed-off-by: Rob Clark <[email protected]>

> ---
> drivers/staging/omapdrm/omap_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c
> index 4beab94..672cb3a 100644
> --- a/drivers/staging/omapdrm/omap_drv.c
> +++ b/drivers/staging/omapdrm/omap_drv.c
> @@ -571,8 +571,7 @@ static int dev_load(struct drm_device *dev, unsigned long flags)
>
> dev->dev_private = priv;
>
> - priv->wq = alloc_workqueue("omapdrm",
> - WQ_UNBOUND | WQ_NON_REENTRANT, 1);
> + priv->wq = alloc_ordered_workqueue("omapdrm", 0);
>
> INIT_LIST_HEAD(&priv->obj_list);
>

2012-08-23 20:16:23

by Tejun Heo

Subject: Re: [PATCH] omapdrm: use alloc_ordered_workqueue() instead of UNBOUND w/ max_active = 1

On Thu, Aug 23, 2012 at 03:08:59PM -0500, Clark, Rob wrote:
> On Wed, Aug 22, 2012 at 6:49 PM, Tejun Heo <[email protected]> wrote:
> > This is an equivalent conversion and will ease scheduled removal of
> > WQ_NON_REENTRANT.
> >
> > Only compile tested.
> >
> > Signed-off-by: Tejun Heo <[email protected]>
>
> I've tested it
>
> Signed-off-by: Rob Clark <[email protected]>

Can you please route this with other omap patches?

Thanks!

--
tejun