2020-02-28 04:36:07

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the akpm tree

---

Hi all,

After merging the akpm tree, today's linux-next build (sparc defconfig)
produced this warning:

mm/memory.c:1463:12: warning: 'insert_page_in_batch_locked' defined but not used [-Wunused-function]
static int insert_page_in_batch_locked(struct mm_struct *mm, pmd_t *pmd,
^~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

4a879e02dd49 ("mm/memory.c: add vm_insert_pages()")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2020-02-28 05:24:25

by Arjun Roy

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the akpm tree

---

On Thu, Feb 27, 2020 at 8:35 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the akpm tree, today's linux-next build (sparc defconfig)
> produced this warning:
>
> mm/memory.c:1463:12: warning: 'insert_page_in_batch_locked' defined but not used [-Wunused-function]
> static int insert_page_in_batch_locked(struct mm_struct *mm, pmd_t *pmd,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
Well, that's certainly a step in the right direction if it compiles :)

I guess having this function be within the ifdef is the way to make
this warning go away.

I'll, er, make a v3 patch.

-Arjun

> Introduced by commit
>
> 4a879e02dd49 ("mm/memory.c: add vm_insert_pages()")
>
> --
> Cheers,
> Stephen Rothwell