2020-07-13 08:43:24

by Alexander A. Klimov

[permalink] [raw]
Subject: [PATCH] LICENSES: Replace HTTP links with HTTPS ones

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
(Actually letting a shell for loop submit all this stuff for me.)

If there are any URLs to be removed completely or at least not just HTTPSified:
Just clearly say so and I'll *undo my change*.
See also: https://lkml.org/lkml/2020/6/27/64

If there are any valid, but yet not changed URLs:
See: https://lkml.org/lkml/2020/6/26/837

If you apply the patch, please let me know.

Sorry again to all maintainers who complained about subject lines.
Now I realized that you want an actually perfect prefixes,
not just subsystem ones.
I tried my best...
And yes, *I could* (at least half-)automate it.
Impossible is nothing! :)


LICENSES/dual/Apache-2.0 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/LICENSES/dual/Apache-2.0 b/LICENSES/dual/Apache-2.0
index 6e89ddeab187..fd71308fd2c3 100644
--- a/LICENSES/dual/Apache-2.0
+++ b/LICENSES/dual/Apache-2.0
@@ -15,7 +15,7 @@ Apache License

Version 2.0, January 2004

-http://www.apache.org/licenses/
+https://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

--
2.27.0


2020-07-21 14:51:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] LICENSES: Replace HTTP links with HTTPS ones

On Mon, Jul 13, 2020 at 10:42:31AM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely or at least not just HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See: https://lkml.org/lkml/2020/6/26/837
>
> If you apply the patch, please let me know.
>
> Sorry again to all maintainers who complained about subject lines.
> Now I realized that you want an actually perfect prefixes,
> not just subsystem ones.
> I tried my best...
> And yes, *I could* (at least half-)automate it.
> Impossible is nothing! :)
>
>
> LICENSES/dual/Apache-2.0 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/LICENSES/dual/Apache-2.0 b/LICENSES/dual/Apache-2.0
> index 6e89ddeab187..fd71308fd2c3 100644
> --- a/LICENSES/dual/Apache-2.0
> +++ b/LICENSES/dual/Apache-2.0
> @@ -15,7 +15,7 @@ Apache License
>
> Version 2.0, January 2004
>
> -http://www.apache.org/licenses/
> +https://www.apache.org/licenses/
>
> TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
>
> --
> 2.27.0
>

You can't change the text of a license that comes from elsewhere. This
file is fine as-is.

thanks,

greg k-h

2020-07-30 21:51:50

by Philippe Ombredanne

[permalink] [raw]
Subject: Re: [PATCH] LICENSES: Replace HTTP links with HTTPS ones

Hi Alexander:

On Tue, Jul 21, 2020 at 4:50 PM Greg KH <[email protected]> wrote:
>
> On Mon, Jul 13, 2020 at 10:42:31AM +0200, Alexander A. Klimov wrote:
> > Rationale:
> > Reduces attack surface on kernel devs opening the links for MITM
> > as HTTPS traffic is much harder to manipulate.
> >
> > Deterministic algorithm:
> > For each file:
> > If not .svg:
> > For each line:
> > If doesn't contain `\bxmlns\b`:
> > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> > If both the HTTP and HTTPS versions
> > return 200 OK and serve the same content:
> > Replace HTTP with HTTPS.
> >
> > Signed-off-by: Alexander A. Klimov <[email protected]>
> > ---
> > Continuing my work started at 93431e0607e5.
> > See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
> > (Actually letting a shell for loop submit all this stuff for me.)
> >
> > If there are any URLs to be removed completely or at least not just HTTPSified:
> > Just clearly say so and I'll *undo my change*.
> > See also: https://lkml.org/lkml/2020/6/27/64
> >
> > If there are any valid, but yet not changed URLs:
> > See: https://lkml.org/lkml/2020/6/26/837
> >
> > If you apply the patch, please let me know.
> >
> > Sorry again to all maintainers who complained about subject lines.
> > Now I realized that you want an actually perfect prefixes,
> > not just subsystem ones.
> > I tried my best...
> > And yes, *I could* (at least half-)automate it.
> > Impossible is nothing! :)
> >
> >
> > LICENSES/dual/Apache-2.0 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/LICENSES/dual/Apache-2.0 b/LICENSES/dual/Apache-2.0
> > index 6e89ddeab187..fd71308fd2c3 100644
> > --- a/LICENSES/dual/Apache-2.0
> > +++ b/LICENSES/dual/Apache-2.0
> > @@ -15,7 +15,7 @@ Apache License
> >
> > Version 2.0, January 2004
> >
> > -http://www.apache.org/licenses/
> > +https://www.apache.org/licenses/
> >
> > TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
> >
> > --
> > 2.27.0
> >
>
> You can't change the text of a license that comes from elsewhere. This
> file is fine as-is.

It is so fine that -FWIW- even the Apache folks toyed with the idea of
updating their license text to switch to HTTPS there and decided not
to [1] which is IMHO a sane thing.

[1] https://issues.apache.org/jira/browse/LEGAL-457
--
Cordially
Philippe Ombredanne