2017-11-17 22:36:56

by Philippe Ombredanne

[permalink] [raw]
Subject: Re: [PATCH 6/6] media: usb: add SPDX identifiers to some code I wrote

On Fri, Nov 17, 2017 at 4:01 PM, Mauro Carvalho Chehab
<[email protected]> wrote:
> Em Fri, 17 Nov 2017 12:54:15 +0100
> Philippe Ombredanne <[email protected]> escreveu:
>
>> On Fri, Nov 17, 2017 at 11:21 AM, Mauro Carvalho Chehab
>> <[email protected]> wrote:
>> > As we're now using SPDX identifiers, on several
>> > media drivers I wrote, add the proper SPDX, identifying
>> > the license I meant.
>> >
>> > As we're now using the short license, it doesn't make sense to
>> > keep the original license text.
>> >
>> > Also, fix MODULE_LICENSE to properly identify GPL v2.
>> >
>> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
>>
>> Mauro,
>> Thanks ++ .... I can now get rid of a special license detection rule I
>> had added for the specific language of your notices in the
>> scancode-toolkit!
>
> :-)
>
> Yeah, I was too lazy to copy the usual GPL preamble on those
> drivers ;-)

I guess I built a lazyness checker with scancode to keep you check then ;)
But FWIW you are not alone there and at least your notices are/were
consistent across files ... there are still several hundred variations
of GPL notices in the kernel each with subtle or byzantine changes.

Some of them are rather funny like Evgeniy's thermal code being under
the "therms" of the GPL [1]

CC: Evgeniy Polyakov <[email protected]>

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/w1/slaves/w1_therm.c?h=v4.14-rc8#n8
--
Cordially
Philippe Ombredanne

From 1584354172587902794@xxx Fri Nov 17 22:31:22 +0000 2017
X-GM-THRID: 1584336194586684476
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread


2017-11-17 20:42:23

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 6/6] media: usb: add SPDX identifiers to some code I wrote

Hi Philippe,

On Friday, 17 November 2017 17:08:51 EET Philippe Ombredanne wrote:
> On Fri, Nov 17, 2017 at 4:01 PM, Mauro Carvalho Chehab wrote:
> > Em Fri, 17 Nov 2017 12:54:15 +0100 Philippe Ombredanne escreveu:
> >> On Fri, Nov 17, 2017 at 11:21 AM, Mauro Carvalho Chehab wrote:
> >> > As we're now using SPDX identifiers, on several
> >> > media drivers I wrote, add the proper SPDX, identifying
> >> > the license I meant.
> >> >
> >> > As we're now using the short license, it doesn't make sense to
> >> > keep the original license text.
> >> >
> >> > Also, fix MODULE_LICENSE to properly identify GPL v2.
> >> >
> >> > Signed-off-by: Mauro Carvalho Chehab <[email protected]>
> >>
> >> Mauro,
> >> Thanks ++ .... I can now get rid of a special license detection rule I
> >> had added for the specific language of your notices in the
> >> scancode-toolkit!
> >>
> > :-)
> >
> > Yeah, I was too lazy to copy the usual GPL preamble on those
> > drivers ;-)
>
> I guess I built a lazyness checker with scancode to keep you check then ;)
> But FWIW you are not alone there and at least your notices are/were
> consistent across files ... there are still several hundred variations
> of GPL notices in the kernel each with subtle or byzantine changes.
>
> Some of them are rather funny like Evgeniy's thermal code being under
> the "therms" of the GPL [1]

Isn't that very appropriate for the thermal code ?

https://en.wikipedia.org/wiki/Therm

Sorry, couldn't resist :)

> CC: Evgeniy Polyakov <[email protected]>
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri
> vers/w1/slaves/w1_therm.c?h=v4.14-rc8#n8

--
Regards,

Laurent Pinchart


From 1584339364715293517@xxx Fri Nov 17 18:36:00 +0000 2017
X-GM-THRID: 1584336194586684476
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread