2017-08-13 13:23:20

by Bhumika Goyal

Subject: [PATCH] ste_dma40: make stedma40_chan_cfg const

Make these const as they are only used during a copy operation.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/dma/ste_dma40.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index c3052fb..f4fab41 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -79,7 +79,7 @@
};

/* Default configuration for physcial memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
.mode = STEDMA40_MODE_PHYSICAL,
.dir = DMA_MEM_TO_MEM,

@@ -93,7 +93,7 @@
};

/* Default configuration for logical memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_log = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_log = {
.mode = STEDMA40_MODE_LOGICAL,
.dir = DMA_MEM_TO_MEM,

--
1.9.1

2017-08-14 12:40:34

by Linus Walleij

Subject: Re: [PATCH] ste_dma40: make stedma40_chan_cfg const

On Sun, Aug 13, 2017 at 3:23 PM, Bhumika Goyal <[email protected]> wrote:

> Make these const as they are only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2017-08-21 16:24:13

by Vinod Koul

Subject: Re: [PATCH] ste_dma40: make stedma40_chan_cfg const

On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
> Done using Coccinelle.

Pls make sure you use the right subsystem tags, hint, you cna check git log
on that subsystem/file to find the right ones

Applied after fixing the tags, thanks

--
~Vinod

2017-08-21 16:40:54

by Bhumika Goyal

Subject: Re: [PATCH] ste_dma40: make stedma40_chan_cfg const

On Mon, Aug 21, 2017 at 9:57 PM, Vinod Koul <[email protected]> wrote:
> On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
>> Make these const as they are only used during a copy operation.
>> Done using Coccinelle.
>
> Pls make sure you use the right subsystem tags, hint, you cna check git log
> on that subsystem/file to find the right ones
>

Thanks for the note. I will be more careful next time.

Thanks,
Bhumika

> Applied after fixing the tags, thanks
>
> --
> ~Vinod