2016-11-17 11:27:29

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH 0/2] powerpc: stack protector (-fstack-protector) support

Denis Kirjanov <[email protected]> writes:

> On Friday, September 30, 2016, Christophe Leroy <[email protected]>
> wrote:
>
>> Add HAVE_CC_STACKPROTECTOR to powerpc. This is copied from ARM.
>>
>> Not tested on PPC64, compile ok with ppc64_
>
>
> Hi Christophe,
>
> are you going to test it on ppc64? If not, I can take it

Did you get around to testing it?

It seems to be working here:

root@mpe-ubuntu-le:/sys/kernel/debug/provoke-crash# echo CORRUPT_STACK > DIRECT
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: c000000000671ed8

CPU: 1 PID: 3835 Comm: bash Not tainted 4.9.0-rc5-compiler_gcc-6.2.0-00075-gf41db6c7a3c8-dirty #464
Call Trace:
[c0000000dbf73a30] [c000000000541728] dump_stack+0xb8/0x100 (unreliable)

[c0000000dbf73a70] [c000000000219ba8] panic+0x14c/0x320
[c0000000dbf73b10] [c0000000000c27ec] __stack_chk_fail+0x2c/0x30
[c0000000dbf73b70] [c000000000671ed8] lkdtm_CORRUPT_STACK+0x88/0x90
[c0000000dbf73bf0] [6161616161616161] 0x6161616161616161
Rebooting in 10 seconds..


cheers


2016-11-18 12:43:51

by Denis Kirjanov

[permalink] [raw]
Subject: Re: [PATCH 0/2] powerpc: stack protector (-fstack-protector) support

On 11/17/16, Michael Ellerman <[email protected]> wrote:
> Denis Kirjanov <[email protected]> writes:
>
>> On Friday, September 30, 2016, Christophe Leroy <[email protected]>
>> wrote:
>>
>>> Add HAVE_CC_STACKPROTECTOR to powerpc. This is copied from ARM.
>>>
>>> Not tested on PPC64, compile ok with ppc64_
>>
>>
>> Hi Christophe,
>>
>> are you going to test it on ppc64? If not, I can take it

Not yet, I've broken my test machine :/ I need some time to recover

>
> Did you get around to testing it?
>
> It seems to be working here:
>
> root@mpe-ubuntu-le:/sys/kernel/debug/provoke-crash# echo CORRUPT_STACK >
> DIRECT
> Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in:
> c000000000671ed8
>
> CPU: 1 PID: 3835 Comm: bash Not tainted
> 4.9.0-rc5-compiler_gcc-6.2.0-00075-gf41db6c7a3c8-dirty #464
> Call Trace:
> [c0000000dbf73a30] [c000000000541728] dump_stack+0xb8/0x100 (unreliable)
>
> [c0000000dbf73a70] [c000000000219ba8] panic+0x14c/0x320
> [c0000000dbf73b10] [c0000000000c27ec] __stack_chk_fail+0x2c/0x30
> [c0000000dbf73b70] [c000000000671ed8] lkdtm_CORRUPT_STACK+0x88/0x90
> [c0000000dbf73bf0] [6161616161616161] 0x6161616161616161
> Rebooting in 10 seconds..
>
>
> cheers
>