2012-11-24 08:31:51

by Dave Young

Subject: [patch 7/8] kcmp selftests: print fail status instead of cause make error

In case kcmp_test exit non zero value it will cause make error.
Better way is just print the test failure status.

Signed-off-by: Dave Young <[email protected]>
---
tools/testing/selftests/kcmp/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/tools/testing/selftests/kcmp/Makefile 2012-11-23 23:10:18.000000000 +0800
+++ linux-2.6/tools/testing/selftests/kcmp/Makefile 2012-11-23 23:11:52.474414896 +0800
@@ -22,7 +22,7 @@ else
endif

run_tests: all
- ./kcmp_test
+ @./kcmp_test || echo "kcmp_test: [FAIL]"

clean:
rm -fr ./run_test

2012-11-24 09:45:47

by Pekka Enberg

Subject: Re: [patch 7/8] kcmp selftests: print fail status instead of cause make error

On Sat, Nov 24, 2012 at 10:29 AM, <[email protected]> wrote:
> In case kcmp_test exit non zero value it will cause make error.
> Better way is just print the test failure status.
>
> Signed-off-by: Dave Young <[email protected]>

Reviewed-by: Pekka Enberg <[email protected]>

> ---
> tools/testing/selftests/kcmp/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.orig/tools/testing/selftests/kcmp/Makefile 2012-11-23 23:10:18.000000000 +0800
> +++ linux-2.6/tools/testing/selftests/kcmp/Makefile 2012-11-23 23:11:52.474414896 +0800
> @@ -22,7 +22,7 @@ else
> endif
>
> run_tests: all
> - ./kcmp_test
> + @./kcmp_test || echo "kcmp_test: [FAIL]"
>
> clean:
> rm -fr ./run_test
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/