2012-11-24 08:33:28

by Dave Young

Subject: [patch 3/8] cpu-hotplug selftests: print failure status instead of cause make error

bash-4.1$ make -C cpu-hotplug run_tests
make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'
./on-off-test.sh
make: execvp: ./on-off-test.sh: Permission denied
make: *** [run_tests] Error 127
make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'

After applying the patch:
bash-4.1$ make -C cpu-hotplug run_tests
make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'
/bin/sh: ./on-off-test.sh: Permission denied
cpu-hotplug selftests: [FAIL]
make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'

Signed-off-by: Dave Young <[email protected]>
---
tools/testing/selftests/cpu-hotplug/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/tools/testing/selftests/cpu-hotplug/Makefile 2012-11-23 22:37:04.905724227 +0800
+++ linux-2.6/tools/testing/selftests/cpu-hotplug/Makefile 2012-11-23 22:38:43.125192126 +0800
@@ -1,6 +1,6 @@
all:

run_tests:
- ./on-off-test.sh
+ @./on-off-test.sh || echo "cpu-hotplug selftests: [FAIL]"

clean:

2012-11-24 09:43:06

by Pekka Enberg

Subject: Re: [patch 3/8] cpu-hotplug selftests: print failure status instead of cause make error

On Sat, Nov 24, 2012 at 10:29 AM, <[email protected]> wrote:
> bash-4.1$ make -C cpu-hotplug run_tests
> make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'
> ./on-off-test.sh
> make: execvp: ./on-off-test.sh: Permission denied
> make: *** [run_tests] Error 127
> make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'
>
> After applying the patch:
> bash-4.1$ make -C cpu-hotplug run_tests
> make: Entering directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'
> /bin/sh: ./on-off-test.sh: Permission denied
> cpu-hotplug selftests: [FAIL]
> make: Leaving directory `/home/dave/git/linux-2.6/tools/testing/selftests/cpu-hotplug'
>
> Signed-off-by: Dave Young <[email protected]>

Reviewed-by: Pekka Enberg <[email protected]>