2022-01-24 11:21:59

by Randy Dunlap

Subject: [PATCH] pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards

When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of
MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due
to missing DB1XXX symbols. The PCMCIA driver should be restricted
to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error.

ERROR: modpost: "bcsr_read" [drivers/pcmcia/db1xxx_ss.ko] undefined!
ERROR: modpost: "bcsr_mod" [drivers/pcmcia/db1xxx_ss.ko] undefined!

Fixes: 42a4f17dc356 ("MIPS: Alchemy: remove SOC_AU1X00 in favor of MIPS_ALCHEMY")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Dominik Brodowski <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Manuel Lauss <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Cc: [email protected]
---
drivers/pcmcia/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20220121.orig/drivers/pcmcia/Kconfig
+++ linux-next-20220121/drivers/pcmcia/Kconfig
@@ -151,7 +151,7 @@ config TCIC

config PCMCIA_ALCHEMY_DEVBOARD
tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
- depends on MIPS_ALCHEMY && PCMCIA
+ depends on MIPS_DB1XXX && PCMCIA
help
Enable this driver of you want PCMCIA support on your Alchemy
Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300

2022-01-24 18:59:47

by Manuel Lauss

Subject: Re: [PATCH] pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards

Hello,

On Sun, Jan 23, 2022 at 6:40 PM Randy Dunlap <[email protected]> wrote:
> When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of
> MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due
> to missing DB1XXX symbols. The PCMCIA driver should be restricted
> to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error.

> config PCMCIA_ALCHEMY_DEVBOARD
> tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
> - depends on MIPS_ALCHEMY && PCMCIA
> + depends on MIPS_DB1XXX && PCMCIA
> help
> Enable this driver of you want PCMCIA support on your Alchemy
> Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300

Seems sensible.
Acked-by: Manuel Lauss <[email protected]>

Thank you!
Manuel

2022-02-06 22:45:25

by Dominik Brodowski

Subject: Re: [PATCH] pcmcia: db1xxx_ss: restrict to MIPS_DB1XXX boards

Am Sun, Jan 23, 2022 at 09:40:31AM -0800 schrieb Randy Dunlap:
> When the MIPS_ALCHEMY board selection is MIPS_XXS1500 instead of
> MIPS_DB1XXX, the PCMCIA driver 'db1xxx_ss' has build errors due
> to missing DB1XXX symbols. The PCMCIA driver should be restricted
> to MIPS_DB1XXX instead of MIPS_ALCHEMY to fix this build error.
>
> ERROR: modpost: "bcsr_read" [drivers/pcmcia/db1xxx_ss.ko] undefined!
> ERROR: modpost: "bcsr_mod" [drivers/pcmcia/db1xxx_ss.ko] undefined!
>
> Fixes: 42a4f17dc356 ("MIPS: Alchemy: remove SOC_AU1X00 in favor of MIPS_ALCHEMY")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Dominik Brodowski <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: Manuel Lauss <[email protected]>
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: [email protected]

Applied to -pcmcia, thanks!

Dominik