2023-11-23 10:49:19

by Francesco Dolcini

Subject: [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on

From: Stefan Eichenberger <[email protected]>

Make sure that the wifi regulator is always on. The wifi driver itself
puts the wifi module into suspend mode. If we cut the power the driver
will crash when resuming from suspend.

Signed-off-by: Stefan Eichenberger <[email protected]>
Signed-off-by: Francesco Dolcini <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 5ce5fbf2b38e..f69b0c17560a 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -82,12 +82,9 @@ reg_module_wifi: regulator-module-wifi {
pinctrl-0 = <&pinctrl_wifi_pdn>;
gpio = <&lsio_gpio1 28 GPIO_ACTIVE_HIGH>;
enable-active-high;
+ regulator-always-on;
regulator-name = "wifi_pwrdn_fake_regulator";
regulator-settling-time-us = <100>;
-
- regulator-state-mem {
- regulator-off-in-suspend;
- };
};

reg_pcie_switch: regulator-pcie-switch {
--
2.25.1

2023-11-23 10:52:55

by Fabio Estevam

Subject: Re: [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on

Hi Francesco,

On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <[email protected]> wrote:
>
> From: Stefan Eichenberger <[email protected]>
>
> Make sure that the wifi regulator is always on. The wifi driver itself
> puts the wifi module into suspend mode. If we cut the power the driver
> will crash when resuming from suspend.
>
> Signed-off-by: Stefan Eichenberger <[email protected]>
> Signed-off-by: Francesco Dolcini <[email protected]>

I think this one deserves a Fixes tag.

2023-11-23 10:57:06

by Francesco Dolcini

Subject: Re: [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on

Hello Fabio,

On Thu, Nov 23, 2023 at 07:52:27AM -0300, Fabio Estevam wrote:
> On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <[email protected]> wrote:
> >
> > From: Stefan Eichenberger <[email protected]>
> >
> > Make sure that the wifi regulator is always on. The wifi driver itself
> > puts the wifi module into suspend mode. If we cut the power the driver
> > will crash when resuming from suspend.
> >
> > Signed-off-by: Stefan Eichenberger <[email protected]>
> > Signed-off-by: Francesco Dolcini <[email protected]>
>
> I think this one deserves a Fixes tag.

Fixes: ad0de4ceb706 ("arm64: dts: freescale: add initial apalis imx8 aka quadmax module support")

Shawn, I assume you could just pick the Fixes tag without me sending a
v2, if you disagree just speak-up.

Francesco

2023-12-06 01:48:31

by Shawn Guo

Subject: Re: [PATCH v1] arm64: dts: imx8-apalis: set wifi regulator to always-on

On Thu, Nov 23, 2023 at 11:56:39AM +0100, Francesco Dolcini wrote:
> Hello Fabio,
>
> On Thu, Nov 23, 2023 at 07:52:27AM -0300, Fabio Estevam wrote:
> > On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <[email protected]> wrote:
> > >
> > > From: Stefan Eichenberger <[email protected]>
> > >
> > > Make sure that the wifi regulator is always on. The wifi driver itself
> > > puts the wifi module into suspend mode. If we cut the power the driver
> > > will crash when resuming from suspend.
> > >
> > > Signed-off-by: Stefan Eichenberger <[email protected]>
> > > Signed-off-by: Francesco Dolcini <[email protected]>
> >
> > I think this one deserves a Fixes tag.
>
> Fixes: ad0de4ceb706 ("arm64: dts: freescale: add initial apalis imx8 aka quadmax module support")
>
> Shawn, I assume you could just pick the Fixes tag without me sending a
> v2, if you disagree just speak-up.

Applied with the Fixes tag, thanks!