2019-05-16 11:42:50

by Shengjiu Wang

Subject: [PATCH V5] ASoC: cs42xx8: add reset-gpios in binding document

Add reset-gpios property, which is optional.

Signed-off-by: Shengjiu Wang <[email protected]>
---
Changes in V5
- use GPIO_ACTIVE_LOW

Changes in V4
- use gpios instead of gpio

Changes in RESEND v3
- send updated binding document only

Changes in v3
- update binding document.

Changes in v2
- use devm_gpiod_get_optional instead of of_get_named_gpio

Documentation/devicetree/bindings/sound/cs42xx8.txt | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/cs42xx8.txt b/Documentation/devicetree/bindings/sound/cs42xx8.txt
index 8619a156d038..bbfe39347c20 100644
--- a/Documentation/devicetree/bindings/sound/cs42xx8.txt
+++ b/Documentation/devicetree/bindings/sound/cs42xx8.txt
@@ -14,6 +14,11 @@ Required properties:
- VA-supply, VD-supply, VLS-supply, VLC-supply: power supplies for the device,
as covered in Documentation/devicetree/bindings/regulator/regulator.txt

+Optional properties:
+
+ - reset-gpios : a GPIO spec to define which pin is connected to the chip's
+ !RESET pin
+
Example:

cs42888: codec@48 {
@@ -25,4 +30,5 @@ cs42888: codec@48 {
VD-supply = <&reg_audio>;
VLS-supply = <&reg_audio>;
VLC-supply = <&reg_audio>;
+ reset-gpios = <&pca9557_b 1 GPIO_ACTIVE_LOW>;
};
--
2.21.0

2019-05-16 11:50:01

by Fabio Estevam

Subject: Re: [alsa-devel] [PATCH V5] ASoC: cs42xx8: add reset-gpios in binding document

[You should always submit dt-bindings patches to Rob and to the
devicetree list as indicated by checkpatch]

On Thu, May 16, 2019 at 8:42 AM S.j. Wang <[email protected]> wrote:
>
> Add reset-gpios property, which is optional.
>
> Signed-off-by: Shengjiu Wang <[email protected]>

> +Optional properties:
> +
> + - reset-gpios : a GPIO spec to define which pin is connected to the chip's
> + !RESET pin
> +
> Example:
>
> cs42888: codec@48 {
> @@ -25,4 +30,5 @@ cs42888: codec@48 {
> VD-supply = <&reg_audio>;
> VLS-supply = <&reg_audio>;
> VLC-supply = <&reg_audio>;
> + reset-gpios = <&pca9557_b 1 GPIO_ACTIVE_LOW>;

Reviewed-by: Fabio Estevam <[email protected]>