2021-01-18 16:38:34

by Guido Günther

Subject: [PATCH] spi: imx: Don't print error on -EPROBEDEFER

This avoids

[ 0.962538] spi_imx 30820000.spi: bitbang start failed with -517

durig driver probe.

Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
Signed-off-by: Guido Günther <[email protected]>
---
drivers/spi/spi-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 73ca821763d6..5dc4ea4b4450 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1685,7 +1685,7 @@ static int spi_imx_probe(struct platform_device *pdev)
master->dev.of_node = pdev->dev.of_node;
ret = spi_bitbang_start(&spi_imx->bitbang);
if (ret) {
- dev_err(&pdev->dev, "bitbang start failed with %d\n", ret);
+ dev_err_probe(&pdev->dev, ret, "bitbang start failed\n");
goto out_bitbang_start;
}

--
2.29.2

2021-01-18 19:48:27

by Fabio Estevam

Subject: Re: [PATCH] spi: imx: Don't print error on -EPROBEDEFER

On Mon, Jan 18, 2021 at 1:31 PM Guido Günther <[email protected]> wrote:
>
> This avoids
>
> [ 0.962538] spi_imx 30820000.spi: bitbang start failed with -517
>
> durig driver probe.
>
> Fixes: 8197f489f4c4 ("spi: imx: Fix failure path leak on GPIO request error correctly")
> Signed-off-by: Guido Günther <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>