2021-06-09 15:35:15

by Zhen Lei

[permalink] [raw]
Subject: [PATCH 1/1] irqchip/irq-imx-gpcv2: remove unnecessary oom message

Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <[email protected]>
---
drivers/irqchip/irq-imx-gpcv2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
index 7031ef44de4f30c..5b5a365dbd5e447 100644
--- a/drivers/irqchip/irq-imx-gpcv2.c
+++ b/drivers/irqchip/irq-imx-gpcv2.c
@@ -228,10 +228,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
}

cd = kzalloc(sizeof(struct gpcv2_irqchip_data), GFP_KERNEL);
- if (!cd) {
- pr_err("%pOF: kzalloc failed!\n", node);
+ if (!cd)
return -ENOMEM;
- }

raw_spin_lock_init(&cd->rlock);

--
2.26.0.106.g9fadedd



Subject: [irqchip: irq/irqchip-next] irqchip/irq-imx-gpcv2: Remove unnecessary oom message

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: 76fc40ec22b9947351f6f9d37a86d47e72af4e50
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/76fc40ec22b9947351f6f9d37a86d47e72af4e50
Author: Zhen Lei <[email protected]>
AuthorDate: Wed, 09 Jun 2021 22:11:50 +08:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Fri, 11 Jun 2021 14:19:47 +01:00

irqchip/irq-imx-gpcv2: Remove unnecessary oom message

Fixes scripts/checkpatch.pl warning:
WARNING: Possible unnecessary 'out of memory' message

Remove it can help us save a bit of memory.

Signed-off-by: Zhen Lei <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-imx-gpcv2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
index 7031ef4..5b5a365 100644
--- a/drivers/irqchip/irq-imx-gpcv2.c
+++ b/drivers/irqchip/irq-imx-gpcv2.c
@@ -228,10 +228,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
}

cd = kzalloc(sizeof(struct gpcv2_irqchip_data), GFP_KERNEL);
- if (!cd) {
- pr_err("%pOF: kzalloc failed!\n", node);
+ if (!cd)
return -ENOMEM;
- }

raw_spin_lock_init(&cd->rlock);

2021-06-21 11:32:14

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH 1/1] irqchip/irq-imx-gpcv2: remove unnecessary oom message

On Wed, Jun 9, 2021 at 11:11 AM Zhen Lei <[email protected]> wrote:
>
> Fixes scripts/checkpatch.pl warning:
> WARNING: Possible unnecessary 'out of memory' message
>
> Remove it can help us save a bit of memory.
>
> Signed-off-by: Zhen Lei <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>