2023-09-21 23:13:05

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: imx-sdma: fix deadlock in interrupt handler

Hi Tim,

On Thu, Sep 21, 2023 at 6:57 AM Tim van der Staaij | Zign
<[email protected]> wrote:
>
> dev_warn internally acquires the lock that is already held when
> sdma_update_channel_loop is called. Therefore it is acquired twice and
> this is detected as a deadlock. Temporarily release the lock while
> logging to avoid this.
>
> Signed-off-by: Tim van der Staaij <[email protected]>
> Link: https://lore.kernel.org/all/AM0PR08MB308979EC3A8A53AE6E2D3408802CA@AM0PR08MB3089.eurprd08.prod.outlook.com/

checkpatch gives a warning on this patch:

WARNING: From:/Signed-off-by: email name mismatch: 'From: "Tim van der
Staaij | Zign" <[email protected]>' != 'Signed-off-by:
Tim van der Staaij <[email protected]>'

Should it contain a Fixes tag so that it can be backported to older
stable-kernels?

Reviewed-by: Fabio Estevam <[email protected]>