2013-04-19 15:05:57

by Eric Bénard

Subject: [PATCH] ARM: mx28: add dma channels for all auarts

Only auart0 was filled.
Tested on a custom i.MX283 board for ttyAPP1/2/3/4.

Signed-off-by: Eric Bénard <[email protected]>
---
arch/arm/boot/dts/imx28.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 25f2243..15933ed 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -886,6 +886,7 @@
compatible = "fsl,imx28-auart", "fsl,imx23-auart";
reg = <0x8006c000 0x2000>;
interrupts = <113 72 73>;
+ fsl,auart-dma-channel = <10 11>;
clocks = <&clks 45>;
status = "disabled";
};
@@ -894,6 +895,7 @@
compatible = "fsl,imx28-auart", "fsl,imx23-auart";
reg = <0x8006e000 0x2000>;
interrupts = <114 74 75>;
+ fsl,auart-dma-channel = <12 13>;
clocks = <&clks 45>;
status = "disabled";
};
@@ -902,6 +904,7 @@
compatible = "fsl,imx28-auart", "fsl,imx23-auart";
reg = <0x80070000 0x2000>;
interrupts = <115 76 77>;
+ fsl,auart-dma-channel = <14 15>;
clocks = <&clks 45>;
status = "disabled";
};
@@ -910,6 +913,7 @@
compatible = "fsl,imx28-auart", "fsl,imx23-auart";
reg = <0x80072000 0x2000>;
interrupts = <116 78 79>;
+ fsl,auart-dma-channel = <0 1>;
clocks = <&clks 45>;
status = "disabled";
};
--
1.7.11.7

2013-04-19 15:26:35

by Fabio Estevam

Subject: Re: [PATCH] ARM: mx28: add dma channels for all auarts

Hi Eric,

On Fri, Apr 19, 2013 at 12:05 PM, Eric Bénard <[email protected]> wrote:
> Only auart0 was filled.
> Tested on a custom i.MX283 board for ttyAPP1/2/3/4.
>
> Signed-off-by: Eric Bénard <[email protected]>
> ---
> arch/arm/boot/dts/imx28.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 25f2243..15933ed 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -886,6 +886,7 @@
> compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> reg = <0x8006c000 0x2000>;
> interrupts = <113 72 73>;
> + fsl,auart-dma-channel = <10 11>;

Now we use the generic 'dmas' binding to passing such information.

If you look at linux-next tree these UART dma channels are already
been passed via the new 'dmas' method:

auart1: serial@8006c000 {
compatible = "fsl,imx28-auart", "fsl,imx23-auart";
reg = <0x8006c000 0x2000>;
interrupts = <113 72 73>;
dmas = <&dma_apbx 10>, <&dma_apbx 11>;
dma-names = "rx", "tx";
clocks = <&clks 45>;
status = "disabled";
};

2013-04-19 16:11:49

by Eric Bénard

Subject: Re: [PATCH] ARM: mx28: add dma channels for all auarts

Hi Fabio,

Le Fri, 19 Apr 2013 12:26:33 -0300,
Fabio Estevam <[email protected]> a écrit :
> On Fri, Apr 19, 2013 at 12:05 PM, Eric Bénard <[email protected]> wrote:
> > Only auart0 was filled.
> > Tested on a custom i.MX283 board for ttyAPP1/2/3/4.
> >
> > Signed-off-by: Eric Bénard <[email protected]>
> > ---
> > arch/arm/boot/dts/imx28.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 25f2243..15933ed 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -886,6 +886,7 @@
> > compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> > reg = <0x8006c000 0x2000>;
> > interrupts = <113 72 73>;
> > + fsl,auart-dma-channel = <10 11>;
>
> Now we use the generic 'dmas' binding to passing such information.
>
> If you look at linux-next tree these UART dma channels are already
> been passed via the new 'dmas' method:
>
> auart1: serial@8006c000 {
> compatible = "fsl,imx28-auart", "fsl,imx23-auart";
> reg = <0x8006c000 0x2000>;
> interrupts = <113 72 73>;
> dmas = <&dma_apbx 10>, <&dma_apbx 11>;
> dma-names = "rx", "tx";
> clocks = <&clks 45>;
> status = "disabled";
> };

OK so forget my patch it was against 3.9-rc

Eric