2022-09-01 02:25:23

by Fabio Estevam

Subject: Re: [PATCH V4 3/4] ARM: dts: imx: update sdma node name format

Hi Joy.

On Wed, Aug 31, 2022 at 11:02 PM Joy Zou <[email protected]> wrote:
>
> change the sdma node name format 'sdma' into 'dma-controller'.

The changes looks good, but the commit log needs to be improved.

Please explain the rationale for changing the name. Something like this:

Node names should be generic, so change the node name from
'sdma' to 'dma-controller'.

Thanks

2022-09-01 03:21:22

by Joy Zou

Subject: RE: [EXT] Re: [PATCH V4 3/4] ARM: dts: imx: update sdma node name format

> -----Original Message-----
> From: Fabio Estevam <[email protected]>
> Sent: 2022年9月1日 10:10
> To: Joy Zou <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> dl-linux-imx <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: [EXT] Re: [PATCH V4 3/4] ARM: dts: imx: update sdma node name
> format
>
> Caution: EXT Email
>
> Hi Joy.
>
> On Wed, Aug 31, 2022 at 11:02 PM Joy Zou <[email protected]> wrote:
> >
> > change the sdma node name format 'sdma' into 'dma-controller'.
>
> The changes looks good, but the commit log needs to be improved.
>
> Please explain the rationale for changing the name. Something like this:
>
> Node names should be generic, so change the node name from 'sdma' to
> 'dma-controller'.
>
Ok, I will modify the commit log in patch v5.
Thank you very much!
BR
Joy Zou
> Thanks