2022-07-24 17:51:19

by Martin Kaiser

Subject: [PATCH v3 2/2] clk: imx25: make __mx25_clocks_init return void

The __mx25_clocks_init function always returns 0 and its only
caller does not check the return value. Let's remove it.

Signed-off-by: Martin Kaiser <[email protected]>
---
changes in v3:
- rebase against today's linux-next

changes in v2:
- send the patch to the clk maintainers

drivers/clk/imx/clk-imx25.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
index 263409fca1eb..72b30dd7f05f 100644
--- a/drivers/clk/imx/clk-imx25.c
+++ b/drivers/clk/imx/clk-imx25.c
@@ -74,7 +74,7 @@ enum mx25_clks {

static struct clk *clk[clk_max];

-static int __init __mx25_clocks_init(void __iomem *ccm_base)
+static void __init __mx25_clocks_init(void __iomem *ccm_base)
{
BUG_ON(!ccm_base);

@@ -222,8 +222,6 @@ static int __init __mx25_clocks_init(void __iomem *ccm_base)
imx_register_uart_clocks(6);

imx_print_silicon_rev("i.MX25", mx25_revision());
-
- return 0;
}

static void __init mx25_clocks_init_dt(struct device_node *np)
--
2.30.2

2022-07-25 11:12:20

by Fabio Estevam

Subject: Re: [PATCH v3 2/2] clk: imx25: make __mx25_clocks_init return void

On Sun, Jul 24, 2022 at 2:48 PM Martin Kaiser <[email protected]> wrote:
>
> The __mx25_clocks_init function always returns 0 and its only
> caller does not check the return value. Let's remove it.
>
> Signed-off-by: Martin Kaiser <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>