2021-06-22 01:33:02

by Shengjiu Wang

Subject: [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe

Don't need to print error message for defer probe

Signed-off-by: Shengjiu Wang <[email protected]>
---
changes in v2:
- use dev_err_probe instead of dev_dbg

sound/soc/fsl/fsl-asoc-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index 121e08c2af2a..24c890d76da0 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -708,8 +708,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
of_node_put(framemaster);

if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
- dev_err(&pdev->dev, "failed to find codec device\n");
ret = -EPROBE_DEFER;
+ dev_err_probe(&pdev->dev, ret, "failed to find codec device\n");
goto asrc_fail;
}

--
2.27.0

2021-06-22 01:48:16

by Fabio Estevam

Subject: Re: [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe

Hi Shengjiu,

On Mon, Jun 21, 2021 at 10:31 PM Shengjiu Wang <[email protected]> wrote:
>
> Don't need to print error message for defer probe
>
> Signed-off-by: Shengjiu Wang <[email protected]>
> ---
> changes in v2:
> - use dev_err_probe instead of dev_dbg
>
> sound/soc/fsl/fsl-asoc-card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> index 121e08c2af2a..24c890d76da0 100644
> --- a/sound/soc/fsl/fsl-asoc-card.c
> +++ b/sound/soc/fsl/fsl-asoc-card.c
> @@ -708,8 +708,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
> of_node_put(framemaster);
>
> if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
> - dev_err(&pdev->dev, "failed to find codec device\n");
> ret = -EPROBE_DEFER;
> + dev_err_probe(&pdev->dev, ret, "failed to find codec device\n");

I know I suggested dev_err_probe() before, but looking at this again, I realized
that the error message will never be printed.

Maybe the error message could just be deleted?

2021-06-22 01:56:12

by Shengjiu Wang

Subject: Re: [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe

On Tue, Jun 22, 2021 at 9:45 AM Fabio Estevam <[email protected]> wrote:
>
> Hi Shengjiu,
>
> On Mon, Jun 21, 2021 at 10:31 PM Shengjiu Wang <[email protected]> wrote:
> >
> > Don't need to print error message for defer probe
> >
> > Signed-off-by: Shengjiu Wang <[email protected]>
> > ---
> > changes in v2:
> > - use dev_err_probe instead of dev_dbg
> >
> > sound/soc/fsl/fsl-asoc-card.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> > index 121e08c2af2a..24c890d76da0 100644
> > --- a/sound/soc/fsl/fsl-asoc-card.c
> > +++ b/sound/soc/fsl/fsl-asoc-card.c
> > @@ -708,8 +708,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
> > of_node_put(framemaster);
> >
> > if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
> > - dev_err(&pdev->dev, "failed to find codec device\n");
> > ret = -EPROBE_DEFER;
> > + dev_err_probe(&pdev->dev, ret, "failed to find codec device\n");
>
> I know I suggested dev_err_probe() before, but looking at this again, I realized
> that the error message will never be printed.
>
> Maybe the error message could just be deleted?

so I think we can use the v1 one, use dev_dbg instead.

best regards
wang shengjiu

2021-06-22 02:18:22

by Fabio Estevam

Subject: Re: [RESEND PATCH v2] ASoC: fsl-asoc-card: change dev_err to dev_err_probe for defer probe

On Mon, Jun 21, 2021 at 10:53 PM Shengjiu Wang <[email protected]> wrote:

> so I think we can use the v1 one, use dev_dbg instead.

Agreed. I have just reviewed v1.

Thanks