2022-07-22 21:57:44

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 00/12] ARM: arm64: dts/clk: imx8mm: indentation whitespace cleanup

From: Marcel Ziswiler <[email protected]>


While synchronising them imx device trees with U-Boot I stumbled over
various checkpatch warnings. This series addresses those trivial
indentation and/or whitespace cleanups.

Changes in v2:
- The GPL part of the boilerplate license was actually GPL-2.0 only.
- Add Alexander's acked-by. Thanks!
- Add Lucas' acked-by. Thanks!

Marcel Ziswiler (12):
ARM: dts: imx6-sabrelite: change to use SPDX identifiers
ARM: dts: imx6qdl-mba6: don't use multiple blank lines
ARM: dts: imx6qdl: phytec: no spaces at start of line, indent use tabs
ARM: dts: imx6qdl-sabre: change to use SPDX identifiers
ARM: dts: imx7d-pico: indent use tabs, no spaces at start of line
ARM: dts: vf610: no spaces in indent but tabs
ARM: dts: vf610-twr: indent use tabs, no spaces at start of line
ARM: dts: vf610: don't use multiple blank lines
arm64: dts: imx8mm-venice-gw72xx-0x: blank line at end of file
arm64: dts: imx8mp-verdin: don't use multiple blank lines
arm64: dts: mnt-reform2: don't use multiple blank lines
clk: imx8mm: don't use multiple blank lines

arch/arm/boot/dts/imx6q-sabrelite.dts | 37 +------------------
arch/arm/boot/dts/imx6qdl-mba6.dtsi | 1 -
.../dts/imx6qdl-phytec-mira-peb-av-02.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 37 +------------------
arch/arm/boot/dts/imx7d-pico.dtsi | 10 ++---
arch/arm/boot/dts/vf610-pinfunc.h | 2 +-
arch/arm/boot/dts/vf610-twr.dts | 2 +-
arch/arm/boot/dts/vf610.dtsi | 1 -
.../dts/freescale/imx8mm-venice-gw72xx-0x.dts | 1 -
.../boot/dts/freescale/imx8mp-verdin.dtsi | 1 -
.../boot/dts/freescale/imx8mq-mnt-reform2.dts | 1 -
include/dt-bindings/clock/imx8mm-clock.h | 1 -
12 files changed, 10 insertions(+), 86 deletions(-)

--
2.35.1


2022-07-22 21:59:08

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 11/12] arm64: dts: mnt-reform2: don't use multiple blank lines

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warning:

arch/arm/boot/dts/imx8mq-mnt-reform2.dts:213: check: Please don't use
multiple blank lines

Signed-off-by: Marcel Ziswiler <[email protected]>
Acked-by: Lucas Stach <[email protected]>

---

Changes in v2:
- Add Lucas' acked-by. Thanks!

arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
index 8956a46788fa..055031bba8c4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-mnt-reform2.dts
@@ -210,7 +210,6 @@ &pwm2 {
status = "okay";
};

-
&reg_1p8v {
vin-supply = <&reg_main_5v>;
};
--
2.35.1

2022-07-22 22:00:21

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 09/12] arm64: dts: imx8mm-venice-gw72xx-0x: blank line at end of file

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warning:

Found possible blank line(s) at end of file
'arch/arm/boot/dts/imx8mm-venice-gw72xx-0x.dts'

Signed-off-by: Marcel Ziswiler <[email protected]>
---

(no changes since v1)

arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dts
index b1e7540f0281..641be3af989d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dts
@@ -17,4 +17,3 @@ chosen {
stdout-path = &uart2;
};
};
-
--
2.35.1

2022-07-22 22:00:32

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 10/12] arm64: dts: imx8mp-verdin: don't use multiple blank lines

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warning:

arch/arm/boot/dts/imx8mp-verdin.dtsi:281: check: Please don't use
multiple blank lines

Signed-off-by: Marcel Ziswiler <[email protected]>
---

(no changes since v1)

arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index c5987bdbb383..f062fdbb2719 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -286,7 +286,6 @@ &flexcan1 {
status = "disabled";
};

-
/* Verdin CAN_2 */
&flexcan2 {
pinctrl-names = "default";
--
2.35.1

2022-07-22 22:00:40

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 12/12] clk: imx8mm: don't use multiple blank lines

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warning:

include/dt-bindings/clock/imx8mm-clock.h:284: check: Please don't use
multiple blank lines

Signed-off-by: Marcel Ziswiler <[email protected]>

---

(no changes since v1)

include/dt-bindings/clock/imx8mm-clock.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/dt-bindings/clock/imx8mm-clock.h b/include/dt-bindings/clock/imx8mm-clock.h
index 47c6f7f9582c..1f768b2eeb1a 100644
--- a/include/dt-bindings/clock/imx8mm-clock.h
+++ b/include/dt-bindings/clock/imx8mm-clock.h
@@ -281,7 +281,6 @@
#define IMX8MM_CLK_CLKOUT2_DIV 256
#define IMX8MM_CLK_CLKOUT2 257

-
#define IMX8MM_CLK_END 258

#endif
--
2.35.1

2022-07-22 22:26:40

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 03/12] ARM: dts: imx6qdl: phytec: no spaces at start of line, indent use tabs

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warnings:

arch/arm/boot/dts/imx6qdl-phytec-mira-peb-av-02.dtsi:67: error: code
indent should use tabs where possible
arch/arm/boot/dts/imx6qdl-phytec-mira-peb-av-02.dtsi:67: warning:
please, no spaces at the start of a line

Signed-off-by: Marcel Ziswiler <[email protected]>
---

(no changes since v1)

arch/arm/boot/dts/imx6qdl-phytec-mira-peb-av-02.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-av-02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-av-02.dtsi
index 393475cb0f4d..0020dbb1722c 100644
--- a/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-av-02.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-phytec-mira-peb-av-02.dtsi
@@ -64,7 +64,7 @@ edt_ft5x06: touchscreen@38 {
interrupt-parent = <&gpio3>;
interrupts = <2 IRQ_TYPE_NONE>;
status = "disabled";
- };
+ };
};

&ipu1_di0_disp0 {
--
2.35.1

2022-07-22 22:32:04

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 02/12] ARM: dts: imx6qdl-mba6: don't use multiple blank lines

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warning:

arch/arm/boot/dts/imx6qdl-mba6.dtsi:247: check: Please don't use
multiple blank lines

Signed-off-by: Marcel Ziswiler <[email protected]>
Acked-by: Alexander Stein <[email protected]>

---

Changes in v2:
- Add Alexander's acked-by. Thanks!

arch/arm/boot/dts/imx6qdl-mba6.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
index f4dca20669d6..78555a618851 100644
--- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
@@ -244,7 +244,6 @@ &uart2 {
status = "okay";
};

-
&uart3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart3>;
--
2.35.1

2022-07-22 22:32:17

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 07/12] ARM: dts: vf610-twr: indent use tabs, no spaces at start of line

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warning:

arch/arm/boot/dts/vf610-twr.dts:172: warning: please, no spaces at the
start of a line

Signed-off-by: Marcel Ziswiler <[email protected]>
---

(no changes since v1)

arch/arm/boot/dts/vf610-twr.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
index dbb5ffcdcec4..6c246d5aa032 100644
--- a/arch/arm/boot/dts/vf610-twr.dts
+++ b/arch/arm/boot/dts/vf610-twr.dts
@@ -169,7 +169,7 @@ codec: sgtl5000@a {
VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_3p3v>;
clocks = <&clks VF610_CLK_SAI2>;
- };
+ };
};

&iomuxc {
--
2.35.1

2022-07-22 22:32:42

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 08/12] ARM: dts: vf610: don't use multiple blank lines

From: Marcel Ziswiler <[email protected]>

Avoid the following checkpatch warning:

arch/arm/boot/dts/vf610.dtsi:5: check: Please don't use multiple blank
lines

Signed-off-by: Marcel Ziswiler <[email protected]>
---

(no changes since v1)

arch/arm/boot/dts/vf610.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index 956182d08e74..2fba923821d0 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -2,7 +2,6 @@
//
// Copyright 2013 Freescale Semiconductor, Inc.

-
#include "vf500.dtsi"

&a5_cpu {
--
2.35.1

2022-07-22 22:33:26

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 06/12] ARM: dts: vf610: no spaces in indent but tabs

From: Marcel Ziswiler <[email protected]>

Avoid spaces in indent but rather use tabs.

Signed-off-by: Marcel Ziswiler <[email protected]>
---

(no changes since v1)

arch/arm/boot/dts/vf610-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-pinfunc.h b/arch/arm/boot/dts/vf610-pinfunc.h
index f1e5a7cf58a9..8bb970b0dff8 100644
--- a/arch/arm/boot/dts/vf610-pinfunc.h
+++ b/arch/arm/boot/dts/vf610-pinfunc.h
@@ -420,7 +420,7 @@
#define VF610_PAD_PTD29__FTM3_CH2 0x104 0x000 ALT4 0x0
#define VF610_PAD_PTD29__DSPI2_SIN 0x104 0x000 ALT5 0x0
#define VF610_PAD_PTD29__DEBUG_OUT11 0x104 0x000 ALT7 0x0
-#define VF610_PAD_PTD28__GPIO_66 0x108 0x000 ALT0 0x0
+#define VF610_PAD_PTD28__GPIO_66 0x108 0x000 ALT0 0x0
#define VF610_PAD_PTD28__FB_AD28 0x108 0x000 ALT1 0x0
#define VF610_PAD_PTD28__NF_IO12 0x108 0x000 ALT2 0x0
#define VF610_PAD_PTD28__I2C2_SCL 0x108 0x34C ALT3 0x1
--
2.35.1

2022-07-22 22:33:27

by Marcel Ziswiler

[permalink] [raw]
Subject: [PATCH v2 01/12] ARM: dts: imx6-sabrelite: change to use SPDX identifiers

From: Marcel Ziswiler <[email protected]>

Replace the license text with SPDX identifiers.

Avoid the following checkpatch warning:

arch/arm/boot/dts/imx6q-sabrelite.dts:1: warning: Missing or malformed
SPDX-License-Identifier tag in line 1

Signed-off-by: Marcel Ziswiler <[email protected]>

---

Changes in v2:
- The GPL part of the boilerplate license was actually GPL-2.0 only.

arch/arm/boot/dts/imx6q-sabrelite.dts | 37 +--------------------------
1 file changed, 1 insertion(+), 36 deletions(-)

diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts
index dc51262e7b2f..7c6a2f234ccb 100644
--- a/arch/arm/boot/dts/imx6q-sabrelite.dts
+++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
@@ -1,43 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0 OR X11
/*
* Copyright 2011 Freescale Semiconductor, Inc.
* Copyright 2011 Linaro Ltd.
*
- * This file is dual-licensed: you can use it either under the terms
- * of the GPL or the X11 license, at your option. Note that this dual
- * licensing only applies to this file, and not this project as a
- * whole.
- *
- * a) This file is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * version 2 as published by the Free Software Foundation.
- *
- * This file is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * Or, alternatively,
- *
- * b) Permission is hereby granted, free of charge, to any person
- * obtaining a copy of this software and associated documentation
- * files (the "Software"), to deal in the Software without
- * restriction, including without limitation the rights to use,
- * copy, modify, merge, publish, distribute, sublicense, and/or
- * sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following
- * conditions:
- *
- * The above copyright notice and this permission notice shall be
- * included in all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
- * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
- * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
- * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
- * OTHER DEALINGS IN THE SOFTWARE.
*/

/dts-v1/;
--
2.35.1

2022-07-24 00:33:40

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH v2 10/12] arm64: dts: imx8mp-verdin: don't use multiple blank lines

Hi Marcel,

Thank you for the patch.

On Fri, Jul 22, 2022 at 11:54:43PM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> Avoid the following checkpatch warning:
>
> arch/arm/boot/dts/imx8mp-verdin.dtsi:281: check: Please don't use
> multiple blank lines
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
>
> (no changes since v1)
>
> arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index c5987bdbb383..f062fdbb2719 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -286,7 +286,6 @@ &flexcan1 {
> status = "disabled";
> };
>
> -
> /* Verdin CAN_2 */
> &flexcan2 {
> pinctrl-names = "default";

--
Regards,

Laurent Pinchart

2022-07-25 11:10:10

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH v2 00/12] ARM: arm64: dts/clk: imx8mm: indentation whitespace cleanup

Hi Marcel,

On Fri, Jul 22, 2022 at 6:55 PM Marcel Ziswiler <[email protected]> wrote:
>
> From: Marcel Ziswiler <[email protected]>
>
>
> While synchronising them imx device trees with U-Boot I stumbled over
> various checkpatch warnings. This series addresses those trivial
> indentation and/or whitespace cleanups.

Thanks for doing this cleanup:

Reviewed-by: Fabio Estevam <[email protected]>

2022-08-21 08:07:19

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v2 00/12] ARM: arm64: dts/clk: imx8mm: indentation whitespace cleanup

On Fri, Jul 22, 2022 at 11:54:33PM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
>
> While synchronising them imx device trees with U-Boot I stumbled over
> various checkpatch warnings. This series addresses those trivial
> indentation and/or whitespace cleanups.
>
> Changes in v2:
> - The GPL part of the boilerplate license was actually GPL-2.0 only.
> - Add Alexander's acked-by. Thanks!
> - Add Lucas' acked-by. Thanks!
>
> Marcel Ziswiler (12):
> ARM: dts: imx6-sabrelite: change to use SPDX identifiers
> ARM: dts: imx6qdl-mba6: don't use multiple blank lines
> ARM: dts: imx6qdl: phytec: no spaces at start of line, indent use tabs
> ARM: dts: imx6qdl-sabre: change to use SPDX identifiers
> ARM: dts: imx7d-pico: indent use tabs, no spaces at start of line
> ARM: dts: vf610: no spaces in indent but tabs
> ARM: dts: vf610-twr: indent use tabs, no spaces at start of line
> ARM: dts: vf610: don't use multiple blank lines
> arm64: dts: imx8mm-venice-gw72xx-0x: blank line at end of file
> arm64: dts: imx8mp-verdin: don't use multiple blank lines
> arm64: dts: mnt-reform2: don't use multiple blank lines
> clk: imx8mm: don't use multiple blank lines

Applied all, thanks!

2022-08-25 21:03:52

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH v2 12/12] clk: imx8mm: don't use multiple blank lines

On 22-07-22 23:54:45, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> Avoid the following checkpatch warning:
>
> include/dt-bindings/clock/imx8mm-clock.h:284: check: Please don't use
> multiple blank lines
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

>
> ---
>
> (no changes since v1)
>
> include/dt-bindings/clock/imx8mm-clock.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/imx8mm-clock.h b/include/dt-bindings/clock/imx8mm-clock.h
> index 47c6f7f9582c..1f768b2eeb1a 100644
> --- a/include/dt-bindings/clock/imx8mm-clock.h
> +++ b/include/dt-bindings/clock/imx8mm-clock.h
> @@ -281,7 +281,6 @@
> #define IMX8MM_CLK_CLKOUT2_DIV 256
> #define IMX8MM_CLK_CLKOUT2 257
>
> -
> #define IMX8MM_CLK_END 258
>
> #endif
> --
> 2.35.1
>

2022-09-02 18:52:41

by Abel Vesa

[permalink] [raw]
Subject: Re: [PATCH v2 12/12] clk: imx8mm: don't use multiple blank lines

On 22-07-22 23:54:45, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> Avoid the following checkpatch warning:
>
> include/dt-bindings/clock/imx8mm-clock.h:284: check: Please don't use
> multiple blank lines
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Applied this one, thanks!

>
> ---
>
> (no changes since v1)
>
> include/dt-bindings/clock/imx8mm-clock.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/imx8mm-clock.h b/include/dt-bindings/clock/imx8mm-clock.h
> index 47c6f7f9582c..1f768b2eeb1a 100644
> --- a/include/dt-bindings/clock/imx8mm-clock.h
> +++ b/include/dt-bindings/clock/imx8mm-clock.h
> @@ -281,7 +281,6 @@
> #define IMX8MM_CLK_CLKOUT2_DIV 256
> #define IMX8MM_CLK_CLKOUT2 257
>
> -
> #define IMX8MM_CLK_END 258
>
> #endif
> --
> 2.35.1
>