On Tue, Sep 16, 2014 at 5:08 AM, Dmitry Lavnikevich
<[email protected]> wrote:
> + regulators {
> + sound_1v8: regulator@2 {
We usually start counting from @0.
> + compatible = "regulator-fixed";
> + reg = <2>;
> + regulator-name = "i2s-audio-1v8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
No need to have this 'regulator-always-on'
> + };
> +
> + sound_3v3: regulator@3 {
,so this one should be @1.
> + compatible = "regulator-fixed";
> + reg = <3>;
> + regulator-name = "i2s-audio-3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
No need to have this 'regulator-always-on'
> +&ssi2 {
> + fsl,mode = "i2s-slave";
Please remove this 'fsl,mode' property. It is ignored by the fsl_ssi driver.
On 01/10/14 15:11, Fabio Estevam wrote:
> On Tue, Sep 16, 2014 at 5:08 AM, Dmitry Lavnikevich
> <[email protected]> wrote:
>
>> + regulators {
>> + sound_1v8: regulator@2 {
>
> We usually start counting from @0.
>
...
>> + };
>> +
>> + sound_3v3: regulator@3 {
>
> ,so this one should be @1.
@0 and @1 are used for "usb_otg_vbus" and "usb_h1_vbus" regulators in
dts for phyFLEX module (imx6qdl-phytec-pfla02.dtsi) which gets included
before base board dts (imx6qdl-phytec-pbab01.dtsi)
>> + compatible = "regulator-fixed";
>> + reg = <2>;
>> + regulator-name = "i2s-audio-1v8";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + regulator-always-on;
>
> No need to have this 'regulator-always-on'
>
...
>> + compatible = "regulator-fixed";
>> + reg = <3>;
>> + regulator-name = "i2s-audio-3v3";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-always-on;
>
> No need to have this 'regulator-always-on'
>
why is there no need for 'regulator-alweys-on'? I see it in
similar fixed regulator descriptions in imx6qdl-sabrelite.dtsi,
imx6qdl-wandboard.dtsi, imx6qdl-nitrogen6x.dtsi and many other
boards.
>> +&ssi2 {
>> + fsl,mode = "i2s-slave";
>
> Please remove this 'fsl,mode' property. It is ignored by the fsl_ssi driver.
yes, thanks. It is present in Documentation but now I see that it
was actually removed not that long ago. I will remove this
property with next patchset.
On Wed, Oct 1, 2014 at 10:40 AM, Dmitry Lavnikevich
<[email protected]> wrote:
>> No need to have this 'regulator-always-on'
>>
>
> why is there no need for 'regulator-alweys-on'? I see it in
For a regulator that is not GPIO controlled you don't need to pass
'regulator-always-on'.
>
>>> +&ssi2 {
>>> + fsl,mode = "i2s-slave";
>>
>>
>> Please remove this 'fsl,mode' property. It is ignored by the fsl_ssi
>> driver.
>
>
> yes, thanks. It is present in Documentation but now I see that it
> was actually removed not that long ago. I will remove this
> property with next patchset.
Correct, I recently sent a patch removing it and it is in Mark's tree now:
https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/commit/?h=topic/fsl-ssi&id=b93427b1c057841602e0fe2005153a6e82f2e658
On 01/10/14 16:45, Fabio Estevam wrote:
> On Wed, Oct 1, 2014 at 10:40 AM, Dmitry Lavnikevich
> <[email protected]> wrote:
>
>>> No need to have this 'regulator-always-on'
>>>
>>
>> why is there no need for 'regulator-alweys-on'? I see it in
>
> For a regulator that is not GPIO controlled you don't need to pass
> 'regulator-always-on'.
Ok, I will remove it also.
I will wait some time for other notes on patches and resend patchset.