2022-05-28 18:40:35

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data

Hi Ming,

On Fri, May 27, 2022 at 7:25 AM Ming Qian <[email protected]> wrote:
>
> There is a hardware bug that it will load
> the first 128 bytes of configuration data twice,
> it will led to some configure error.
> so shift the configuration data 128 bytes,
> and make the first 128 bytes all zero,
> then hardware will load the 128 zero twice,
> and ignore them as garbage.
> then the configuration data can be loaded correctly
>
> Signed-off-by: Ming Qian <[email protected]>
> Reviewed-by: Mirela Rabulea <[email protected]>
> Reviewed-by: Tommaso Merciai <[email protected]>

Fixes tag?


2022-05-28 20:37:04

by Ming Qian

[permalink] [raw]
Subject: RE: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data

> From: Fabio Estevam <[email protected]>
> Sent: 2022年5月27日 19:12
> To: Ming Qian <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>; Mirela Rabulea (OSS)
> <[email protected]>; Hans Verkuil <[email protected]>;
> Shawn Guo <[email protected]>; Sascha Hauer <[email protected]>;
> Sascha Hauer <[email protected]>; dl-linux-imx <[email protected]>;
> linux-media <[email protected]>; linux-kernel
> <[email protected]>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <[email protected]>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <[email protected]>
> Subject: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the
> configuration data
>
> Caution: EXT Email
>
> Hi Ming,
>
> On Fri, May 27, 2022 at 7:25 AM Ming Qian <[email protected]> wrote:
> >
> > There is a hardware bug that it will load the first 128 bytes of
> > configuration data twice, it will led to some configure error.
> > so shift the configuration data 128 bytes, and make the first 128
> > bytes all zero, then hardware will load the 128 zero twice, and ignore
> > them as garbage.
> > then the configuration data can be loaded correctly
> >
> > Signed-off-by: Ming Qian <[email protected]>
> > Reviewed-by: Mirela Rabulea <[email protected]>
> > Reviewed-by: Tommaso Merciai <[email protected]>
>
> Fixes tag?

Hi Fabio,
It's a hardware issue, so I'm not sure is it a driver issue that I fix it.
Or I just check which patch includes the code I changed, and add the fix tag?

Ming