2021-03-06 11:43:48

by Peng Fan (OSS)

Subject: [PATCH] arm64: dts: imx8mp: add wdog2/3 nodes

From: Peng Fan <[email protected]>

There is wdog[2,3] in i.MX8MP, so add them, all wdogs share the
same clock root, so use the wdog1 clk here.

Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index c7523fd4eae9..05dd04116f2e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -312,6 +312,22 @@ wdog1: watchdog@30280000 {
status = "disabled";
};

+ wdog2: watchdog@30290000 {
+ compatible = "fsl,imx8mp-wdt", "fsl,imx21-wdt";
+ reg = <0x30290000 0x10000>;
+ interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MP_CLK_WDOG2_ROOT>;
+ status = "disabled";
+ };
+
+ wdog3: watchdog@302a0000 {
+ compatible = "fsl,imx8mp-wdt", "fsl,imx21-wdt";
+ reg = <0x302a0000 0x10000>;
+ interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MP_CLK_WDOG3_ROOT>;
+ status = "disabled";
+ };
+
iomuxc: pinctrl@30330000 {
compatible = "fsl,imx8mp-iomuxc";
reg = <0x30330000 0x10000>;
--
2.30.0

2021-03-06 12:51:39

by Fabio Estevam

Subject: Re: [PATCH] arm64: dts: imx8mp: add wdog2/3 nodes

Hi Peng,

On Sat, Mar 6, 2021 at 8:41 AM <[email protected]> wrote:
>
> From: Peng Fan <[email protected]>
>
> There is wdog[2,3] in i.MX8MP, so add them, all wdogs share the
> same clock root, so use the wdog1 clk here.

The patch looks good, but I don't understand this sentence where you
state that "all wdogs share the same clock root, so use the wdog1 clk
here."

wdog1 uses IMX8MP_CLK_WDOG1_ROOT
wdog2 uses IMX8MP_CLK_WDOG2_ROOT
wdog3 uses IMX8MP_CLK_WDOG3_ROOT

Please clarify.