2022-04-30 16:41:17

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7902: fix pcie bindings

Hi Tim,

On Fri, Apr 29, 2022 at 1:13 PM Tim Harvey <[email protected]> wrote:
>
> Update the pcie bindings to the correct dt bindings:
> pcie_phy:
> - use pcie0_refclk
> - add required clock-names
> pcie:
> - remove pcie_phy clock as it comes from phy driver
>
> Signed-off-by: Tim Harvey <[email protected]>

It seems you missed the Fixes tag.

Reviewed-by: Fabio Estevam <[email protected]>


2022-05-02 13:10:30

by Tim Harvey

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7902: fix pcie bindings

On Fri, Apr 29, 2022 at 9:18 AM Fabio Estevam <[email protected]> wrote:
>
> Hi Tim,
>
> On Fri, Apr 29, 2022 at 1:13 PM Tim Harvey <[email protected]> wrote:
> >
> > Update the pcie bindings to the correct dt bindings:
> > pcie_phy:
> > - use pcie0_refclk
> > - add required clock-names
> > pcie:
> > - remove pcie_phy clock as it comes from phy driver
> >
> > Signed-off-by: Tim Harvey <[email protected]>
>
> It seems you missed the Fixes tag.
>
> Reviewed-by: Fabio Estevam <[email protected]>

Fabio,

it didn't really 'fix' anything but dt syntax. PCIe works without this patch.

Best Regards,

Tim