On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote:
> The size of written data was added to user supplied value rather than
> written at the provided address.
You might want to work on the commit message a little, something like
the following, but feel free to reword as seen fit.
The 'retlen' points to a variable representing the number of data bytes
written/read (see include/linux/mtd/mtd.h) by the current invocation of
the function. This variable must be set, not incremented.
Otherwise, the patch is correct I believe:
Acked-by: Marek Vasut <[email protected]>
> Signed-off-by: Michal Suchanek <[email protected]>
> ---
> drivers/mtd/devices/m25p80.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 7c8b169..0b2bc21 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -102,7 +102,7 @@ static void m25p80_write(struct spi_nor *nor, loff_t
> to, size_t len,
>
> spi_sync(spi, &m);
>
> - *retlen += m.actual_length - cmd_sz;
> + *retlen = m.actual_length - cmd_sz;
> }
>
> static inline unsigned int m25p80_rx_nbits(struct spi_nor *nor)
Best regards,
Marek Vasut
On 30 April 2015 at 20:43, Marek Vasut <[email protected]> wrote:
> On Thursday, April 30, 2015 at 03:33:47 PM, Michal Suchanek wrote:
>> The size of written data was added to user supplied value rather than
>> written at the provided address.
>
> You might want to work on the commit message a little, something like
> the following, but feel free to reword as seen fit.
>
> The 'retlen' points to a variable representing the number of data bytes
> written/read (see include/linux/mtd/mtd.h) by the current invocation of
> the function. This variable must be set, not incremented.
>
> Otherwise, the patch is correct I believe:
>
> Acked-by: Marek Vasut <[email protected]>
>
ok, I will send an updated version.
Thanks
Michal