2015-05-07 16:58:16

by Boris Ostrovsky

Subject: [PATCH] xen/arm: Define xen_arch_suspend()

Commit 2b953a5e994c ("xen: Suspend ticks on all CPUs during suspend")
introduced xen_arch_suspend() routine but did so only for x86, breaking
ARM builds.

We need to add it to ARM as well.

Signed-off-by: Boris Ostrovsky <[email protected]>
Reported-by: Michal Suchanek <[email protected]>
Tested-by: Stefano Stabellini <[email protected]>
---
arch/arm/xen/enlighten.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
index 224081c..7d0f070 100644
--- a/arch/arm/xen/enlighten.c
+++ b/arch/arm/xen/enlighten.c
@@ -272,6 +272,7 @@ void xen_arch_pre_suspend(void) { }
void xen_arch_post_suspend(int suspend_cancelled) { }
void xen_timer_resume(void) { }
void xen_arch_resume(void) { }
+void xen_arch_suspend(void) { }


/* In the hypervisor.S file. */
--
2.1.0

2015-05-07 19:22:49

by Michal Suchanek

Subject: Re: [PATCH] xen/arm: Define xen_arch_suspend()

On 7 May 2015 at 18:55, Boris Ostrovsky <[email protected]> wrote:
> Commit 2b953a5e994c ("xen: Suspend ticks on all CPUs during suspend")
> introduced xen_arch_suspend() routine but did so only for x86, breaking
> ARM builds.
>
> We need to add it to ARM as well.
>
> Signed-off-by: Boris Ostrovsky <[email protected]>
> Reported-by: Michal Suchanek <[email protected]>
> Tested-by: Stefano Stabellini <[email protected]>
Tested-by: Michal Suchanek <[email protected]>

Thanks

2015-05-18 12:39:49

by David Vrabel

Subject: Re: [Xen-devel] [PATCH] xen/arm: Define xen_arch_suspend()

On 07/05/15 17:55, Boris Ostrovsky wrote:
> Commit 2b953a5e994c ("xen: Suspend ticks on all CPUs during suspend")
> introduced xen_arch_suspend() routine but did so only for x86, breaking
> ARM builds.
>
> We need to add it to ARM as well.

Applied to for-linus-4.1b, thanks.

Sorry for the delay, I assumed that Stefano would have picked this up.

David