On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring <[email protected]> wrote:
>
> > The memory priv->bus_desc.provider_name allocated by kstrdup() is not
> > freed correctly.
Personally I thought his commit message was perfectly fine. A little
unorthodox, but it works.
> How do you think about to choose an imperative wording for
> a corresponding change description?
...but this! This is word salad.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
>
> Regards,
> Markus
On 8/19/2020 9:35 PM, Oliver O'Halloran wrote:
> On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring <[email protected]> wrote:
>>
>>> The memory priv->bus_desc.provider_name allocated by kstrdup() is not
>>> freed correctly.
>
> Personally I thought his commit message was perfectly fine. A little
> unorthodox, but it works.
>
>> How do you think about to choose an imperative wording for
>> a corresponding change description?
>
> ...but this! This is word salad.
Talented students are trained by strict teacher. All of us is trying to make things better.
>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
>>
>> Regards,
>> Markus
>
>