2019-11-03 12:34:07

by Markus Elfring

Subject: [PATCH] powerpc/papr_scm: Delete unnecessary assi gnment for the field “owner”

From: Markus Elfring <[email protected]>
Date: Sun, 3 Nov 2019 13:23:13 +0100

The field “owner” is set by the core.
Thus delete an unneeded initialisation.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Markus Elfring <[email protected]>
---
arch/powerpc/platforms/pseries/papr_scm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index ee07d0718bf1..f87b474d25a7 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -513,7 +513,6 @@ static struct platform_driver papr_scm_driver = {
.remove = papr_scm_remove,
.driver = {
.name = "papr_scm",
- .owner = THIS_MODULE,
.of_match_table = papr_scm_match,
},
};
--
2.23.0

2019-11-03 23:07:50

by Oliver O'Halloran

Subject: Re: [PATCH] powerpc/papr_scm: Delete unnecessary ass ignment for the field “owner”

On Sun, Nov 3, 2019 at 11:31 PM Markus Elfring <[email protected]> wrote:
>
> From: Markus Elfring <[email protected]>
> Date: Sun, 3 Nov 2019 13:23:13 +0100
>
> The field “owner” is set by the core.
> Thus delete an unneeded initialisation.

Acked-by: Oliver O'Halloran <[email protected]>

>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> arch/powerpc/platforms/pseries/papr_scm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index ee07d0718bf1..f87b474d25a7 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -513,7 +513,6 @@ static struct platform_driver papr_scm_driver = {
> .remove = papr_scm_remove,
> .driver = {
> .name = "papr_scm",
> - .owner = THIS_MODULE,
> .of_match_table = papr_scm_match,
> },
> };
> --
> 2.23.0
>

2019-11-04 11:00:03

by Vaibhav Jain

Subject: Re: [PATCH] powerpc/papr_scm: Delete unnecessary assignment for the field “owner”

Markus Elfring <[email protected]> writes:

> From: Markus Elfring <[email protected]>
> Date: Sun, 3 Nov 2019 13:23:13 +0100
>
> The field “owner” is set by the core.
> Thus delete an unneeded initialisation.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> arch/powerpc/platforms/pseries/papr_scm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
> index ee07d0718bf1..f87b474d25a7 100644
> --- a/arch/powerpc/platforms/pseries/papr_scm.c
> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
> @@ -513,7 +513,6 @@ static struct platform_driver papr_scm_driver = {
> .remove = papr_scm_remove,
> .driver = {
> .name = "papr_scm",
> - .owner = THIS_MODULE,
> .of_match_table = papr_scm_match,
> },
> };
> --
> 2.23.0
>
LGTM

Acked-by: Vaibhav Jain <[email protected]>

Thanks,
--
Vaibhav Jain <[email protected]>
Linux Technology Center, IBM India Pvt. Ltd.