2012-10-19 19:10:43

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c

On Thu, Sep 27, 2012 at 10:57:51PM +0900, YAMANE Toshiaki wrote:
> fixed below checkpatch warning.
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <[email protected]>

Your coding style cleanup patch introduced more coding style errors, not
good. Please always remember to use checkpatch.pl on your patches you
create.

please fix up.

greg k-h

2012-10-24 03:05:41

by YAMANE Toshiaki

Subject: [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c

fixed below checkpatch warning.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...

Signed-off-by: YAMANE Toshiaki <[email protected]>
---
drivers/staging/sbe-2t3e3/main.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/sbe-2t3e3/main.c b/drivers/staging/sbe-2t3e3/main.c
index f3dbef6..c8e0398 100644
--- a/drivers/staging/sbe-2t3e3/main.c
+++ b/drivers/staging/sbe-2t3e3/main.c
@@ -135,9 +135,10 @@ void t3e3_read_card_serial_number(struct channel *sc)
for (i = 0; i < 3; i++)
sc->ether.card_serial_number[i] = t3e3_eeprom_read_word(sc, 10 + i);

- printk(KERN_INFO "SBE wanPMC-2T3E3 serial number: %04X%04X%04X\n",
- sc->ether.card_serial_number[0], sc->ether.card_serial_number[1],
- sc->ether.card_serial_number[2]);
+ netdev_info(sc->dev, "SBE wanPMC-2T3E3 serial number: %04X%04X%04X\n",
+ sc->ether.card_serial_number[0],
+ sc->ether.card_serial_number[1],
+ sc->ether.card_serial_number[2]);
}

/*
--
1.7.9.5

2012-10-24 04:15:13

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c

On Wed, Oct 24, 2012 at 12:05:28PM +0900, YAMANE Toshiaki wrote:
> fixed below checkpatch warning.
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <[email protected]>

I never got the 3/3 patch in this series :(

greg k-h

2012-10-24 05:38:13

by YAMANE Toshiaki

Subject: Re: [PATCH 1/3] staging/sbe-2t3e3: Use netdev_ printks in main.c

On Wed, Oct 24, 2012 at 1:15 PM, Greg Kroah-Hartman
<[email protected]> wrote:
> On Wed, Oct 24, 2012 at 12:05:28PM +0900, YAMANE Toshiaki wrote:
>> fixed below checkpatch warning.
>> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>>
>> Signed-off-by: YAMANE Toshiaki <[email protected]>
>
> I never got the 3/3 patch in this series :(

I know!
# thanks, I will learn more ways to send patch

--

Regards,

YAMANE Toshiaki