2014-10-04 13:24:46

by J. German Rivera

[permalink] [raw]
Subject: [PATCH 0/3 v3] drivers/bus: Freescale Management Complex bus driver patch series

This patch series introduces Linux support for the Freescale
Management Complex (fsl-mc) hardware. This patch series is dependent
on the patch series "ARM64: Add support for FSL's LS2085A SoC"
(http://thread.gmane.org/gmane.linux.ports.arm.kernel/351829)

The fsl-mc is a hardware resource manager that manages specialized
hardware objects used in network-oriented packet processing
applications. After the fsl-mc block is enabled, pools of hardware
resources are available, such as queues, buffer poools, I/O
interfaces. These resources are building blocks that can be
used to create functional hardware objects such as network
interfaces, crypto accelerator instances, or L2 switches.

All the fsl-mc managed hardware resources/objects are represented in
a physical grouping mechanism called a 'container' or DPRC (data
path resource container).

>From the point of view of an OS, a DPRC functions similar to a plug
and play bus. Using fsl-mc commands software can enumerate the
contents of the DPRC discovering the hardware objects present
and binding them to drivers. Hardware objects can be created
and removed dynamically, providing hot pluggability of the hardware
objects.

Software contexts interact with the fsl-mc by sending commands through
a memory mapped hardware interface called an "MC portal". Every
fsl-mc object type has a command set to manage the objects. Key
DPRC commands include:
-create/destroy a DPRC
-enumerate objects and resource pools in the DPRC, including
identifying mappable regions and the number of IRQs an object
may have
-IRQ configuration
-move objects/resources between DPRCs
-connecting objects (e.g. connecting a network interface to
an L2 switch port)
-reset

Patch 1 contains a minimal set of low level functions to send an
d receive commands to the fsl-mc. It includes support for basic
management commands and commands to manipulate DPRC objects.

Patch 2 contains a platform device driver that sets up and registers
the basic bus infrastructure including support for adding/removing
devices, register/unregister of drivers, and bus match support
to bind devices to drivers.

Patch 3 contains an driver that manages DPRC objects (the
container that holds the hardware resources). This driver
functions as a bus controller and handles enumeration
of the objects in the container and hotplug events.

CHANGE HISTORY

Changes in v3:
- Addressed pending issues not resolved in v2:
* Removed Doxygen comments as requested by Greg Kroah-Hartman
* Moved newly added FSL-specific header files from include/linux to
include/linux/fsl
* Changed wording of licenses in MC flib source files
* Fixed sparse warning about context imbalance in 'mc_send_command'

- Addressed additional comments from Kim Phillips, Scott Wood and
Timur Tabi. Details in each patch.

Issues pending resolution not addressed by v3:
- Checkpatch warnings:
* WARNING: DT compatible string "fsl,qoriq-mc" appears un-documented
This warning will go away once the prerequisite patch series is
accepted upstream.
* WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
This warning still happens even after adding MAINTAINERS file entries in
the same patch where new files were added

Changes in v2:
- Added reference to the patch series this patch is dependent on for
device tree and device tree bindings changes. (See above).
- Removed patch 4 (update to the MAINTAINERS file), as this is done
now in patch 1
- Addressed comments from Joe Perches, Kim Phillips, Alex Graf
and Scott Wood. Details in each patch.

Issues pending resolution not addressed by v2:
- What to do with Doxygen comments in patch 1
- Whether to move or not FSL-specific header files added in include/linux,
by this patch series, to another location
- Whether to change or not the wording of the licenses used in some
source files
- Checkpatch warnings:
* WARNING: DT compatible string "fsl,qoriq-mc" appears un-documented
This warning will go away once the prerequisite patch series is
accepted upstream.
* WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
This warning still happens even after adding MAINTAINERS file entries in
the same patch where new files were added
- Sparse warning:
* drivers/bus/fsl-mc/fsl_mc_sys.c:193:9: warning: context imbalance in 'mc_send_command' - different lock contexts for basic block
This warning is caused by conditionally acquiring/releasing a lock in function mc_send_command().
Not clear how to solve this warning, as we need to be able to decide at
run time based on a flag whether to acquire the lock or not.

Changes in v1:
- No changes since RFC v4

Changes in RFC v4:
- Fixed parameter mismatch for device_find_child() call in fsl_mc_dprc.c
- Added back the dma_mask field to struct fsl_mc_device as it is needed
by some MC child device drivers. However, the default DMA mask now
does not have the 32-bit limitation of the original patch series (v1).

Changes in RFC v3:
Rework to address comments from Arnd Bergmann:
- Removed per-bus list of children, and instead use device_for_each_child()
- Use the same structure (struct fsl_mc_device) to represent both
bus devices and their children.
http://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg711301.html

Changes in RFC v2:
Rework to address comments from Arnd Bergmann:
- Removed fsl_mc_bus structure and global variable
- Removed the 'magic' fields from all structs
- Removed NULL initializers
- Replaced all occurrences of EXPORT_SYMBOL() with EXPORT_SYMBOL_GPL()
- Removed function dprc_parse_dt_node(), and replaced its call by a
direct call to of_address_to_resource()
- Removed struct fsl_mc_device_region and use standard 'struct resource'
instead.
- Removed dma_mask field from 'struct fsl_mc_device' as it is not currently
being used.
- Removed redundant 'driver' field from struct fsl_mc_device
- Removed the container field. We can get the parent DPRC of a given dev,
from its dev.parent field.
http://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg708858.html


2014-10-04 13:24:52

by J. German Rivera

[permalink] [raw]
Subject: [PATCH 1/3 v3] drivers/bus: Added Freescale Management Complex APIs

From: "J. German Rivera" <[email protected]>

APIs to access the Management Complex (MC) hardware
module of Freescale LS2 SoCs. This patch includes
APIs to check the MC firmware version and to manipulate
DPRC objects in the MC.

Signed-off-by: J. German Rivera <[email protected]>
Signed-off-by: Stuart Yoder <[email protected]>
---
Changes in v3:
- Addressed comment from Greg Kroah-Hartman:
* Removed doxygen comments

- Addressed comment from Scott Wood:
* Replaced udelay() call with usleep_range() call in polling loop
- Addressed comments from Kim Phillips:
* Fixed license text in all files
* Renamed files:
drivers/bus/fsl-mc/fsl_dpmng_cmd.h -> drivers/bus/fsl-mc/dpmng-cmd.h
drivers/bus/fsl-mc/fsl_dprc_cmd.h -> drivers/bus/fsl-mc/dprc-cmd.h
drivers/bus/fsl-mc/fsl_mc_sys.c -> drivers/bus/fsl-mc/mc-sys.c
include/linux/fsl_dpmng.h -> include/linux/fsl/dpmng.h
include/linux/fsl_dprc.h -> include/linux/fsl/dprc.h
include/linux/fsl_mc_cmd.h -> include/linux/fsl/mc-cmd.h
include/linux/fsl_mc_sys.h -> include/linux/fsl/mc-sys.h
* Changed dpmng_load_iop() to take the DMA address directly,
instead of the image virtual address.
* Removed if and WARN_ON that checks for NULL fsl_destroy_mc_io()
* Removed locking from mc_send_command(). Now the caller of MC flib
APIs is responsible for protecting concurrent accesses to the same
MC portal.

Changes in v2:
- Addressed comment from Joe Perches:
* Refactored logic to actively fail on err and proceed at
the same indent level on success, for all functions in dprc.c
and dpmng.c.

- Addressed comments from Kim Phillips:
* Fixed warning in mc_send_command
* Changed serialization logic in mc_send_command() to only use
spinlock_irqsave() when both threads and interrupt handlers
concurrently access the same portal.
* Changed switch to lookup table in mc_status_to_error()
* Removed macros iowrite64(), ioread64(), ENOTSUP from fsl_mc_sys.h
* Removed #ifdef side for FSL_MC_FIRMWARE in fsl_mc_cmd.h
* Changed non-devm_ API calls to devm_ API calls and refactored
fsl_create_mc_io()/fsl_destroy_mc_io() to simplify cleanup logic.

- Addressed comments from Scott Wood:
* Return -ENXIO instead of -EFAULT when ioremap_nocache() fails

- Addressed comments from Alex Graf:
* Added MAINTAINERS file entries for new files
* Added dev param to fsl_create_mc_io(), to enable the use
of devm_ APIs in this function and fsl_destroy_mc_io().
* Changed the value of the timeout for MC command completion
to be a function of HZ instead of a hard-coded jiffies value.

MAINTAINERS | 8 +
drivers/bus/fsl-mc/dpmng-cmd.h | 83 +++++
drivers/bus/fsl-mc/dpmng.c | 94 +++++
drivers/bus/fsl-mc/dprc-cmd.h | 545 +++++++++++++++++++++++++++
drivers/bus/fsl-mc/dprc.c | 521 ++++++++++++++++++++++++++
drivers/bus/fsl-mc/mc-sys.c | 189 ++++++++++
include/linux/fsl/dpmng.h | 121 ++++++
include/linux/fsl/dprc.h | 791 ++++++++++++++++++++++++++++++++++++++++
include/linux/fsl/mc-cmd.h | 169 +++++++++
include/linux/fsl/mc-sys.h | 68 ++++
10 files changed, 2589 insertions(+)
create mode 100644 drivers/bus/fsl-mc/dpmng-cmd.h
create mode 100644 drivers/bus/fsl-mc/dpmng.c
create mode 100644 drivers/bus/fsl-mc/dprc-cmd.h
create mode 100644 drivers/bus/fsl-mc/dprc.c
create mode 100644 drivers/bus/fsl-mc/mc-sys.c
create mode 100644 include/linux/fsl/dpmng.h
create mode 100644 include/linux/fsl/dprc.h
create mode 100644 include/linux/fsl/mc-cmd.h
create mode 100644 include/linux/fsl/mc-sys.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 8fd05d4..907b50d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3874,6 +3874,14 @@ F: sound/soc/fsl/fsl*
F: sound/soc/fsl/imx*
F: sound/soc/fsl/mpc8610_hpcd.c

+FREESCALE QORIQ MANAGEMENT COMPLEX DRIVER
+M: J. German Rivera <[email protected]>
+L: [email protected]
+S: Maintained
+F: include/linux/fsl_mc*
+F: include/linux/fsl_dp*
+F: drivers/bus/fsl-mc/*
+
FREEVXFS FILESYSTEM
M: Christoph Hellwig <[email protected]>
W: ftp://ftp.openlinux.org/pub/people/hch/vxfs
diff --git a/drivers/bus/fsl-mc/dpmng-cmd.h b/drivers/bus/fsl-mc/dpmng-cmd.h
new file mode 100644
index 0000000..cdeaa16
--- /dev/null
+++ b/drivers/bus/fsl-mc/dpmng-cmd.h
@@ -0,0 +1,83 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/*************************************************************************//*
+ dpmng-cmd.h
+
+ defines portal commands
+
+ *//**************************************************************************/
+
+#ifndef __FSL_DPMNG_CMD_H
+#define __FSL_DPMNG_CMD_H
+
+/* Command IDs */
+#define DPMNG_CMDID_GET_VERSION 0x831
+#define DPMNG_CMDID_RESET_AIOP 0x832
+#define DPMNG_CMDID_LOAD_AIOP 0x833
+#define DPMNG_CMDID_RUN_AIOP 0x834
+
+/* Command sizes */
+#define DPMNG_CMDSZ_GET_VERSION (8 * 2)
+#define DPMNG_CMDSZ_RESET_AIOP 8
+#define DPMNG_CMDSZ_LOAD_AIOP (8 * 2)
+#define DPMNG_CMDSZ_RUN_AIOP (8 * 2)
+
+/* param, offset, width, type, arg_name */
+#define DPMNG_RSP_GET_VERSION(cmd, mc_ver_info) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, mc_ver_info->revision);\
+ MC_RSP_PARAM_OP(cmd, 0, 32, 32, uint32_t, mc_ver_info->major); \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 8, uint32_t, mc_ver_info->minor); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPMNG_CMD_RESET_AIOP(cmd, aiop_tile_id) \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, aiop_tile_id)
+
+/* param, offset, width, type, arg_name */
+#define DPMNG_CMD_LOAD_AIOP(cmd, aiop_tile_id, img_size, img_paddr) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, aiop_tile_id); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 32, int, img_size); \
+ MC_CMD_PARAM_OP(cmd, 1, 0, 64, uint64_t, img_paddr); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPMNG_CMD_RUN_AIOP(cmd, aiop_tile_id, cores_mask, options) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, aiop_tile_id); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 32, uint32_t, cores_mask); \
+ MC_CMD_PARAM_OP(cmd, 1, 0, 64, uint64_t, options); \
+} while (0)
+
+#endif /* __FSL_DPMNG_CMD_H */
diff --git a/drivers/bus/fsl-mc/dpmng.c b/drivers/bus/fsl-mc/dpmng.c
new file mode 100644
index 0000000..8a32448
--- /dev/null
+++ b/drivers/bus/fsl-mc/dpmng.c
@@ -0,0 +1,94 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <linux/fsl/mc-sys.h>
+#include <linux/fsl/mc-cmd.h>
+#include <linux/fsl/dpmng.h>
+#include "dpmng-cmd.h"
+
+int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPMNG_CMDID_GET_VERSION,
+ DPMNG_CMDSZ_GET_VERSION,
+ MC_CMD_PRI_LOW, 0);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPMNG_RSP_GET_VERSION(cmd, mc_ver_info);
+ return 0;
+}
+
+int dpmng_reset_aiop(struct fsl_mc_io *mc_io, int aiop_tile_id)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPMNG_CMDID_RESET_AIOP,
+ DPMNG_CMDSZ_RESET_AIOP,
+ MC_CMD_PRI_LOW, 0);
+
+ DPMNG_CMD_RESET_AIOP(cmd, aiop_tile_id);
+
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dpmng_load_aiop(struct fsl_mc_io *mc_io,
+ int aiop_tile_id, dma_addr_t img_dma_addr, int img_size)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPMNG_CMDID_LOAD_AIOP,
+ DPMNG_CMDSZ_LOAD_AIOP,
+ MC_CMD_PRI_LOW, 0);
+
+ DPMNG_CMD_LOAD_AIOP(cmd, aiop_tile_id, img_size, img_dma_addr);
+
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dpmng_run_aiop(struct fsl_mc_io *mc_io,
+ int aiop_tile_id, uint32_t cores_mask, uint64_t options)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPMNG_CMDID_RUN_AIOP,
+ DPMNG_CMDSZ_RUN_AIOP,
+ MC_CMD_PRI_LOW, 0);
+
+ DPMNG_CMD_RUN_AIOP(cmd, aiop_tile_id, cores_mask, options);
+
+ return mc_send_command(mc_io, &cmd);
+}
diff --git a/drivers/bus/fsl-mc/dprc-cmd.h b/drivers/bus/fsl-mc/dprc-cmd.h
new file mode 100644
index 0000000..0ce3ada
--- /dev/null
+++ b/drivers/bus/fsl-mc/dprc-cmd.h
@@ -0,0 +1,545 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/*************************************************************************//*
+ dprc-cmd.h
+
+ defines dprc portal commands
+
+ *//**************************************************************************/
+
+#ifndef _FSL_DPRC_CMD_H
+#define _FSL_DPRC_CMD_H
+
+/* DPRC Version */
+#define DPRC_VER_MAJOR 1
+#define DPRC_VER_MINOR 0
+
+/* Command IDs */
+#define MC_CMDID_CLOSE 0x800
+#define MC_DPRC_CMDID_OPEN 0x805
+#define MC_DPRC_CMDID_CREATE 0x905
+
+#define DPRC_CMDID_CREATE_CONT 0x151
+#define DPRC_CMDID_DESTROY_CONT 0x152
+#define DPRC_CMDID_GET_CONT_ID 0x830
+#define DPRC_CMDID_RESET_CONT 0x154
+#define DPRC_CMDID_SET_RES_QUOTA 0x155
+#define DPRC_CMDID_GET_RES_QUOTA 0x156
+#define DPRC_CMDID_ASSIGN 0x157
+#define DPRC_CMDID_UNASSIGN 0x158
+#define DPRC_CMDID_GET_OBJ_COUNT 0x159
+#define DPRC_CMDID_GET_OBJECT 0x15A
+#define DPRC_CMDID_GET_RES_COUNT 0x15B
+#define DPRC_CMDID_GET_RES_IDS 0x15C
+#define DPRC_CMDID_GET_ATTR 0x15D
+#define DPRC_CMDID_GET_OBJ_REG 0x15E
+#define DPRC_CMDID_SET_IRQ 0x15F
+#define DPRC_CMDID_GET_IRQ 0x160
+#define DPRC_CMDID_SET_IRQ_ENABLE 0x161
+#define DPRC_CMDID_GET_IRQ_ENABLE 0x162
+#define DPRC_CMDID_SET_IRQ_MASK 0x163
+#define DPRC_CMDID_GET_IRQ_MASK 0x164
+#define DPRC_CMDID_GET_IRQ_STATUS 0x165
+#define DPRC_CMDID_CLEAR_IRQ_STATUS 0x166
+#define DPRC_CMDID_CONNECT 0x167
+#define DPRC_CMDID_DISCONNECT 0x168
+#define DPRC_CMDID_GET_POOL 0x169
+#define DPRC_CMDID_GET_POOL_COUNT 0x16A
+#define DPRC_CMDID_GET_PORTAL_PADDR 0x16B
+
+/* Command sizes */
+#define MC_CMD_OPEN_SIZE 8
+#define MC_CMD_CLOSE_SIZE 0
+#define DPRC_CMDSZ_CREATE_CONT (8 * 2)
+#define DPRC_CMDSZ_DESTROY_CONT 8
+#define DPRC_CMDSZ_GET_CONT_ID 8
+#define DPRC_CMDSZ_RESET_CONT 8
+#define DPRC_CMDSZ_SET_RES_QUOTA (8 * 3)
+#define DPRC_CMDSZ_GET_RES_QUOTA (8 * 3)
+#define DPRC_CMDSZ_ASSIGN (8 * 4)
+#define DPRC_CMDSZ_UNASSIGN (8 * 4)
+#define DPRC_CMDSZ_GET_OBJ_COUNT 0
+#define DPRC_CMDSZ_GET_OBJECT (8 * 5)
+#define DPRC_CMDSZ_GET_RES_COUNT 8
+#define DPRC_CMDSZ_GET_RES_IDS (8 * 4)
+#define DPRC_CMDSZ_GET_ATTR (8 * 3)
+#define DPRC_CMDSZ_GET_OBJ_REG (8 * 5)
+#define DPRC_CMDSZ_SET_IRQ (8 * 3)
+#define DPRC_CMDSZ_GET_IRQ (8 * 3)
+#define DPRC_CMDSZ_SET_IRQ_ENABLE 8
+#define DPRC_CMDSZ_GET_IRQ_ENABLE 8
+#define DPRC_CMDSZ_SET_IRQ_MASK 8
+#define DPRC_CMDSZ_GET_IRQ_MASK 8
+#define DPRC_CMDSZ_GET_IRQ_STATUS 8
+#define DPRC_CMDSZ_CLEAR_IRQ_STATUS 8
+#define DPRC_CMDSZ_CONNECT (8 * 7)
+#define DPRC_CMDSZ_DISCONNECT (8 * 3)
+#define DPRC_CMDSZ_GET_POOL (8 * 3)
+#define DPRC_CMDSZ_GET_POOL_COUNT 8
+#define DPRC_CMDSZ_GET_PORTAL_PADDR (8 * 2)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_OPEN(cmd, container_id) \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, container_id)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_CONTAINER_ID(cmd, container_id) \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, container_id)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_CREATE_CONTAINER(cmd, cfg) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 16, uint16_t, cfg->icid); \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, cfg->options); \
+ MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, cfg->portal_id); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_CREATE_CONTAINER(cmd, child_container_id, child_portal_paddr) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 32, int, child_container_id); \
+ MC_RSP_PARAM_OP(cmd, 2, 0, 64, uint64_t, child_portal_paddr); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_DESTROY_CONTAINER(cmd, child_container_id) \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_RESET_CONTAINER(cmd, child_container_id) \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_SET_RES_QUOTA(cmd, child_container_id, type, quota) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 16, uint16_t, quota);\
+ MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
+ MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
+ MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
+ MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
+ MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
+ MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
+ MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
+ MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_RES_QUOTA(cmd, child_container_id, type) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id); \
+ MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
+ MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
+ MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
+ MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
+ MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
+ MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
+ MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
+ MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_RES_QUOTA(cmd, quota) \
+ MC_RSP_PARAM_OP(cmd, 0, 32, 16, uint16_t, quota)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_ASSIGN(cmd, container_id, res_req) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, container_id); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 32, uint32_t, res_req->options);\
+ MC_CMD_PARAM_OP(cmd, 1, 0, 32, uint32_t, res_req->num); \
+ MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, res_req->id_base_align); \
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, res_req->type[0]);\
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, res_req->type[1]);\
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, res_req->type[2]);\
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, res_req->type[3]);\
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, res_req->type[4]);\
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, res_req->type[5]);\
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, res_req->type[6]);\
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, res_req->type[7]);\
+ MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, res_req->type[8]);\
+ MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, res_req->type[9]);\
+ MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, res_req->type[10]);\
+ MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, res_req->type[11]);\
+ MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, res_req->type[12]);\
+ MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, res_req->type[13]);\
+ MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, res_req->type[14]);\
+ MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, res_req->type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_UNASSIGN(cmd, child_container_id, res_req) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 32, uint32_t, res_req->options);\
+ MC_CMD_PARAM_OP(cmd, 1, 0, 32, uint32_t, res_req->num); \
+ MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, res_req->id_base_align); \
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, res_req->type[0]);\
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, res_req->type[1]);\
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, res_req->type[2]);\
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, res_req->type[3]);\
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, res_req->type[4]);\
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, res_req->type[5]);\
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, res_req->type[6]);\
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, res_req->type[7]);\
+ MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, res_req->type[8]);\
+ MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, res_req->type[9]);\
+ MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, res_req->type[10]);\
+ MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, res_req->type[11]);\
+ MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, res_req->type[12]);\
+ MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, res_req->type[13]);\
+ MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, res_req->type[14]);\
+ MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, res_req->type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_OBJ_COUNT(cmd, obj_count) \
+ MC_RSP_PARAM_OP(cmd, 0, 32, 32, int, obj_count)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_OBJECT(cmd, obj_index) \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, obj_index)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_OBJECT(cmd, obj_desc) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 0, 32, 32, int, obj_desc->id); \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 16, uint16_t, obj_desc->vendor); \
+ MC_RSP_PARAM_OP(cmd, 1, 16, 8, uint8_t, obj_desc->irq_count); \
+ MC_RSP_PARAM_OP(cmd, 1, 24, 8, uint8_t, obj_desc->region_count); \
+ MC_RSP_PARAM_OP(cmd, 1, 32, 32, uint32_t, obj_desc->state);\
+ MC_RSP_PARAM_OP(cmd, 2, 0, 32, uint32_t, obj_desc->ver_minor); \
+ MC_RSP_PARAM_OP(cmd, 2, 32, 32, uint32_t, obj_desc->ver_major); \
+ MC_RSP_PARAM_OP(cmd, 3, 0, 8, char, obj_desc->type[0]);\
+ MC_RSP_PARAM_OP(cmd, 3, 8, 8, char, obj_desc->type[1]);\
+ MC_RSP_PARAM_OP(cmd, 3, 16, 8, char, obj_desc->type[2]);\
+ MC_RSP_PARAM_OP(cmd, 3, 24, 8, char, obj_desc->type[3]);\
+ MC_RSP_PARAM_OP(cmd, 3, 32, 8, char, obj_desc->type[4]);\
+ MC_RSP_PARAM_OP(cmd, 3, 40, 8, char, obj_desc->type[5]);\
+ MC_RSP_PARAM_OP(cmd, 3, 48, 8, char, obj_desc->type[6]);\
+ MC_RSP_PARAM_OP(cmd, 3, 56, 8, char, obj_desc->type[7]);\
+ MC_RSP_PARAM_OP(cmd, 4, 0, 8, char, obj_desc->type[8]);\
+ MC_RSP_PARAM_OP(cmd, 4, 8, 8, char, obj_desc->type[9]);\
+ MC_RSP_PARAM_OP(cmd, 4, 16, 8, char, obj_desc->type[10]);\
+ MC_RSP_PARAM_OP(cmd, 4, 24, 8, char, obj_desc->type[11]);\
+ MC_RSP_PARAM_OP(cmd, 4, 32, 8, char, obj_desc->type[12]);\
+ MC_RSP_PARAM_OP(cmd, 4, 40, 8, char, obj_desc->type[13]);\
+ MC_RSP_PARAM_OP(cmd, 4, 48, 8, char, obj_desc->type[14]);\
+ MC_RSP_PARAM_OP(cmd, 4, 56, 8, char, obj_desc->type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_RES_COUNT(cmd, type) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
+ MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
+ MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
+ MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
+ MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
+ MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
+ MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
+ MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_RES_COUNT(cmd, res_count) \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, res_count)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_RES_IDS(cmd, type, range_desc) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 42, 7, enum dprc_iter_status, \
+ range_desc->iter_status);\
+ MC_CMD_PARAM_OP(cmd, 1, 0, 32, int, range_desc->base_id); \
+ MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, range_desc->last_id);\
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[0]);\
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[1]);\
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[2]);\
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[3]);\
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[4]);\
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[5]);\
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[6]);\
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[7]);\
+ MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, type[8]);\
+ MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, type[9]);\
+ MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, type[10]);\
+ MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, type[11]);\
+ MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, type[12]);\
+ MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, type[13]);\
+ MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, type[14]);\
+ MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_RES_IDS(cmd, range_desc) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 0, 42, 7, enum dprc_iter_status, \
+ range_desc->iter_status);\
+ MC_RSP_PARAM_OP(cmd, 1, 0, 32, int, range_desc->base_id); \
+ MC_RSP_PARAM_OP(cmd, 1, 32, 32, int, range_desc->last_id);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_ATTRIBUTES(cmd, attr) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, attr->container_id); \
+ MC_RSP_PARAM_OP(cmd, 0, 32, 16, uint16_t, attr->icid); \
+ MC_RSP_PARAM_OP(cmd, 0, 48, 16, uint16_t, attr->portal_id); \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 32, uint32_t, attr->options);\
+ MC_RSP_PARAM_OP(cmd, 2, 0, 32, uint32_t, attr->version.major);\
+ MC_RSP_PARAM_OP(cmd, 2, 32, 32, uint32_t, attr->version.minor);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_OBJ_REGION(cmd, obj_id, region_index, obj_type) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, obj_id); \
+ MC_CMD_PARAM_OP(cmd, 0, 48, 8, uint8_t, region_index);\
+ MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, obj_type[0]);\
+ MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, obj_type[1]);\
+ MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, obj_type[2]);\
+ MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, obj_type[3]);\
+ MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, obj_type[4]);\
+ MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, obj_type[5]);\
+ MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, obj_type[6]);\
+ MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, obj_type[7]);\
+ MC_CMD_PARAM_OP(cmd, 4, 0, 8, char, obj_type[8]);\
+ MC_CMD_PARAM_OP(cmd, 4, 8, 8, char, obj_type[9]);\
+ MC_CMD_PARAM_OP(cmd, 4, 16, 8, char, obj_type[10]);\
+ MC_CMD_PARAM_OP(cmd, 4, 24, 8, char, obj_type[11]);\
+ MC_CMD_PARAM_OP(cmd, 4, 32, 8, char, obj_type[12]);\
+ MC_CMD_PARAM_OP(cmd, 4, 40, 8, char, obj_type[13]);\
+ MC_CMD_PARAM_OP(cmd, 4, 48, 8, char, obj_type[14]);\
+ MC_CMD_PARAM_OP(cmd, 4, 56, 8, char, obj_type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_OBJ_REGION(cmd, region_desc) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 64, uint64_t, region_desc->base_paddr);\
+ MC_RSP_PARAM_OP(cmd, 2, 0, 32, uint32_t, region_desc->size); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_SET_IRQ(cmd, irq_index, irq_val, irq_paddr, user_irq_id) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index); \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, irq_val); \
+ MC_CMD_PARAM_OP(cmd, 1, 0, 64, uint64_t, irq_paddr);\
+ MC_CMD_PARAM_OP(cmd, 2, 0, 32, int, user_irq_id); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_IRQ(cmd, irq_index) \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_IRQ(cmd, irq_val, irq_paddr, user_irq_id, type) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, irq_val); \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 64, uint64_t, irq_paddr);\
+ MC_RSP_PARAM_OP(cmd, 2, 0, 32, int, user_irq_id); \
+ MC_RSP_PARAM_OP(cmd, 2, 32, 32, int, type); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_SET_IRQ_ENABLE(cmd, enable_state, irq_index) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 8, uint8_t, enable_state); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_IRQ_ENABLE(cmd, irq_index) \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_IRQ_ENABLE(cmd, enable_state) \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 8, uint8_t, enable_state)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_SET_IRQ_MASK(cmd, mask, irq_index) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, mask); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_IRQ_MASK(cmd, irq_index) \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_IRQ_MASK(cmd, mask) \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, mask)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_IRQ_STATUS(cmd, irq_index) \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_IRQ_STATUS(cmd, status) \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, status)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_CLEAR_IRQ_STATUS(cmd, status, irq_index) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, status); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_CONNECT(cmd, endpoint1, endpoint2) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, endpoint1->id); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 32, int, endpoint1->interface_id); \
+ MC_CMD_PARAM_OP(cmd, 1, 0, 32, int, endpoint2->id); \
+ MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, endpoint2->interface_id); \
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, endpoint1->type[0]); \
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, endpoint1->type[1]); \
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, endpoint1->type[2]); \
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, endpoint1->type[3]); \
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, endpoint1->type[4]); \
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, endpoint1->type[5]); \
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, endpoint1->type[6]); \
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, endpoint1->type[7]); \
+ MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, endpoint1->type[8]); \
+ MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, endpoint1->type[9]); \
+ MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, endpoint1->type[10]); \
+ MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, endpoint1->type[11]); \
+ MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, endpoint1->type[12]); \
+ MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, endpoint1->type[13]); \
+ MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, endpoint1->type[14]); \
+ MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, endpoint1->type[15]); \
+ MC_CMD_PARAM_OP(cmd, 5, 0, 8, char, endpoint2->type[0]); \
+ MC_CMD_PARAM_OP(cmd, 5, 8, 8, char, endpoint2->type[1]); \
+ MC_CMD_PARAM_OP(cmd, 5, 16, 8, char, endpoint2->type[2]); \
+ MC_CMD_PARAM_OP(cmd, 5, 24, 8, char, endpoint2->type[3]); \
+ MC_CMD_PARAM_OP(cmd, 5, 32, 8, char, endpoint2->type[4]); \
+ MC_CMD_PARAM_OP(cmd, 5, 40, 8, char, endpoint2->type[5]); \
+ MC_CMD_PARAM_OP(cmd, 5, 48, 8, char, endpoint2->type[6]); \
+ MC_CMD_PARAM_OP(cmd, 5, 56, 8, char, endpoint2->type[7]); \
+ MC_CMD_PARAM_OP(cmd, 6, 0, 8, char, endpoint2->type[8]); \
+ MC_CMD_PARAM_OP(cmd, 6, 8, 8, char, endpoint2->type[9]); \
+ MC_CMD_PARAM_OP(cmd, 6, 16, 8, char, endpoint2->type[10]); \
+ MC_CMD_PARAM_OP(cmd, 6, 24, 8, char, endpoint2->type[11]); \
+ MC_CMD_PARAM_OP(cmd, 6, 32, 8, char, endpoint2->type[12]); \
+ MC_CMD_PARAM_OP(cmd, 6, 40, 8, char, endpoint2->type[13]); \
+ MC_CMD_PARAM_OP(cmd, 6, 48, 8, char, endpoint2->type[14]); \
+ MC_CMD_PARAM_OP(cmd, 6, 56, 8, char, endpoint2->type[15]); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_DISCONNECT(cmd, endpoint) \
+do { \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, endpoint->id); \
+ MC_CMD_PARAM_OP(cmd, 0, 32, 32, int, endpoint->interface_id); \
+ MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, endpoint->type[0]); \
+ MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, endpoint->type[1]); \
+ MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, endpoint->type[2]); \
+ MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, endpoint->type[3]); \
+ MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, endpoint->type[4]); \
+ MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, endpoint->type[5]); \
+ MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, endpoint->type[6]); \
+ MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, endpoint->type[7]); \
+ MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, endpoint->type[8]); \
+ MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, endpoint->type[9]); \
+ MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, endpoint->type[10]); \
+ MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, endpoint->type[11]); \
+ MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, endpoint->type[12]); \
+ MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, endpoint->type[13]); \
+ MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, endpoint->type[14]); \
+ MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, endpoint->type[15]); \
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_POOL(cmd, pool_index) \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, pool_index)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_POOL(cmd, type) \
+do { \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
+ MC_RSP_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
+ MC_RSP_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
+ MC_RSP_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
+ MC_RSP_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
+ MC_RSP_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
+ MC_RSP_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
+ MC_RSP_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
+ MC_RSP_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
+ MC_RSP_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
+ MC_RSP_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
+ MC_RSP_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
+ MC_RSP_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
+ MC_RSP_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
+ MC_RSP_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
+ MC_RSP_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
+} while (0)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_POOL_COUNT(cmd, pool_count) \
+ MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, pool_count)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_CMD_GET_PORTAL_PADDR(cmd, portal_id) \
+ MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, portal_id)
+
+/* param, offset, width, type, arg_name */
+#define DPRC_RSP_GET_PORTAL_PADDR(cmd, portal_addr) \
+ MC_RSP_PARAM_OP(cmd, 1, 0, 64, uint64_t, portal_addr)
+
+#endif /* _FSL_DPRC_CMD_H */
diff --git a/drivers/bus/fsl-mc/dprc.c b/drivers/bus/fsl-mc/dprc.c
new file mode 100644
index 0000000..77315fe
--- /dev/null
+++ b/drivers/bus/fsl-mc/dprc.c
@@ -0,0 +1,521 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <linux/fsl/mc-sys.h>
+#include <linux/fsl/mc-cmd.h>
+#include <linux/fsl/dprc.h>
+#include "dprc-cmd.h"
+
+int dprc_get_container_id(struct fsl_mc_io *mc_io, int *container_id)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_CONT_ID,
+ DPRC_CMDSZ_GET_CONT_ID,
+ MC_CMD_PRI_LOW, 0);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_CONTAINER_ID(cmd, *container_id);
+ return 0;
+}
+
+int dprc_open(struct fsl_mc_io *mc_io, int container_id, uint16_t *dprc_handle)
+{
+ int err;
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(MC_DPRC_CMDID_OPEN,
+ MC_CMD_OPEN_SIZE, MC_CMD_PRI_LOW, 0);
+
+ DPRC_CMD_OPEN(cmd, container_id);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ *dprc_handle = MC_CMD_HDR_READ_AUTHID(cmd.header);
+ return 0;
+}
+
+int dprc_close(struct fsl_mc_io *mc_io, uint16_t dprc_handle)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(MC_CMDID_CLOSE,
+ MC_CMD_CLOSE_SIZE,
+ MC_CMD_PRI_HIGH, dprc_handle);
+
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_create_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_cfg *cfg,
+ int *child_container_id,
+ uint64_t *child_portal_paddr)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_CREATE_CONT,
+ DPRC_CMDSZ_CREATE_CONT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_CREATE_CONTAINER(cmd, cfg);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_CREATE_CONTAINER(cmd, *child_container_id,
+ *child_portal_paddr);
+
+ return 0;
+}
+
+int dprc_destroy_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_DESTROY_CONT,
+ DPRC_CMDSZ_DESTROY_CONT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_DESTROY_CONTAINER(cmd, child_container_id);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_reset_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_RESET_CONT,
+ DPRC_CMDSZ_RESET_CONT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_RESET_CONTAINER(cmd, child_container_id);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_set_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id, char *type, uint16_t quota)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_RES_QUOTA,
+ DPRC_CMDSZ_SET_RES_QUOTA,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_SET_RES_QUOTA(cmd, child_container_id, type, quota);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_get_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id, char *type, uint16_t *quota)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_RES_QUOTA,
+ DPRC_CMDSZ_GET_RES_QUOTA,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_RES_QUOTA(cmd, child_container_id, type);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_RES_QUOTA(cmd, *quota);
+ return 0;
+}
+
+int dprc_assign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int container_id, struct dprc_res_req *res_req)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_ASSIGN,
+ DPRC_CMDSZ_ASSIGN,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_ASSIGN(cmd, container_id, res_req);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_unassign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id, struct dprc_res_req *res_req)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_UNASSIGN,
+ DPRC_CMDSZ_UNASSIGN,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_UNASSIGN(cmd, child_container_id, res_req);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_get_obj_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int *obj_count)
+{
+ int err;
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_OBJ_COUNT,
+ DPRC_CMDSZ_GET_OBJ_COUNT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_OBJ_COUNT(cmd, *obj_count);
+ return 0;
+}
+
+int dprc_get_obj(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int obj_index, struct dprc_obj_desc *obj_desc)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_OBJECT,
+ DPRC_CMDSZ_GET_OBJECT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_OBJECT(cmd, obj_index);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_OBJECT(cmd, obj_desc);
+ return 0;
+}
+
+int dprc_get_res_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ char *type, int *res_count)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ *res_count = 0;
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_RES_COUNT,
+ DPRC_CMDSZ_GET_RES_COUNT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_RES_COUNT(cmd, type);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_RES_COUNT(cmd, *res_count);
+ return 0;
+}
+
+int dprc_get_res_ids(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ char *type, struct dprc_res_ids_range_desc *range_desc)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_RES_IDS,
+ DPRC_CMDSZ_GET_RES_IDS,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_RES_IDS(cmd, type, range_desc);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_RES_IDS(cmd, range_desc);
+ return 0;
+}
+
+int dprc_get_attributes(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_attributes *attr)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_ATTR,
+ DPRC_CMDSZ_GET_ATTR,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_ATTRIBUTES(cmd, attr);
+ return 0;
+}
+
+int dprc_get_obj_region(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ char *obj_type,
+ int obj_id,
+ uint8_t region_index,
+ struct dprc_region_desc *region_desc)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_OBJ_REG,
+ DPRC_CMDSZ_GET_OBJ_REG,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_OBJ_REGION(cmd, obj_id, region_index, obj_type);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_OBJ_REGION(cmd, region_desc);
+ return 0;
+}
+
+int dprc_get_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index,
+ int *type,
+ uint64_t *irq_paddr, uint32_t *irq_val, int *user_irq_id)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ,
+ DPRC_CMDSZ_GET_IRQ,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_IRQ(cmd, irq_index);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_IRQ(cmd, *irq_val, *irq_paddr, *user_irq_id, *type);
+ return 0;
+}
+
+int dprc_set_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index,
+ uint64_t irq_paddr, uint32_t irq_val, int user_irq_id)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_IRQ,
+ DPRC_CMDSZ_SET_IRQ,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_SET_IRQ(cmd, irq_index, irq_val, irq_paddr, user_irq_id);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_get_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint8_t *enable_state)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ_ENABLE,
+ DPRC_CMDSZ_GET_IRQ_ENABLE,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_IRQ_ENABLE(cmd, irq_index);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_IRQ_ENABLE(cmd, *enable_state);
+ return 0;
+}
+
+int dprc_set_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint8_t enable_state)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_IRQ_ENABLE,
+ DPRC_CMDSZ_SET_IRQ_ENABLE,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_SET_IRQ_ENABLE(cmd, enable_state, irq_index);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_get_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t *mask)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ_MASK,
+ DPRC_CMDSZ_GET_IRQ_MASK,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_IRQ_MASK(cmd, irq_index);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_IRQ_MASK(cmd, *mask);
+ return 0;
+}
+
+int dprc_set_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t mask)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_IRQ_MASK,
+ DPRC_CMDSZ_SET_IRQ_MASK,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_SET_IRQ_MASK(cmd, mask, irq_index);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_get_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t *status)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ_STATUS,
+ DPRC_CMDSZ_GET_IRQ_STATUS,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_IRQ_STATUS(cmd, irq_index);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_IRQ_STATUS(cmd, *status);
+ return 0;
+}
+
+int dprc_clear_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t status)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_CLEAR_IRQ_STATUS,
+ DPRC_CMDSZ_CLEAR_IRQ_STATUS,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_CLEAR_IRQ_STATUS(cmd, status, irq_index);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_get_pool_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int *pool_count)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_POOL_COUNT,
+ DPRC_CMDSZ_GET_POOL_COUNT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_POOL_COUNT(cmd, *pool_count);
+ return 0;
+}
+
+int dprc_get_pool(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int pool_index, char *type)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_POOL,
+ DPRC_CMDSZ_GET_POOL,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_POOL(cmd, pool_index);
+
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_POOL(cmd, type);
+ return 0;
+}
+
+int dprc_get_portal_paddr(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int portal_id, uint64_t *portal_addr)
+{
+ struct mc_command cmd = { 0 };
+ int err;
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_PORTAL_PADDR,
+ DPRC_CMDSZ_GET_PORTAL_PADDR,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_GET_PORTAL_PADDR(cmd, portal_id);
+ err = mc_send_command(mc_io, &cmd);
+ if (err)
+ return err;
+
+ DPRC_RSP_GET_PORTAL_PADDR(cmd, *portal_addr);
+ return 0;
+}
+
+int dprc_connect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_endpoint *endpoint1,
+ struct dprc_endpoint *endpoint2)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_CONNECT,
+ DPRC_CMDSZ_CONNECT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_CONNECT(cmd, endpoint1, endpoint2);
+ return mc_send_command(mc_io, &cmd);
+}
+
+int dprc_disconnect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_endpoint *endpoint)
+{
+ struct mc_command cmd = { 0 };
+
+ cmd.header = mc_encode_cmd_header(DPRC_CMDID_DISCONNECT,
+ DPRC_CMDSZ_DISCONNECT,
+ MC_CMD_PRI_LOW, dprc_handle);
+
+ DPRC_CMD_DISCONNECT(cmd, endpoint);
+ return mc_send_command(mc_io, &cmd);
+}
diff --git a/drivers/bus/fsl-mc/mc-sys.c b/drivers/bus/fsl-mc/mc-sys.c
new file mode 100644
index 0000000..a598bbe
--- /dev/null
+++ b/drivers/bus/fsl-mc/mc-sys.c
@@ -0,0 +1,189 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <linux/fsl/mc-sys.h>
+#include <linux/fsl/mc-cmd.h>
+#include <linux/delay.h>
+#include <linux/slab.h>
+#include <linux/ioport.h>
+#include <linux/device.h>
+
+/**
+ * Timeout in jiffies to wait for the completion of an MC command
+ */
+#define MC_CMD_COMPLETION_TIMEOUT_JIFFIES (HZ / 2) /* 500 ms */
+
+/*
+ * usleep_range() min and max values used to throttle down polling
+ * iterations while waiting for MC command completion
+ */
+#define MC_CMD_COMPLETION_POLLING_MIN_SLEEP_USECS 10
+#define MC_CMD_COMPLETION_POLLING_MAX_SLEEP_USECS 500
+
+/**
+ * Creates an MC I/O object
+ *
+ * @dev: device to be associated with the MC I/O object
+ * @mc_portal_phys_addr: physical address of the MC portal to use
+ * @mc_portal_size: size in bytes of the MC portal
+ * @flags: flags for the new MC I/O object
+ * @new_mc_io: Area to return pointer to newly created MC I/O object
+ *
+ * Returns '0' on Success; Error code otherwise.
+ */
+int __must_check fsl_create_mc_io(struct device *dev,
+ phys_addr_t mc_portal_phys_addr,
+ uint32_t mc_portal_size,
+ uint32_t flags, struct fsl_mc_io **new_mc_io)
+{
+ struct fsl_mc_io *mc_io;
+ void __iomem *mc_portal_virt_addr;
+ struct resource *res;
+
+ mc_io = devm_kzalloc(dev, sizeof(*mc_io), GFP_KERNEL);
+ if (mc_io == NULL)
+ return -ENOMEM;
+
+ mc_io->dev = dev;
+ mc_io->flags = flags;
+ mc_io->portal_phys_addr = mc_portal_phys_addr;
+ mc_io->portal_size = mc_portal_size;
+ res = devm_request_mem_region(dev,
+ mc_portal_phys_addr,
+ mc_portal_size,
+ "mc_portal");
+ if (res == NULL) {
+ dev_err(dev,
+ "devm_request_mem_region failed for MC portal %#llx\n",
+ mc_portal_phys_addr);
+ return -EBUSY;
+ }
+
+ mc_portal_virt_addr = devm_ioremap_nocache(dev,
+ mc_portal_phys_addr,
+ mc_portal_size);
+ if (mc_portal_virt_addr == NULL) {
+ dev_err(dev,
+ "devm_ioremap_nocache failed for MC portal %#llx\n",
+ mc_portal_phys_addr);
+ return -ENXIO;
+ }
+
+ mc_io->portal_virt_addr = mc_portal_virt_addr;
+ *new_mc_io = mc_io;
+ return 0;
+}
+EXPORT_SYMBOL_GPL(fsl_create_mc_io);
+
+/**
+ * Destroys an MC I/O object
+ *
+ * @mc_io: MC I/O object to destroy
+ */
+void fsl_destroy_mc_io(struct fsl_mc_io *mc_io)
+{
+ devm_iounmap(mc_io->dev, mc_io->portal_virt_addr);
+ devm_release_mem_region(mc_io->dev,
+ mc_io->portal_phys_addr,
+ mc_io->portal_size);
+
+ mc_io->portal_virt_addr = NULL;
+ devm_kfree(mc_io->dev, mc_io);
+}
+EXPORT_SYMBOL_GPL(fsl_destroy_mc_io);
+
+static int mc_status_to_error(enum mc_cmd_status status)
+{
+ static const int mc_status_to_error_map[] = {
+ [MC_CMD_STATUS_OK] = 0,
+ [MC_CMD_STATUS_AUTH_ERR] = -EACCES,
+ [MC_CMD_STATUS_NO_PRIVILEGE] = -EPERM,
+ [MC_CMD_STATUS_DMA_ERR] = -EIO,
+ [MC_CMD_STATUS_CONFIG_ERR] = -ENXIO,
+ [MC_CMD_STATUS_TIMEOUT] = -ETIMEDOUT,
+ [MC_CMD_STATUS_NO_RESOURCE] = -ENAVAIL,
+ [MC_CMD_STATUS_NO_MEMORY] = -ENOMEM,
+ [MC_CMD_STATUS_BUSY] = -EBUSY,
+ [MC_CMD_STATUS_UNSUPPORTED_OP] = -ENOTSUPP,
+ [MC_CMD_STATUS_INVALID_STATE] = -ENODEV,
+ };
+
+ if (WARN_ON(status >= ARRAY_SIZE(mc_status_to_error_map)))
+ return -EINVAL;
+
+ return mc_status_to_error_map[status];
+}
+
+/**
+ * Sends an command to the MC device using the given MC I/O object
+ *
+ * @mc_io: MC I/O object to be used
+ * @cmd: command to be sent
+ *
+ * Returns '0' on Success; Error code otherwise.
+ *
+ * NOTE: This function cannot be invoked from from atomic contexts.
+ */
+int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd)
+{
+ enum mc_cmd_status status;
+ unsigned long irqsave_flags = 0;
+ unsigned long jiffies_until_timeout =
+ jiffies + MC_CMD_COMPLETION_TIMEOUT_JIFFIES;
+
+ /*
+ * Send command to the MC hardware:
+ */
+ mc_write_command(mc_io->portal_virt_addr, cmd);
+
+ /*
+ * Wait for response from the MC hardware:
+ */
+ for (;;) {
+ status = mc_read_response(mc_io->portal_virt_addr, cmd);
+ if (status != MC_CMD_STATUS_READY)
+ break;
+
+ /*
+ * TODO: When MC command completion interrupts are supported
+ * call wait function here instead of usleep_range()
+ */
+ usleep_range(MC_CMD_COMPLETION_POLLING_MIN_SLEEP_USECS,
+ MC_CMD_COMPLETION_POLLING_MAX_SLEEP_USECS);
+
+ if (time_after_eq(jiffies, jiffies_until_timeout))
+ return -ETIMEDOUT;
+ }
+
+ return mc_status_to_error(status);
+}
+EXPORT_SYMBOL(mc_send_command);
diff --git a/include/linux/fsl/dpmng.h b/include/linux/fsl/dpmng.h
new file mode 100644
index 0000000..3b5d81b
--- /dev/null
+++ b/include/linux/fsl/dpmng.h
@@ -0,0 +1,121 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/*
+ * dpmng.h
+ * Management Complex General API
+ */
+
+#ifndef __FSL_DPMNG_H
+#define __FSL_DPMNG_H
+
+/*
+ * grp_dpmng Management Complex General API
+ *
+ * Contains general API for the Management Complex firmware
+ *
+ */
+
+struct fsl_mc_io;
+
+/*
+ * Management Complex firmware version information
+ */
+#define MC_VER_MAJOR 2
+#define MC_VER_MINOR 0
+
+struct mc_version {
+ uint32_t major;
+ /*
+ * Major version number: incremented on API compatibility changes
+ */
+ uint32_t minor;
+ /*
+ * Minor version number: incremented on API additions (backward
+ * compatible); reset when major version is incremented.
+ */
+ uint32_t revision;
+ /*
+ * Internal revision number: incremented on implementation changes
+ * and/or bug fixes that have no impact on API
+ */
+};
+
+/*
+ * Retrieves the Management Complex firmware version information
+ *
+ * mc_io - Pointer to opaque I/O object
+ * mc_ver_info - Pointer to version information structure
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info);
+
+/*
+ * Resets an AIOP tile
+ *
+ * mc_io - Pointer to opaque I/O object
+ * aiop_tile_id - AIOP tile ID to reset
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dpmng_reset_aiop(struct fsl_mc_io *mc_io, int aiop_tile_id);
+
+/*
+ * Loads an image to AIOP tile
+ *
+ * mc_io - Pointer to opaque I/O object
+ * aiop_tile_id - AIOP tile ID
+ * img_dma_addr - DMA address (bus address) for the AIOP ELF image in memory
+ * img_size - Size in bytes of AIOP ELF image in memory
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dpmng_load_aiop(struct fsl_mc_io *mc_io,
+ int aiop_tile_id, dma_addr_t img_dma_addr, int img_size);
+
+/*
+ * Starts AIOP tile execution
+ *
+ * mc_io - Pointer to opaque I/O object
+ * aiop_tile_id - AIOP tile ID to run
+ * cores_mask - Mask of AIOP cores to run (core 0 in msb)
+ * options - Execution options (currently none defined)
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dpmng_run_aiop(struct fsl_mc_io *mc_io,
+ int aiop_tile_id, uint32_t cores_mask, uint64_t options);
+
+/* */
+
+#endif /* __FSL_DPMNG_H */
diff --git a/include/linux/fsl/dprc.h b/include/linux/fsl/dprc.h
new file mode 100644
index 0000000..02ad590
--- /dev/null
+++ b/include/linux/fsl/dprc.h
@@ -0,0 +1,791 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+/*
+ * dprc.h
+ * Data Path Resource Container API
+ */
+
+#ifndef _FSL_DPRC_H
+#define _FSL_DPRC_H
+
+/*
+ * grp_dprc Data Path Resource Container API
+ *
+ * Contains DPRC API for managing and querying LDPAA resources
+ *
+ */
+
+struct fsl_mc_io;
+
+/*
+ * Set this value as the icid value in dprc_cfg structure when creating a
+ * container, in case the ICID is not selected by the user and should be
+ * allocated by the DPRC from the pool of ICIDs.
+ */
+#define DPRC_GET_ICID_FROM_POOL (uint16_t)(~(0))
+/*
+ * Set this value as the portal_id value in dprc_cfg structure when creating a
+ * container, in case the portal id is not specifically selected by the
+ * user and should be allocated by the DPRC from the pool of portal ids.
+ */
+#define DPRC_GET_PORTAL_ID_FROM_POOL (int)(~(0))
+
+/*
+ * Resource request options
+ */
+#define DPRC_RES_REQ_OPT_EXPLICIT 0x00000001
+/* Explicit resource id request - The requested objects/resources
+ * are explicit and sequential (in case of resources).
+ * The base ID is given at res_req at base_align field */
+#define DPRC_RES_REQ_OPT_ALIGNED 0x00000002
+/* Aligned resources request - Relevant only for resources
+ * request (and not objects). Indicates that resources base id should be
+ * sequential and aligned to the value given at dprc_res_req base_align field*/
+#define DPRC_RES_REQ_OPT_PLUGGED 0x00000004
+/* Plugged Flag - Relevant only for object assignment request.
+ * Indicates that after all objects assigned. An interrupt will be invoked at
+ * the relevant GPP. The assigned object will be marked as plugged.
+ * plugged objects can't be assigned from their container */
+/* */
+
+/*
+ * Container general options
+ *
+ * These options may be selected at container creation by the container creator
+ * and can be retrieved using dprc_get_attributes()
+ */
+#define DPRC_CFG_OPT_SPAWN_ALLOWED 0x00000001
+/* Spawn Policy Option allowed - Indicates that the new container is allowed
+ * to spawn and have its own child containers. */
+#define DPRC_CFG_OPT_ALLOC_ALLOWED 0x00000002
+/* General Container allocation policy - Indicates that the new container is
+ * allowed to allocate requested resources from its parent container; if not
+ * set, the container is only allowed to use resources in its own pools; Note
+ * that this is a container's global policy, but the parent container may
+ * override it and set specific quota per resource type. */
+#define DPRC_CFG_OPT_OBJ_CREATE_ALLOWED 0x00000004
+/* Object initialization allowed - software context associated with this
+ * container is allowed to invoke object initialization operations. */
+#define DPRC_CFG_OPT_TOPOLOGY_CHANGES_ALLOWED 0x00000008
+/* Topology change allowed - software context associated with this
+ * container is allowed to invoke topology operations, such as attach/detach
+ * of network objects. */
+#define DPRC_CFG_OPT_IOMMU_BYPASS 0x00000010
+/*IOMMU bypass - indicates whether objects of this container are permitted
+ * to bypass the IOMMU. */
+#define DPRC_CFG_OPT_AIOP 0x00000020
+/*AIOP -Indicates that container belongs to aiop. */
+/* */
+
+/*
+ * Objects Attributes Flags
+ */
+#define DPRC_OBJ_STATE_OPEN 0x00000001
+/* Opened state - Indicates that an object is open by at least one owner */
+#define DPRC_OBJ_STATE_PLUGGED 0x00000002
+/* Plugged state - Indicates that the object is plugged */
+/* */
+
+/*
+ * Irq
+ */
+#define DPRC_NUM_OF_IRQS 1
+/* Number of dprc's IRQs */
+/* */
+
+/*
+ * Object irq events
+ */
+#define DPRC_IRQ_EVENT_OBJ_ASSIGNED 0x00000001
+/* Irq event - Indicates that a new object assigned to the container */
+#define DPRC_IRQ_EVENT_OBJ_UNASSIGNED 0x00000002
+/* Irq event - Indicates that an object was unassigned from the container */
+#define DPRC_IRQ_EVENT_RES_ASSIGNED 0x00000004
+/* Irq event - Indicates that resources assigned to the container */
+#define DPRC_IRQ_EVENT_RES_UNASSIGNED 0x00000008
+/* Irq event - Indicates that resources unassigned from the container */
+#define DPRC_IRQ_EVENT_CONTAINER_DESTROYED 0x00000010
+/* Irq event - Indicates that one of the descendant containers that opened by
+ * this container is destroyed */
+#define DPRC_IRQ_EVENT_OBJ_DESTROYED 0x00000011
+/* Irq event - Indicates that on one of the container's opened object is
+ destroyed */
+/* */
+
+/*
+ * Resource request descriptor, to be used in assignment or
+ * un-assignment of resources and objects.
+ */
+struct dprc_res_req {
+ char type[16];
+ /*
+ * Resource/object type: Represent as a NULL terminated string.
+ * This string may received by using dprc_get_pool() to get resource
+ * type and dprc_get_obj() to get object type.
+ * Note: it is not possible to assign/unassign DP_OBJ_DPRC objects
+ */
+ uint32_t num;
+ /* Number of resources */
+ uint32_t options;
+ /* Request options: combination of DPRC_RES_REQ_OPT_ options */
+ int id_base_align;
+ /*
+ * In case of explicit assignment (DPRC_RES_REQ_OPT_EXPLICIT is set at
+ * option), this field represents the required base ID for resource
+ * allocation;
+ * In case of aligned assignment (DPRC_RES_REQ_OPT_ALIGNED is set at
+ * option), this field indicates the required alignment for the
+ * resource ID(s) - use 0 if there is no alignment or explicit id
+ * requirements.
+ */
+};
+
+/*
+ * Object descriptor, returned from dprc_get_obj()
+ */
+struct dprc_obj_desc {
+ uint16_t vendor;
+ /* Object vendor identifier */
+ char type[16];
+ /* Type of object: NULL terminated string */
+ int id;
+ /* ID of logical object resource */
+ uint32_t ver_major;
+ /* Major version number */
+ uint32_t ver_minor;
+ /* Minor version number */
+ uint8_t irq_count;
+ /* Number of interrupts supported by the object */
+ uint8_t region_count;
+ /* Number of mappable regions supported by the object */
+ uint32_t state;
+ /* Object state: combination of DPRC_OBJ_STATE_ states */
+};
+
+/*
+ * Mappable region descriptor, returned by dprc_get_obj_region()
+ */
+struct dprc_region_desc {
+ uint64_t base_paddr;
+ /* Region base physical address */
+ uint32_t size;
+ /* Region size (in bytes) */
+};
+
+/*
+ * Iteration status, for use with dprc_get_res_ids() function
+ *
+ */
+enum dprc_iter_status {
+ DPRC_ITER_STATUS_FIRST = 0,
+ /* Perform first iteration */
+ DPRC_ITER_STATUS_MORE = 1,
+ /* Indicates more/next iteration is needed */
+ DPRC_ITER_STATUS_LAST = 2
+ /* Indicates last iteration */
+};
+
+/*
+ * Resource Id range descriptor, Used at dprc_get_res_ids() and
+ * contains one range details.
+ */
+struct dprc_res_ids_range_desc {
+ int base_id;
+ /* Base resource ID of this range */
+ int last_id;
+ /* Last resource ID of this range */
+ enum dprc_iter_status iter_status;
+ /*
+ * Iteration status - should be set to DPRC_ITER_STATUS_FIRST at
+ * first iteration; while the returned marker is DPRC_ITER_STATUS_MORE,
+ * additional iterations are needed, until the returned marker is
+ * DPRC_ITER_STATUS_LAST
+ */
+};
+
+/*
+ * Container attributes, returned by dprc_get_attributes()
+ */
+struct dprc_attributes {
+ int container_id;
+ /* Container's ID */
+ uint16_t icid;
+ /* Container's ICID */
+ int portal_id;
+ /* Container's portal ID */
+ uint64_t options;
+ /* Container's options as set at container's creation */
+ struct {
+ uint32_t major; /* DPRC major version */
+ uint32_t minor; /* DPRC minor version */
+ } version;
+ /* DPRC version */
+};
+
+/*
+ * Container configuration options, used in dprc_create_container()
+ */
+struct dprc_cfg {
+ uint16_t icid;
+ /* Container's ICID; if set to DPRC_GET_ICID_FROM_POOL, a free ICID
+ * will be allocated by the DPRC */
+ int portal_id;
+ /* portal id; if set to DPRC_GET_PORTAL_ID_FROM_POOL, a free portal id
+ * will be allocated by the DPRC */
+ uint64_t options;
+ /* Combination of DPRC_CFG_OPT_ options */
+};
+
+/*
+ * Endpoint description for link connect/disconnect operations
+ */
+struct dprc_endpoint {
+ char type[16];
+ /* Endpoint object type: NULL terminated string */
+ int id;
+ /* Endpoint object id */
+ int interface_id;
+ /*
+ * Interface id; should be set for endpoints with multiple interfaces
+ * (DP_OBJ_DPSW, DP_OBJ_DPDMUX); for others, always set to 0.
+ */
+};
+
+/*
+ * Obtains the container id associated with a given portal.
+ *
+ * mc_io Pointer to opaque I/O object
+ * container_id Requested container ID
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_container_id(struct fsl_mc_io *mc_io, int *container_id);
+
+/*
+ * Opens a DPRC object for use
+ *
+ * mc_io Pointer to opaque I/O object
+ * container_id Container ID to open
+ * dprc_handle Handle to the DPRC object
+ *
+ * returns '0' on Success; Error code otherwise.
+ *
+ * Required before any operation on the object.
+ */
+int dprc_open(struct fsl_mc_io *mc_io, int container_id,
+ uint16_t *dprc_handle);
+
+/*
+ * Closes the DPRC object handle
+ *
+ * No further operations on the object are allowed after this call without
+ * re-opening the object.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_close(struct fsl_mc_io *mc_io, uint16_t dprc_handle);
+
+/*
+ * Creates a child container
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * cfg Child container configuration
+ * child_container_id Child container ID
+ * child_portal_paddr Base physical address of the
+ * child portal
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_create_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_cfg *cfg,
+ int *child_container_id,
+ uint64_t *child_portal_paddr);
+
+/*
+ * Destroys a child container.
+ *
+ * This function terminates the child container, so following this call the
+ * child container ID becomes invalid.
+ *
+ * Notes:
+ * - All resources and objects of the destroyed container are returned to the
+ * parent container or destroyed if were created be the destroyed container.
+ * - This function destroy all the child containers of the specified
+ * container prior to destroying the container itself.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * child_container_id ID of the container to destroy
+ *
+ * returns '0' on Success; Error code otherwise.
+ *
+ * Only the parent container is allowed to destroy a child policy
+ * Container 0 can't be destroyed
+ */
+int dprc_destroy_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id);
+
+/*
+ * Sets allocation policy for a specific resource/object type in a
+ * child container
+ *
+ * Allocation policy determines whether or not a container may allocate
+ * resources from its parent. Each container has a 'global' allocation policy
+ * that is set when the container is created.
+ *
+ * This function sets allocation policy for a specific resource type.
+ * The default policy for all resource types matches the container's 'global'
+ * allocation policy.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * child_container_id ID of the child container
+ * type resource/object type
+ * quota Sets the maximum number of resources of
+ * the selected type that the child
+ * container is allowed to allocate
+ * from its parent;
+ * when quota is set to -1, the policy is
+ * the same as container's general policy.
+ *
+ * returns '0' on Success; Error code otherwise.
+ *
+ * Only the parent container is allowed to change a child policy.
+ */
+int dprc_set_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id, char *type, uint16_t quota);
+
+/*
+ * Gets the allocation policy of a specific resource/object type
+ * in a child container
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * child_container_id ID of the child container
+ * type resource/object type
+ * quota Holds the maximum number of resources of
+ * the selected type that the child
+ * container is allowed to allocate from
+ * the parent;
+ * when quota is set to -1, the policy is
+ * the same as container's general policy.
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id, char *type, uint16_t *quota);
+
+/*
+ * Resets a child container.
+ *
+ * In case a software context crashes or becomes non-responsive, the parent
+ * may wish to reset its resources container before the software context is
+ * restarted.
+ *
+ * This routine informs all objects assigned to the child container that the
+ * container is being reset, so they may perform any cleanup operations that are
+ * needed. All objects handles that were owned by the child container shall be
+ * closed.
+ *
+ * Note that such request may be submitted even if the child software context
+ * has not crashed, but the resulting object cleanup operations will not be
+ * aware of that.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * child_container_id ID of the container to reset
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_reset_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id);
+
+/*
+ * Assigns objects or resource to a child container.
+ *
+ * Assignment is usually done by a parent (this DPRC) to one of its child
+ * containers.
+ *
+ * According to the DPRC allocation policy, the assigned resources may be taken
+ * (allocated) from the container's ancestors, if not enough resources are
+ * available in the container itself.
+ *
+ * The type of assignment depends on the dprc_res_req options, as follows:
+ * - DPRC_RES_REQ_OPT_EXPLICIT: indicates that assigned resources should have
+ * the explicit base ID specified at the id_base_align field of res_req.
+ * - DPRC_RES_REQ_OPT_ALIGNED: indicates that the assigned resources should be
+ * aligned to the value given at id_base_align field of res_req.
+ * - DPRC_RES_REQ_OPT_PLUGGED: Relevant only for object assignment,
+ * and indicates that the object must be set to the plugged state.
+ *
+ * A container may use this function with its own ID in order to change a
+ * object state to plugged or unplugged.
+ *
+ * If IRQ information has been set in the child DPRC, it will signal an
+ * interrupt following every change in its object assignment.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * container_id ID of the child container
+ * res_req Describes the type and amount of resources to
+ * assign to the given container.
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_assign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int container_id, struct dprc_res_req *res_req);
+
+/*
+ * Un-assigns objects or resources from a child container
+ * and moves them into this (parent) DPRC.
+ *
+ * Un-assignment of objects can succeed only if the object is not in the
+ * plugged or opened state.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * child_container_id ID of the child container
+ * res_req Describes the type and amount of
+ * resources to un-assign from the child
+ * container
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_unassign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int child_container_id, struct dprc_res_req *res_req);
+
+/*
+ * Get the number of dprc's pools
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * pool_count Number of resource pools in the dprc.
+ *
+ * returns '0' on Success; Error code otherwise.
+ * */
+int dprc_get_pool_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int *pool_count);
+
+/*
+ * Get the type (string) of a certain dprc's pool
+ *
+ * The pool types retrieved one by one by incrementing
+ * pool_index up to (not including) the value of pool_count returned
+ * from dprc_get_pool_count(). dprc_get_pool_count() must
+ * be called prior to dprc_get_pool().
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * pool_index Index of the pool to be queried (< pool_count)
+ * type The type of the pool.
+ *
+ * returns '0' on Success; Error code otherwise.
+ * */
+int dprc_get_pool(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int pool_index, char *type);
+
+/*
+ * Obtains the number of objects in the DPRC
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * obj_count Number of objects assigned to the DPRC
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_obj_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int *obj_count);
+
+/*
+ * Obtains general information on an object
+ *
+ * The object descriptors are retrieved one by one by incrementing
+ * obj_index up to (not including) the value of obj_count returned
+ * from dprc_get_obj_count(). dprc_get_obj_count() must
+ * be called prior to dprc_get_obj().
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * obj_index Index of the object to be queried (< obj_count)
+ * obj_desc Returns the requested object descriptor
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_obj(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int obj_index, struct dprc_obj_desc *obj_desc);
+
+/*
+ * Obtains the number of free resources that are assigned
+ * to this container, by pool type
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * type pool type
+ * res_count Number of free resources of the given
+ * resource type that are assigned to this DPRC
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_res_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ char *type, int *res_count);
+
+/*
+ * Obtains IDs of free resources in the container
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * type pool type
+ * range_desc range descriptor
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_res_ids(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ char *type, struct dprc_res_ids_range_desc *range_desc);
+
+/*
+ * Obtains the physical address of MC portals
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * portal_id MC portal id
+ * portal_addr The physical address of the MC portal id
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_portal_paddr(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ int portal_id, uint64_t *portal_addr);
+
+/*
+ * Obtains container attributes
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * attributes Container attributes
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_attributes(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_attributes *attributes);
+
+/*
+ * Returns region information for a specified object.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * obj_type Object type as returned in dprc_get_obj()
+ * obj_id Unique object instance as returned in
+ * dprc_get_obj()
+ * region_index The specific region to query
+ * region_desc Returns the requested region descriptor
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_obj_region(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ char *obj_type,
+ int obj_id,
+ uint8_t region_index,
+ struct dprc_region_desc *region_desc);
+
+/*
+ * Sets IRQ information for the DPRC to trigger an interrupt.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index Identifies the interrupt index to configure
+ * DPRC supports only irq_index 0 - this interrupt
+ * will be signaled on every change to
+ * resource/object assignment in this DPRC.
+ * irq_paddr Physical IRQ address that must be written to
+ * signal a message-based interrupt
+ * irq_val Value to write into irq_paddr address
+ * user_irq_id A user defined number associated with this IRQ;
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_set_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index,
+ uint64_t irq_paddr, uint32_t irq_val, int user_irq_id);
+
+/*
+ * Gets IRQ information from the DPRC.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index The interrupt index to configure;
+ * DPRC supports only irq_index 0 - this interrupt
+ * will be signaled on every change to
+ * resource/object assignment in this DPRC.
+ * type Interrupt type: 0 represents message interrupt
+ * type (both irq_paddr and irq_val are valid);
+ * irq_paddr Physical address that must be written in order
+ * to signal the message-based interrupt
+ * irq_val Value to write in order to signal the
+ * message-based interrupt
+ * user_irq_id A user defined number associated with this IRQ;
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index,
+ int *type,
+ uint64_t *irq_paddr, uint32_t *irq_val, int *user_irq_id);
+
+/*
+ * Sets overall interrupt state.
+ *
+ * Allows GPP software to control when interrupts are generated.
+ * Each interrupt can have up to 32 causes. The enable/disable control's the
+ * overall interrupt state. if the interrupt is disabled no causes will cause an
+ * interrupt.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index The interrupt index to configure
+ * enable_state Interrupt state - enable = 1, disable = 0.
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_set_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint8_t enable_state);
+
+/*
+ * Gets overall interrupt state
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index The interrupt index to configure
+ * enable_state Interrupt state - enable = 1, disable = 0.
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint8_t *enable_state);
+
+/*
+ * Sets interrupt mask.
+ *
+ * Every interrupt can have up to 32 causes and the interrupt model supports
+ * masking/unmasking each cause independently
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index The interrupt index to configure
+ * mask Event mask to trigger interrupt.
+ * each bit:
+ * 0 = ignore event
+ * 1 = consider event for asserting irq
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_set_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t mask);
+
+/*
+ * Gets interrupt mask.
+ *
+ * Every interrupt can have up to 32 causes and the interrupt model supports
+ * masking/unmasking each cause independently
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index The interrupt index to configure
+ * mask Event mask to trigger interrupt
+ *
+ * returns '0' on Success; Error code otherwise.
+ */
+int dprc_get_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t *mask);
+
+/*
+ * Gets the current status of any pending interrupts.
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index The interrupt index to configure
+ * status Interrupts status - one bit per cause
+ * 0 = no interrupt pending
+ * 1 = interrupt pending
+ *
+ * returns '0' on Success; Error code otherwise.
+ * */
+int dprc_get_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t *status);
+
+/*
+ * Clears a pending interrupt's status
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * irq_index The interrupt index to configure
+ * status Bits to clear (W1C) - one bit per cause
+ * 0 = don't change
+ * 1 = clear status bit
+ *
+ * returns '0' on Success; Error code otherwise.
+ * */
+int dprc_clear_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ uint8_t irq_index, uint32_t status);
+
+/*
+ * Connects two endpoints to create a network link between them
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * endpoint1 Endpoint 1 configuration parameters.
+ * endpoint2 Endpoint 2 configuration parameters.
+ *
+ * returns '0' on Success; Error code otherwise.
+ * */
+int dprc_connect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_endpoint *endpoint1,
+ struct dprc_endpoint *endpoint2);
+
+/*
+ * Disconnects one endpoint to remove its network link
+ *
+ * mc_io Pointer to opaque I/O object
+ * dprc_handle Handle to the DPRC object
+ * endpoint Endpoint configuration parameters.
+ *
+ * returns '0' on Success; Error code otherwise.
+ * */
+int dprc_disconnect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
+ struct dprc_endpoint *endpoint);
+
+/* */
+
+#endif /* _FSL_DPRC_H */
diff --git a/include/linux/fsl/mc-cmd.h b/include/linux/fsl/mc-cmd.h
new file mode 100644
index 0000000..737e372
--- /dev/null
+++ b/include/linux/fsl/mc-cmd.h
@@ -0,0 +1,169 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef __FSL_MC_CMD_H
+#define __FSL_MC_CMD_H
+
+#include <linux/fsl/mc-sys.h>
+
+/*
+ * MC clients (GPP side) encode MC command parameters and decode MC response
+ * parameters
+ */
+
+#define MC_CMD_PARAM_OP(_cmd, _param, _offset, _width, _type, _arg) \
+ ((_cmd).params[_param] |= u64_enc((_offset), (_width), (_type)(_arg)))
+
+#define MC_RSP_PARAM_OP(_cmd, _param, _offset, _width, _type, _arg) \
+ ((_arg) = (_type)u64_dec((_cmd).params[_param], (_offset), (_width)))
+
+#define MAKE_UMASK64(_width) \
+ ((uint64_t)((_width) < 64 ? ((uint64_t)1 << (_width)) - 1 : -1))
+
+static inline uint64_t u64_enc(int lsoffset, int width, uint64_t val)
+{
+ return (uint64_t)(((uint64_t)val & MAKE_UMASK64(width)) << lsoffset);
+}
+
+static inline uint64_t u64_dec(uint64_t val, int lsoffset, int width)
+{
+ return (uint64_t)((val >> lsoffset) & MAKE_UMASK64(width));
+}
+
+#define MC_CMD_NUM_OF_PARAMS 7
+
+struct mc_command {
+ uint64_t header;
+ uint64_t params[MC_CMD_NUM_OF_PARAMS];
+};
+
+enum mc_cmd_status {
+ MC_CMD_STATUS_OK = 0x0, /*!< Completed successfully */
+ MC_CMD_STATUS_READY = 0x1, /*!< Ready to be processed */
+ MC_CMD_STATUS_AUTH_ERR = 0x3, /*!< Authentication error */
+ MC_CMD_STATUS_NO_PRIVILEGE = 0x4, /*!< No privilege */
+ MC_CMD_STATUS_DMA_ERR = 0x5, /*!< DMA or I/O error */
+ MC_CMD_STATUS_CONFIG_ERR = 0x6, /*!< Configuration error */
+ MC_CMD_STATUS_TIMEOUT = 0x7, /*!< Operation timed out */
+ MC_CMD_STATUS_NO_RESOURCE = 0x8, /*!< No resources */
+ MC_CMD_STATUS_NO_MEMORY = 0x9, /*!< No memory available */
+ MC_CMD_STATUS_BUSY = 0xA, /*!< Device is busy */
+ MC_CMD_STATUS_UNSUPPORTED_OP = 0xB, /*!< Unsupported operation */
+ MC_CMD_STATUS_INVALID_STATE = 0xC /*!< Invalid state */
+};
+
+#define MC_CMD_HDR_CMDID_O 52 /* Command ID field offset */
+#define MC_CMD_HDR_CMDID_S 12 /* Command ID field size */
+#define MC_CMD_HDR_AUTHID_O 38 /* Authentication ID field offset */
+#define MC_CMD_HDR_AUTHID_S 10 /* Authentication ID field size */
+#define MC_CMD_HDR_SIZE_O 31 /* Size field offset */
+#define MC_CMD_HDR_SIZE_S 6 /* Size field size */
+#define MC_CMD_HDR_STATUS_O 16 /* Status field offset */
+#define MC_CMD_HDR_STATUS_S 8 /* Status field size */
+#define MC_CMD_HDR_PRI_O 15 /* Priority field offset */
+#define MC_CMD_HDR_PRI_S 1 /* Priority field size */
+
+#define MC_CMD_HDR_READ_STATUS(_hdr) \
+ ((enum mc_cmd_status)u64_dec((_hdr), \
+ MC_CMD_HDR_STATUS_O, MC_CMD_HDR_STATUS_S))
+
+#define MC_CMD_HDR_READ_AUTHID(_hdr) \
+ ((uint16_t)u64_dec((_hdr), MC_CMD_HDR_AUTHID_O, MC_CMD_HDR_AUTHID_S))
+
+#define MC_CMD_PRI_LOW 0 /*!< Low Priority command indication */
+#define MC_CMD_PRI_HIGH 1 /*!< High Priority command indication */
+
+static inline uint64_t mc_encode_cmd_header(uint16_t cmd_id,
+ uint8_t cmd_size,
+ uint8_t priority, uint16_t auth_id)
+{
+ uint64_t hdr;
+
+ hdr = u64_enc(MC_CMD_HDR_CMDID_O, MC_CMD_HDR_CMDID_S, cmd_id);
+ hdr |= u64_enc(MC_CMD_HDR_AUTHID_O, MC_CMD_HDR_AUTHID_S, auth_id);
+ hdr |= u64_enc(MC_CMD_HDR_SIZE_O, MC_CMD_HDR_SIZE_S, cmd_size);
+ hdr |= u64_enc(MC_CMD_HDR_PRI_O, MC_CMD_HDR_PRI_S, priority);
+ hdr |= u64_enc(MC_CMD_HDR_STATUS_O, MC_CMD_HDR_STATUS_S,
+ MC_CMD_STATUS_READY);
+
+ return hdr;
+}
+
+/**
+ * mc_write_command - writes a command to a Management Complex (MC) portal
+ *
+ * @portal: pointer to an MC portal
+ * @cmd: pointer to a filled command
+ */
+static inline void mc_write_command(struct mc_command __iomem *portal,
+ struct mc_command *cmd)
+{
+ int i;
+
+ /* copy command parameters into the portal */
+ for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++)
+ writeq(cmd->params[i], &portal->params[i]);
+
+ /* submit the command by writing the header */
+ writeq(cmd->header, &portal->header);
+}
+
+/**
+ * mc_read_response - reads the response for the last MC command from a
+ * Management Complex (MC) portal
+ *
+ * @portal: pointer to an MC portal
+ * @resp: pointer to command response buffer
+ *
+ * Returns MC_CMD_STATUS_OK on Success; Error code otherwise.
+ */
+static inline enum mc_cmd_status mc_read_response(struct mc_command __iomem *
+ portal,
+ struct mc_command *resp)
+{
+ int i;
+ enum mc_cmd_status status;
+
+ /* Copy command response header from MC portal: */
+ resp->header = readq(&portal->header);
+ status = MC_CMD_HDR_READ_STATUS(resp->header);
+ if (status != MC_CMD_STATUS_OK)
+ return status;
+
+ /* Copy command response data from MC portal: */
+ for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++)
+ resp->params[i] = readq(&portal->params[i]);
+
+ return status;
+}
+
+#endif /* __FSL_MC_CMD_H */
diff --git a/include/linux/fsl/mc-sys.h b/include/linux/fsl/mc-sys.h
new file mode 100644
index 0000000..ee57cd6
--- /dev/null
+++ b/include/linux/fsl/mc-sys.h
@@ -0,0 +1,68 @@
+/* Copyright 2013-2014 Freescale Semiconductor Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ * * Neither the name of the above-listed copyright holders nor the
+ * names of any contributors may be used to endorse or promote products
+ * derived from this software without specific prior written permission.
+ *
+ *
+ * ALTERNATIVELY, this software may be distributed under the terms of the
+ * GNU General Public License ("GPL") as published by the Free Software
+ * Foundation, either version 2 of that License or (at your option) any
+ * later version.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef _FSL_MC_SYS_H
+#define _FSL_MC_SYS_H
+
+#include <linux/types.h>
+#include <linux/errno.h>
+#include <linux/io.h>
+#include <linux/dma-mapping.h>
+
+struct mc_command;
+
+/**
+ * struct fsl_mc_io - MC I/O object to be passed-in to mc_send_command()
+ * @dev: device associated with this Mc I/O object
+ * @flags: flags for mc_send_command()
+ * @portal_size: MC command portal size in bytes
+ * @portal_phys_addr: MC command portal physical address
+ * @portal_virt_addr: MC command portal virtual address
+ */
+struct fsl_mc_io {
+ struct device *dev;
+ uint32_t flags;
+ uint32_t portal_size;
+ phys_addr_t portal_phys_addr;
+ void __iomem *portal_virt_addr;
+};
+
+int __must_check fsl_create_mc_io(struct device *dev,
+ phys_addr_t mc_portal_phys_addr,
+ uint32_t mc_portal_size,
+ uint32_t flags, struct fsl_mc_io **new_mc_io);
+
+void fsl_destroy_mc_io(struct fsl_mc_io *mc_io);
+
+int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd);
+
+#endif /* _FSL_MC_SYS_H */
--
1.7.9.7

2014-10-04 13:39:54

by J. German Rivera

[permalink] [raw]
Subject: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

From: "J. German Rivera" <[email protected]>

Platform device driver that sets up the basic bus infrastructure
for the fsl-mc bus type, including support for adding/removing
fsl-mc devices, register/unregister of fsl-mc drivers, and bus
match support to bind devices to drivers.

Signed-off-by: J. German Rivera <[email protected]>
Signed-off-by: Stuart Yoder <[email protected]>
---
Changes in v3:
- Addressed changes from Kim Phillips:
* Renamed files:
drivers/bus/fsl-mc/fsl_mc_bus.c -> drivers/bus/fsl-mc/mc-bus.c
include/linux/fsl_mc.h -> include/linux/fsl/mc.h
include/linux/fsl_mc_private.h -> include/linux/fsl/mc-private.h

- Addressed comments from Timur Tabi:
* Changed all functions that had goto out/error when no common cleanup
was done, to just have multiple return points.
* Replaced error cleanup boolean flags with multiple exit points.

Changes in v2:
- Addressed comment from Joe Perches:
* Changed pr_debug to dev_dbg in fsl_mc_bus_match

- Addressed comments from Kim Phillips and Alex Graf:
* Changed version check to allow the driver to run with MC
firmware that has major version number greater than or equal
to the driver's major version number.
* Removed minor version check

- Removed unused variable parent_dev in fsl_mc_device_remove

drivers/bus/Kconfig | 3 +
drivers/bus/Makefile | 3 +
drivers/bus/fsl-mc/Kconfig | 13 +
drivers/bus/fsl-mc/Makefile | 14 +
drivers/bus/fsl-mc/mc-bus.c | 566 ++++++++++++++++++++++++++++++++++++++++
include/linux/fsl/mc-private.h | 33 +++
include/linux/fsl/mc.h | 137 ++++++++++
7 files changed, 769 insertions(+)
create mode 100644 drivers/bus/fsl-mc/Kconfig
create mode 100644 drivers/bus/fsl-mc/Makefile
create mode 100644 drivers/bus/fsl-mc/mc-bus.c
create mode 100644 include/linux/fsl/mc-private.h
create mode 100644 include/linux/fsl/mc.h

diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 603eb1b..2fbb1fd 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -67,4 +67,7 @@ config VEXPRESS_CONFIG
help
Platform configuration infrastructure for the ARM Ltd.
Versatile Express.
+
+source "drivers/bus/fsl-mc/Kconfig"
+
endmenu
diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
index 2973c18..6abcab1 100644
--- a/drivers/bus/Makefile
+++ b/drivers/bus/Makefile
@@ -15,3 +15,6 @@ obj-$(CONFIG_ARM_CCI) += arm-cci.o
obj-$(CONFIG_ARM_CCN) += arm-ccn.o

obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress-config.o
+
+# Freescale Management Complex (MC) bus drivers
+obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/
diff --git a/drivers/bus/fsl-mc/Kconfig b/drivers/bus/fsl-mc/Kconfig
new file mode 100644
index 0000000..e3226f9
--- /dev/null
+++ b/drivers/bus/fsl-mc/Kconfig
@@ -0,0 +1,13 @@
+#
+# Freescale Management Complex (MC) bus drivers
+#
+# Copyright (C) 2014 Freescale Semiconductor, Inc.
+#
+# This file is released under the GPLv2
+#
+
+config FSL_MC_BUS
+ tristate "Freescale Management Complex (MC) bus driver"
+ help
+ Driver to enable the bus infrastructure for the Freescale
+ QorIQ Management Complex.
diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
new file mode 100644
index 0000000..decd339
--- /dev/null
+++ b/drivers/bus/fsl-mc/Makefile
@@ -0,0 +1,14 @@
+#
+# Freescale Management Complex (MC) bus drivers
+#
+# Copyright (C) 2014 Freescale Semiconductor, Inc.
+#
+# This file is released under the GPLv2
+#
+obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
+
+mc-bus-driver-objs := mc-bus.o \
+ mc-sys.o \
+ dprc.o \
+ dpmng.o
+
diff --git a/drivers/bus/fsl-mc/mc-bus.c b/drivers/bus/fsl-mc/mc-bus.c
new file mode 100644
index 0000000..d19fb18
--- /dev/null
+++ b/drivers/bus/fsl-mc/mc-bus.c
@@ -0,0 +1,566 @@
+/*
+ * Freescale Management Complex (MC) bus driver
+ *
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ * Author: German Rivera <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/fsl/mc-private.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/of_address.h>
+#include <linux/ioport.h>
+#include <linux/slab.h>
+#include <linux/limits.h>
+#include <linux/fsl/dpmng.h>
+#include <linux/fsl/mc-sys.h>
+#include "dprc-cmd.h"
+
+static struct kmem_cache *mc_dev_cache;
+
+/**
+ * fsl_mc_bus_match - device to driver matching callback
+ * @dev: the MC object device structure to match against
+ * @drv: the device driver to search for matching MC object device id
+ * structures
+ *
+ * Returns 1 on success, 0 otherwise.
+ */
+static int fsl_mc_bus_match(struct device *dev, struct device_driver *drv)
+{
+ const struct fsl_mc_device_match_id *id;
+ struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
+ struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(drv);
+ bool found = false;
+
+ if (mc_drv->match_id_table == NULL)
+ goto out;
+
+ /*
+ * If the object is not 'plugged' don't match.
+ * Only exception is the root DPRC, which is a special case.
+ */
+ if ((mc_dev->obj_desc.state & DPRC_OBJ_STATE_PLUGGED) == 0 &&
+ &mc_dev->dev != fsl_mc_bus_type.dev_root)
+ goto out;
+
+ /*
+ * Traverse the match_id table of the given driver, trying to find
+ * a matching for the given MC object device.
+ */
+ for (id = mc_drv->match_id_table; id->vendor != 0x0; id++) {
+ if (id->vendor == mc_dev->obj_desc.vendor &&
+ strcmp(id->obj_type, mc_dev->obj_desc.type) == 0 &&
+ id->ver_major == mc_dev->obj_desc.ver_major &&
+ id->ver_minor == mc_dev->obj_desc.ver_minor) {
+ found = true;
+ break;
+ }
+ }
+
+out:
+ dev_dbg(dev, "%smatched\n", found ? "" : "not ");
+ return found;
+}
+
+/**
+ * fsl_mc_bus_uevent - callback invoked when a device is added
+ */
+static int fsl_mc_bus_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+ pr_debug("%s invoked\n", __func__);
+ return 0;
+}
+
+struct bus_type fsl_mc_bus_type = {
+ .name = "fsl-mc",
+ .match = fsl_mc_bus_match,
+ .uevent = fsl_mc_bus_uevent,
+};
+EXPORT_SYMBOL_GPL(fsl_mc_bus_type);
+
+static int fsl_mc_driver_probe(struct device *dev)
+{
+ struct fsl_mc_driver *mc_drv;
+ struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
+ int error;
+
+ if (WARN_ON(dev->driver == NULL))
+ return -EINVAL;
+
+ mc_drv = to_fsl_mc_driver(dev->driver);
+ if (WARN_ON(mc_drv->probe == NULL))
+ return -EINVAL;
+
+ error = mc_drv->probe(mc_dev);
+ if (error < 0) {
+ dev_err(dev, "MC object device probe callback failed: %d\n",
+ error);
+ return error;
+ }
+
+ return 0;
+}
+
+static int fsl_mc_driver_remove(struct device *dev)
+{
+ struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(dev->driver);
+ struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
+ int error;
+
+ if (WARN_ON(dev->driver == NULL))
+ return -EINVAL;
+
+ error = mc_drv->remove(mc_dev);
+ if (error < 0) {
+ dev_err(dev,
+ "MC object device remove callback failed: %d\n",
+ error);
+ return error;
+ }
+
+ return 0;
+}
+
+static void fsl_mc_driver_shutdown(struct device *dev)
+{
+ struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(dev->driver);
+ struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
+
+ mc_drv->shutdown(mc_dev);
+}
+
+/**
+ * __fsl_mc_driver_register - registers a child device driver with the
+ * MC bus
+ *
+ * This function is implicitly invoked from the registration function of
+ * fsl_mc device drivers, which is generated by the
+ * module_fsl_mc_driver() macro.
+ */
+int __fsl_mc_driver_register(struct fsl_mc_driver *mc_driver,
+ struct module *owner)
+{
+ int error;
+
+ mc_driver->driver.owner = owner;
+ mc_driver->driver.bus = &fsl_mc_bus_type;
+
+ /*
+ * Set default driver callbacks, if not set by the child driver:
+ */
+ if (mc_driver->probe != NULL)
+ mc_driver->driver.probe = fsl_mc_driver_probe;
+
+ if (mc_driver->remove != NULL)
+ mc_driver->driver.remove = fsl_mc_driver_remove;
+
+ if (mc_driver->shutdown != NULL)
+ mc_driver->driver.shutdown = fsl_mc_driver_shutdown;
+
+ error = driver_register(&mc_driver->driver);
+ if (error < 0) {
+ pr_err("driver_register() failed for %s: %d\n",
+ mc_driver->driver.name, error);
+ return error;
+ }
+
+ pr_info("MC object device driver %s registered\n",
+ mc_driver->driver.name);
+ return 0;
+}
+EXPORT_SYMBOL_GPL(__fsl_mc_driver_register);
+
+/**
+ * fsl_mc_driver_unregister - unregisters a device driver from the
+ * MC bus
+ */
+void fsl_mc_driver_unregister(struct fsl_mc_driver *mc_driver)
+{
+ driver_unregister(&mc_driver->driver);
+}
+EXPORT_SYMBOL_GPL(fsl_mc_driver_unregister);
+
+static int get_dprc_icid(struct fsl_mc_io *mc_io,
+ int container_id, uint16_t *icid)
+{
+ uint16_t dprc_handle;
+ struct dprc_attributes attr;
+ int error;
+
+ error = dprc_open(mc_io, container_id, &dprc_handle);
+ if (error < 0) {
+ pr_err("dprc_open() failed: %d\n", error);
+ return error;
+ }
+
+ memset(&attr, 0, sizeof(attr));
+ error = dprc_get_attributes(mc_io, dprc_handle, &attr);
+ if (error < 0) {
+ pr_err("dprc_get_attributes() failed: %d\n", error);
+ goto common_cleanup;
+ }
+
+ *icid = attr.icid;
+ error = 0;
+
+common_cleanup:
+ (void)dprc_close(mc_io, dprc_handle);
+ return error;
+}
+
+static int fsl_mc_device_get_mmio_regions(struct fsl_mc_device *mc_dev,
+ struct fsl_mc_device *mc_bus_dev)
+{
+ int i;
+ int error;
+ struct resource *regions;
+ struct dprc_obj_desc *obj_desc = &mc_dev->obj_desc;
+ struct device *parent_dev = mc_dev->dev.parent;
+
+ regions = kmalloc_array(obj_desc->region_count,
+ sizeof(regions[0]), GFP_KERNEL);
+ if (regions == NULL)
+ return -ENOMEM;
+
+ for (i = 0; i < obj_desc->region_count; i++) {
+ struct dprc_region_desc region_desc;
+
+ error = dprc_get_obj_region(mc_bus_dev->mc_io,
+ mc_bus_dev->mc_handle,
+ obj_desc->type,
+ obj_desc->id, i, &region_desc);
+ if (error < 0) {
+ dev_err(parent_dev,
+ "dprc_get_obj_region() failed: %d\n", error);
+ goto error_cleanup_regions;
+ }
+
+ WARN_ON(region_desc.base_paddr == 0x0);
+ WARN_ON(region_desc.size == 0);
+ regions[i].start = region_desc.base_paddr;
+ regions[i].end = region_desc.base_paddr + region_desc.size - 1;
+ regions[i].name = "fsl-mc object MMIO region";
+ regions[i].flags = IORESOURCE_IO;
+ }
+
+ mc_dev->regions = regions;
+ return 0;
+
+error_cleanup_regions:
+ kfree(regions);
+ return error;
+}
+
+/**
+ * Add a newly discovered MC object device to be visible in Linux
+ */
+int fsl_mc_device_add(struct dprc_obj_desc *obj_desc,
+ struct fsl_mc_io *mc_io,
+ struct device *parent_dev,
+ struct fsl_mc_device **new_mc_dev)
+{
+ int error;
+ struct fsl_mc_device *mc_dev = NULL;
+ struct fsl_mc_device *parent_mc_dev;
+
+ if (parent_dev->bus == &fsl_mc_bus_type)
+ parent_mc_dev = to_fsl_mc_device(parent_dev);
+ else
+ parent_mc_dev = NULL;
+
+ /*
+ * DPRC devices must have a dedicated MC portal
+ */
+ if (WARN_ON(strcmp(obj_desc->type, "dprc") == 0 && mc_io == NULL))
+ return -EINVAL;
+
+ mc_dev = kmem_cache_zalloc(mc_dev_cache, GFP_KERNEL);
+ if (mc_dev == NULL) {
+ dev_err(parent_dev,
+ "No memory to allocate fsl_mc_device\n");
+ return -ENOMEM;
+ }
+
+ mc_dev->obj_desc = *obj_desc;
+ mc_dev->mc_io = mc_io;
+ device_initialize(&mc_dev->dev);
+ mc_dev->dev.parent = parent_dev;
+ mc_dev->dev.bus = &fsl_mc_bus_type;
+ dev_set_name(&mc_dev->dev, "%s.%x", obj_desc->type, obj_desc->id);
+
+ if (strcmp(obj_desc->type, "dprc") == 0) {
+ struct fsl_mc_io *mc_io2;
+
+ mc_dev->flags |= FSL_MC_IS_DPRC;
+
+ /*
+ * To get the DPRC's ICID, we need to open the DPRC
+ * in get_dprc_icid(). For child DPRCs, we do so using the
+ * parent DPRC's MC portal instead of the child DPRC's MC
+ * portal, in case the child DPRC is already opened with
+ * its own portal (e.g., the DPRC used by AIOP).
+ *
+ * NOTE: There cannot be more than one active open for a
+ * given MC object, using the same MC portal.
+ */
+ if (parent_mc_dev != NULL) {
+ /*
+ * device being added is a child DPRC device
+ */
+ mc_io2 = parent_mc_dev->mc_io;
+ } else {
+ /*
+ * device being added is the root DPRC device
+ */
+ mc_io2 = mc_io;
+ }
+
+ error = get_dprc_icid(mc_io2, obj_desc->id, &mc_dev->icid);
+ if (error < 0)
+ goto error_cleanup_dev;
+ } else {
+ /*
+ * A non-DPRC MC object device has to be a child of another
+ * MC object (specifically a DPRC object)
+ */
+ mc_dev->icid = parent_mc_dev->icid;
+ mc_dev->dma_mask = FSL_MC_DEFAULT_DMA_MASK;
+ mc_dev->dev.dma_mask = &mc_dev->dma_mask;
+ if (obj_desc->region_count != 0) {
+ error = fsl_mc_device_get_mmio_regions(mc_dev,
+ parent_mc_dev);
+ if (error < 0)
+ goto error_cleanup_dev;
+ }
+ }
+
+ /*
+ * The device-specific probe callback will get invoked by device_add()
+ */
+ error = device_add(&mc_dev->dev);
+ if (error < 0) {
+ dev_err(parent_dev,
+ "device_add() failed for device %s: %d\n",
+ dev_name(&mc_dev->dev), error);
+ goto error_cleanup_dev;
+ }
+
+ (void)get_device(&mc_dev->dev);
+ dev_dbg(parent_dev, "Added MC object device %s\n",
+ dev_name(&mc_dev->dev));
+
+ *new_mc_dev = mc_dev;
+ return 0;
+
+error_cleanup_dev:
+ if (mc_dev->regions != NULL)
+ kfree(mc_dev->regions);
+
+ kmem_cache_free(mc_dev_cache, mc_dev);
+ return error;
+}
+EXPORT_SYMBOL_GPL(fsl_mc_device_add);
+
+/**
+ * fsl_mc_device_remove - Remove a MC object device from being visible to
+ * Linux
+ *
+ * @mc_dev: Pointer to a MC object device object
+ */
+void fsl_mc_device_remove(struct fsl_mc_device *mc_dev)
+{
+ if (mc_dev->regions != NULL)
+ kfree(mc_dev->regions);
+
+ /*
+ * The device-specific remove callback will get invoked by device_del()
+ */
+ device_del(&mc_dev->dev);
+ put_device(&mc_dev->dev);
+
+ if (strcmp(mc_dev->obj_desc.type, "dprc") == 0)
+ fsl_destroy_mc_io(mc_dev->mc_io);
+
+ mc_dev->mc_io = NULL;
+ kmem_cache_free(mc_dev_cache, mc_dev);
+}
+EXPORT_SYMBOL_GPL(fsl_mc_device_remove);
+
+/**
+ * fsl_mc_bus_probe - callback invoked when the root MC bus is being
+ * added
+ */
+static int fsl_mc_bus_probe(struct platform_device *pdev)
+{
+ struct dprc_obj_desc obj_desc;
+ int error;
+ struct fsl_mc_device *mc_bus_dev = NULL;
+ struct fsl_mc_io *mc_io = NULL;
+ int container_id;
+ phys_addr_t mc_portal_phys_addr;
+ uint32_t mc_portal_size;
+ struct mc_version mc_version;
+ struct resource res;
+
+ dev_info(&pdev->dev, "Root MC bus device probed");
+ error = of_address_to_resource(pdev->dev.of_node, 0, &res);
+ if (error < 0) {
+ dev_err(&pdev->dev,
+ "of_address_to_resource() failed for %s\n",
+ pdev->dev.of_node->full_name);
+ return error;
+ }
+
+ mc_portal_phys_addr = res.start;
+ mc_portal_size = resource_size(&res);
+ error = fsl_create_mc_io(&pdev->dev, mc_portal_phys_addr,
+ mc_portal_size, 0, &mc_io);
+ if (error < 0)
+ return error;
+
+ error = mc_get_version(mc_io, &mc_version);
+ if (error != 0) {
+ dev_err(&pdev->dev,
+ "mc_get_version() failed with error %d\n", error);
+ goto error_cleanup_mc_io;
+ }
+
+ dev_info(&pdev->dev,
+ "Freescale Management Complex Firmware version: %u.%u.%u\n",
+ mc_version.major, mc_version.minor, mc_version.revision);
+
+ if (mc_version.major < MC_VER_MAJOR) {
+ dev_err(&pdev->dev,
+ "ERROR: MC firmware version not supported by driver (driver version: %u.%u)\n",
+ MC_VER_MAJOR, MC_VER_MINOR);
+ error = -ENOTSUPP;
+ goto error_cleanup_mc_io;
+ }
+
+ if (mc_version.major > MC_VER_MAJOR) {
+ dev_warn(&pdev->dev,
+ "WARNING: driver may not support newer MC firmware features (driver version: %u.%u)\n",
+ MC_VER_MAJOR, MC_VER_MINOR);
+ }
+
+ error = dprc_get_container_id(mc_io, &container_id);
+ if (error < 0) {
+ dev_err(&pdev->dev,
+ "dprc_get_container_id() failed: %d\n", error);
+ goto error_cleanup_mc_io;
+ }
+
+ obj_desc.vendor = FSL_MC_VENDOR_FREESCALE;
+ strcpy(obj_desc.type, "dprc");
+ obj_desc.id = container_id;
+ obj_desc.ver_major = DPRC_VER_MAJOR;
+ obj_desc.ver_minor = DPRC_VER_MINOR;
+ obj_desc.region_count = 0;
+
+ error = fsl_mc_device_add(&obj_desc, mc_io, &pdev->dev, &mc_bus_dev);
+ if (error < 0)
+ goto error_cleanup_mc_io;
+
+ platform_set_drvdata(pdev, mc_bus_dev);
+ fsl_mc_bus_type.dev_root = &mc_bus_dev->dev;
+ return 0;
+
+error_cleanup_mc_io:
+ fsl_destroy_mc_io(mc_io);
+ return error;
+}
+
+/**
+ * fsl_mc_bus_remove - callback invoked when the root MC bus is being
+ * removed
+ */
+static int fsl_mc_bus_remove(struct platform_device *pdev)
+{
+ struct fsl_mc_device *mc_bus_dev = platform_get_drvdata(pdev);
+
+ if (WARN_ON(&mc_bus_dev->dev != fsl_mc_bus_type.dev_root))
+ return -EINVAL;
+
+ fsl_mc_device_remove(mc_bus_dev);
+ fsl_mc_bus_type.dev_root = NULL;
+ dev_info(&pdev->dev, "Root MC bus device removed");
+ return 0;
+}
+
+static const struct of_device_id fsl_mc_bus_match_table[] = {
+ {.compatible = "fsl,qoriq-mc",},
+ {},
+};
+
+MODULE_DEVICE_TABLE(of, fsl_mc_bus_match_table);
+
+static struct platform_driver fsl_mc_bus_driver = {
+ .driver = {
+ .name = "fsl_mc_bus",
+ .owner = THIS_MODULE,
+ .pm = NULL,
+ .of_match_table = fsl_mc_bus_match_table,
+ },
+ .probe = fsl_mc_bus_probe,
+ .remove = fsl_mc_bus_remove,
+};
+
+static int __init fsl_mc_bus_driver_init(void)
+{
+ int error;
+
+ mc_dev_cache = kmem_cache_create("fsl_mc_device",
+ sizeof(struct fsl_mc_device), 0, 0,
+ NULL);
+ if (mc_dev_cache == NULL) {
+ pr_err("Could not create fsl_mc_device cache\n");
+ return -ENOMEM;
+ }
+
+ error = bus_register(&fsl_mc_bus_type);
+ if (error < 0) {
+ pr_err("fsl-mc bus type registration failed: %d\n", error);
+ goto error_cleanup_cache;
+ }
+
+ pr_info("fsl-mc bus type registered\n");
+
+ error = platform_driver_register(&fsl_mc_bus_driver);
+ if (error < 0) {
+ pr_err("platform_driver_register() failed: %d\n", error);
+ goto error_cleanup_bus;
+ }
+
+ return 0;
+
+error_cleanup_bus:
+ bus_unregister(&fsl_mc_bus_type);
+
+error_cleanup_cache:
+ kmem_cache_destroy(mc_dev_cache);
+ return error;
+}
+
+postcore_initcall(fsl_mc_bus_driver_init);
+
+static void __exit fsl_mc_bus_driver_exit(void)
+{
+ if (WARN_ON(mc_dev_cache == NULL))
+ return;
+
+ platform_driver_unregister(&fsl_mc_bus_driver);
+ bus_unregister(&fsl_mc_bus_type);
+ kmem_cache_destroy(mc_dev_cache);
+ pr_info("MC bus unregistered\n");
+}
+
+module_exit(fsl_mc_bus_driver_exit);
+
+MODULE_AUTHOR("Freescale Semiconductor Inc.");
+MODULE_DESCRIPTION("Freescale Management Complex (MC) bus driver");
+MODULE_LICENSE("GPL");
diff --git a/include/linux/fsl/mc-private.h b/include/linux/fsl/mc-private.h
new file mode 100644
index 0000000..604832a
--- /dev/null
+++ b/include/linux/fsl/mc-private.h
@@ -0,0 +1,33 @@
+/*
+ * Freescale Management Complex (MC) bus private declarations
+ *
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ * Author: German Rivera <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+#ifndef _FSL_MC_PRIVATE_H_
+#define _FSL_MC_PRIVATE_H_
+
+#include <linux/fsl/mc.h>
+#include <linux/mutex.h>
+#include <linux/stringify.h>
+
+#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc) \
+ (strcmp((_mc_dev)->obj_desc.type, (_obj_desc)->type) == 0 && \
+ (_mc_dev)->obj_desc.id == (_obj_desc)->id)
+
+#define FSL_MC_IS_ALLOCATABLE(_obj_type) \
+ (strcmp(_obj_type, "dpbp") == 0 || \
+ strcmp(_obj_type, "dpcon") == 0)
+
+int __must_check fsl_mc_device_add(struct dprc_obj_desc *obj_desc,
+ struct fsl_mc_io *mc_io,
+ struct device *parent_dev,
+ struct fsl_mc_device **new_mc_dev);
+
+void fsl_mc_device_remove(struct fsl_mc_device *mc_dev);
+
+#endif /* _FSL_MC_PRIVATE_H_ */
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h
new file mode 100644
index 0000000..5d89d1bf
--- /dev/null
+++ b/include/linux/fsl/mc.h
@@ -0,0 +1,137 @@
+/*
+ * Freescale Management Complex (MC) bus public interface
+ *
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ * Author: German Rivera <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+#ifndef _FSL_MC_H_
+#define _FSL_MC_H_
+
+#include <linux/device.h>
+#include <linux/mod_devicetable.h>
+#include <linux/list.h>
+#include <linux/spinlock.h>
+#include <linux/fsl/dprc.h>
+
+#define FSL_MC_VENDOR_FREESCALE 0x1957
+
+struct fsl_mc_device;
+struct fsl_mc_io;
+
+/**
+ * struct fsl_mc_driver - MC object device driver object
+ * @driver: Generic device driver
+ * @match_id_table: table of supported device matching Ids
+ * @probe: Function called when a device is added
+ * @remove: Function called when a device is removed
+ * @shutdown: Function called at shutdown time to quiesce the device
+ * @suspend: Function called when a device is stopped
+ * @resume: Function called when a device is resumed
+ *
+ * Generic DPAA device driver object for device drivers that are registered
+ * with a DPRC bus. This structure is to be embedded in each device-specific
+ * driver structure.
+ */
+struct fsl_mc_driver {
+ struct device_driver driver;
+ const struct fsl_mc_device_match_id *match_id_table;
+ int (*probe)(struct fsl_mc_device *dev);
+ int (*remove)(struct fsl_mc_device *dev);
+ void (*shutdown)(struct fsl_mc_device *dev);
+ int (*suspend)(struct fsl_mc_device *dev, pm_message_t state);
+ int (*resume)(struct fsl_mc_device *dev);
+};
+
+#define to_fsl_mc_driver(_drv) \
+ container_of(_drv, struct fsl_mc_driver, driver)
+
+/**
+ * struct fsl_mc_device_match_id - MC object device Id entry for driver matching
+ * @vendor: vendor ID
+ * @obj_type: MC object type
+ * @ver_major: MC object version major number
+ * @ver_minor: MC object version minor number
+ *
+ * Type of entries in the "device Id" table for MC object devices supported by
+ * a MC object device driver. The last entry of the table has vendor set to 0x0
+ */
+struct fsl_mc_device_match_id {
+ uint16_t vendor;
+ const char obj_type[16];
+ uint32_t ver_major;
+ uint32_t ver_minor;
+};
+
+/**
+ * Bit masks for a MC object device (struct fsl_mc_device) flags
+ */
+#define FSL_MC_IS_DPRC 0x0001
+
+/**
+ * Default DMA mask for devices on a fsl-mc bus
+ */
+#define FSL_MC_DEFAULT_DMA_MASK (~0ULL)
+
+/**
+ * struct fsl_mc_device - MC object device object
+ * @dev: Linux driver model device object
+ * @dma_mask: Default DMA mask
+ * @flags: MC object device flags
+ * @icid: Isolation context ID for the device
+ * @mc_handle: MC handle for the corresponding MC object opened
+ * @mc_io: Pointer to MC IO object assigned to this device or
+ * NULL if none.
+ * @obj_desc: MC description of the DPAA device
+ * @regions: pointer to array of MMIO region entries
+ *
+ * Generic device object for MC object devices that are "attached" to a
+ * MC bus.
+ *
+ * NOTES:
+ * - For a non-DPRC object its icid is the same as its parent DPRC's icid.
+ * - The SMMU notifier callback gets invoked after device_add() has been
+ * called for an MC object device, but before the device-specific probe
+ * callback gets called.
+ */
+struct fsl_mc_device {
+ struct device dev;
+ uint64_t dma_mask;
+ uint16_t flags;
+ uint16_t icid;
+ uint16_t mc_handle;
+ struct fsl_mc_io *mc_io;
+ struct dprc_obj_desc obj_desc;
+ struct resource *regions;
+};
+
+#define to_fsl_mc_device(_dev) \
+ container_of(_dev, struct fsl_mc_device, dev)
+
+/*
+ * module_fsl_mc_driver() - Helper macro for drivers that don't do
+ * anything special in module init/exit. This eliminates a lot of
+ * boilerplate. Each module may only use this macro once, and
+ * calling it replaces module_init() and module_exit()
+ */
+#define module_fsl_mc_driver(__fsl_mc_driver) \
+ module_driver(__fsl_mc_driver, fsl_mc_driver_register, \
+ fsl_mc_driver_unregister)
+
+/*
+ * Macro to avoid include chaining to get THIS_MODULE
+ */
+#define fsl_mc_driver_register(drv) \
+ __fsl_mc_driver_register(drv, THIS_MODULE)
+
+int __must_check __fsl_mc_driver_register(struct fsl_mc_driver *fsl_mc_driver,
+ struct module *owner);
+
+void fsl_mc_driver_unregister(struct fsl_mc_driver *driver);
+
+extern struct bus_type fsl_mc_bus_type;
+
+#endif /* _FSL_MC_H_ */
--
1.7.9.7

2014-10-04 13:40:13

by J. German Rivera

[permalink] [raw]
Subject: [PATCH 3/3 v3] drivers/bus: Device driver for FSL-MC DPRC devices

From: "J. German Rivera" <[email protected]>

A DPRC (Data Path Resource Container) is an isolation device
that contains a set of DPAA networking devices to be
assigned to an isolation domain (e.g., a virtual machine).

Signed-off-by: J. German Rivera <[email protected]>
Signed-off-by: Stuart Yoder <[email protected]>
---
Changes in v3:
- Addressed comments from Kim Phillips:
* Renamed files:
drivers/bus/fsl-mc/fsl_mc_dprc.c -> drivers/bus/fsl-mc/dprc-driver.c

- Addressed comments from Timur Tabi:
* Changed dprc_scan_container() to just return dprc_scan_objects()
* Changed all functions that had goto out/error when no common cleanup
was done, to just have multiple return points.
* Replaced error cleanup boolean flags with multiple exit points.
* REmoved __must_chewck from dprc_scan_*() functions

Changes in v2:
- Addressed comments from Kim Phillips:
* Fix warning in drivers/bus/fsl-mc/fsl_mc_dprc.c:173
* Fixed linker errors when MC bus driver built as module

drivers/bus/fsl-mc/Makefile | 3 +-
drivers/bus/fsl-mc/dprc-driver.c | 383 ++++++++++++++++++++++++++++++++++++++
drivers/bus/fsl-mc/mc-bus.c | 8 +
include/linux/fsl/mc-private.h | 10 +
4 files changed, 403 insertions(+), 1 deletion(-)
create mode 100644 drivers/bus/fsl-mc/dprc-driver.c

diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
index decd339..424e58e 100644
--- a/drivers/bus/fsl-mc/Makefile
+++ b/drivers/bus/fsl-mc/Makefile
@@ -10,5 +10,6 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
mc-bus-driver-objs := mc-bus.o \
mc-sys.o \
dprc.o \
- dpmng.o
+ dpmng.o \
+ dprc-driver.o

diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
new file mode 100644
index 0000000..8be6a2a
--- /dev/null
+++ b/drivers/bus/fsl-mc/dprc-driver.c
@@ -0,0 +1,383 @@
+/*
+ * Freescale daata path resource container (DPRC) driver
+ *
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ * Author: German Rivera <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/fsl/mc-private.h>
+#include <linux/fsl/mc-sys.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include "dprc-cmd.h"
+
+struct dprc_child_objs {
+ int child_count;
+ struct dprc_obj_desc *child_array;
+};
+
+static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)
+{
+ int i;
+ struct dprc_child_objs *objs;
+ struct fsl_mc_device *mc_dev;
+
+ WARN_ON(dev == NULL);
+ WARN_ON(data == NULL);
+ mc_dev = to_fsl_mc_device(dev);
+ objs = data;
+
+ for (i = 0; i < objs->child_count; i++) {
+ struct dprc_obj_desc *obj_desc = &objs->child_array[i];
+
+ if (strlen(obj_desc->type) != 0 &&
+ FSL_MC_DEVICE_MATCH(mc_dev, obj_desc))
+ break;
+ }
+
+ if (i == objs->child_count)
+ fsl_mc_device_remove(mc_dev);
+
+ return 0;
+}
+
+static int __fsl_mc_device_remove(struct device *dev, void *data)
+{
+ WARN_ON(dev == NULL);
+ WARN_ON(data != NULL);
+ fsl_mc_device_remove(to_fsl_mc_device(dev));
+ return 0;
+}
+
+/**
+ * dprc_remove_devices - Removes devices for objects removed from a DPRC
+ *
+ * @mc_bus_dev: pointer to the fsl-mc device that represents a DPRC object
+ * @obj_desc_array: array of object descriptors for child objects currently
+ * present in the DPRC in the MC.
+ * @num_child_objects_in_mc: number of entries in obj_desc_array
+ *
+ * Synchronizes the state of the Linux bus driver with the actual state of
+ * the MC by removing devices that represent MC objects that have
+ * been dynamically removed in the physical DPRC.
+ */
+static void dprc_remove_devices(struct fsl_mc_device *mc_bus_dev,
+ struct dprc_obj_desc *obj_desc_array,
+ int num_child_objects_in_mc)
+{
+ if (num_child_objects_in_mc != 0) {
+ /*
+ * Remove child objects that are in the DPRC in Linux,
+ * but not in the MC:
+ */
+ struct dprc_child_objs objs;
+
+ objs.child_count = num_child_objects_in_mc;
+ objs.child_array = obj_desc_array;
+ device_for_each_child(&mc_bus_dev->dev, &objs,
+ __fsl_mc_device_remove_if_not_in_mc);
+ } else {
+ /*
+ * There are no child objects for this DPRC in the MC.
+ * So, remove all the child devices from Linux:
+ */
+ device_for_each_child(&mc_bus_dev->dev, NULL,
+ __fsl_mc_device_remove);
+ }
+}
+
+static int __fsl_mc_device_match(struct device *dev, void *data)
+{
+ struct dprc_obj_desc *obj_desc = data;
+ struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
+
+ return FSL_MC_DEVICE_MATCH(mc_dev, obj_desc);
+}
+
+static struct fsl_mc_device *fsl_mc_device_lookup(struct dprc_obj_desc
+ *obj_desc,
+ struct fsl_mc_device
+ *mc_bus_dev)
+{
+ struct device *dev;
+
+ dev = device_find_child(&mc_bus_dev->dev, obj_desc,
+ __fsl_mc_device_match);
+
+ return (dev != NULL) ? to_fsl_mc_device(dev) : NULL;
+}
+
+/**
+ * dprc_add_new_devices - Adds devices to the logical bus for a DPRC
+ *
+ * @mc_bus_dev: pointer to the fsl-mc device that represents a DPRC object
+ * @obj_desc_array: array of device descriptors for child devices currently
+ * present in the physical DPRC.
+ * @num_child_objects_in_mc: number of entries in obj_desc_array
+ *
+ * Synchronizes the state of the Linux bus driver with the actual
+ * state of the MC by adding objects that have been newly discovered
+ * in the physical DPRC.
+ */
+static void dprc_add_new_devices(struct fsl_mc_device *mc_bus_dev,
+ struct dprc_obj_desc *obj_desc_array,
+ int num_child_objects_in_mc)
+{
+ int error;
+ int i;
+
+ for (i = 0; i < num_child_objects_in_mc; i++) {
+ struct dprc_region_desc region_desc;
+ struct fsl_mc_device *child_dev;
+ struct fsl_mc_io *mc_io = NULL;
+ struct dprc_obj_desc *obj_desc = &obj_desc_array[i];
+
+ if (strlen(obj_desc->type) == 0)
+ continue;
+ /*
+ * Check if device is already known to Linux:
+ */
+ child_dev = fsl_mc_device_lookup(obj_desc, mc_bus_dev);
+ if (child_dev != NULL)
+ continue;
+
+ if (strcmp(obj_desc->type, "dprc") == 0) {
+ /*
+ * Get the MC portal physical address for the device
+ * (specified in the device's first MMIO region):
+ */
+ if (WARN_ON(obj_desc->region_count == 0))
+ continue;
+
+ error = dprc_get_obj_region(mc_bus_dev->mc_io,
+ mc_bus_dev->mc_handle,
+ obj_desc->type,
+ obj_desc->id,
+ 0, &region_desc);
+ if (error < 0) {
+ dev_err(&mc_bus_dev->dev,
+ "dprc_get_obj_region() failed: %d\n",
+ error);
+ continue;
+ }
+
+ if (region_desc.size !=
+ mc_bus_dev->mc_io->portal_size) {
+ error = -EINVAL;
+ dev_err(&mc_bus_dev->dev,
+ "Invalid MC portal size: %u\n",
+ region_desc.size);
+ continue;
+ }
+
+ error = fsl_create_mc_io(&mc_bus_dev->dev,
+ region_desc.base_paddr,
+ region_desc.size, 0, &mc_io);
+ if (error < 0)
+ continue;
+ }
+
+ error = fsl_mc_device_add(obj_desc, mc_io, &mc_bus_dev->dev,
+ &child_dev);
+ if (error < 0) {
+ if (mc_io != NULL)
+ fsl_destroy_mc_io(mc_io);
+
+ continue;
+ }
+ }
+}
+
+/**
+ * dprc_scan_objects - Discover objects in a DPRC
+ *
+ * @mc_bus_dev: pointer to the fsl-mc device that represents a DPRC object
+ *
+ * Detects objects added and removed from a DPRC and synchronizes the
+ * state of the Linux bus driver, MC by adding and removing
+ * devices accordingly.
+ */
+int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev)
+{
+ int num_child_objects;
+ int dprc_get_obj_failures;
+ int error;
+ struct dprc_obj_desc *child_obj_desc_array = NULL;
+
+ error = dprc_get_obj_count(mc_bus_dev->mc_io,
+ mc_bus_dev->mc_handle,
+ &num_child_objects);
+ if (error < 0) {
+ dev_err(&mc_bus_dev->dev, "dprc_get_obj_count() failed: %d\n",
+ error);
+ return error;
+ }
+
+ if (num_child_objects != 0) {
+ int i;
+
+ child_obj_desc_array =
+ devm_kmalloc_array(&mc_bus_dev->dev, num_child_objects,
+ sizeof(*child_obj_desc_array),
+ GFP_KERNEL);
+ if (child_obj_desc_array == NULL)
+ return -ENOMEM;
+
+ /*
+ * Discover objects currently present in the physical DPRC:
+ */
+ dprc_get_obj_failures = 0;
+ for (i = 0; i < num_child_objects; i++) {
+ struct dprc_obj_desc *obj_desc =
+ &child_obj_desc_array[i];
+
+ error = dprc_get_obj(mc_bus_dev->mc_io,
+ mc_bus_dev->mc_handle,
+ i, obj_desc);
+ if (error < 0) {
+ dev_err(&mc_bus_dev->dev,
+ "dprc_get_obj(i=%d) failed: %d\n",
+ i, error);
+ /*
+ * Mark the obj entry as "invalid", by using the
+ * empty string as obj type:
+ */
+ obj_desc->type[0] = '\0';
+ obj_desc->id = error;
+ dprc_get_obj_failures++;
+ continue;
+ }
+
+ dev_info(&mc_bus_dev->dev,
+ "Discovered object: type %s, id %d\n",
+ obj_desc->type, obj_desc->id);
+ }
+
+ if (dprc_get_obj_failures != 0) {
+ dev_err(&mc_bus_dev->dev,
+ "%d out of %d devices could not be retrieved\n",
+ dprc_get_obj_failures, num_child_objects);
+ }
+ }
+
+ dprc_remove_devices(mc_bus_dev, child_obj_desc_array,
+ num_child_objects);
+
+ dprc_add_new_devices(mc_bus_dev, child_obj_desc_array,
+ num_child_objects);
+
+ if (child_obj_desc_array != NULL)
+ devm_kfree(&mc_bus_dev->dev, child_obj_desc_array);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(dprc_scan_objects);
+
+/**
+ * dprc_scan_container - Scans a physical DPRC and synchronizes Linux bus state
+ *
+ * @mc_bus_dev: pointer to the fsl-mc device that represents a DPRC object
+ *
+ * Scans the physical DPRC and synchronizes the state of the Linux
+ * bus driver with the actual state of the MC by adding and removing
+ * devices as appropriate.
+ */
+int dprc_scan_container(struct fsl_mc_device *mc_bus_dev)
+{
+ return dprc_scan_objects(mc_bus_dev);
+}
+EXPORT_SYMBOL_GPL(dprc_scan_container);
+
+/**
+ * dprc_probe - callback invoked when a DPRC is being bound to this driver
+ *
+ * @mc_dev: Pointer to fsl-mc device representing a DPRC
+ *
+ * It opens the physical DPRC in the MC.
+ * It scans the DPRC to discover the MC objects contained in it.
+ */
+static int dprc_probe(struct fsl_mc_device *mc_dev)
+{
+ int error;
+
+ if (WARN_ON(strcmp(mc_dev->obj_desc.type, "dprc") != 0))
+ return -EINVAL;
+
+ error = dprc_open(mc_dev->mc_io, mc_dev->obj_desc.id,
+ &mc_dev->mc_handle);
+ if (error < 0) {
+ dev_err(&mc_dev->dev, "dprc_open() failed: %d\n", error);
+ return error;
+ }
+
+ error = dprc_scan_container(mc_dev);
+ if (error < 0)
+ goto error_cleanup_open;
+
+ dev_info(&mc_dev->dev, "DPRC device bound to driver");
+ return 0;
+
+error_cleanup_open:
+ (void)dprc_close(mc_dev->mc_io, mc_dev->mc_handle);
+ return error;
+}
+
+/**
+ * dprc_remove - callback invoked when a DPRC is being unbound from this driver
+ *
+ * @mc_dev: Pointer to fsl-mc device representing the DPRC
+ *
+ * It removes the DPRC's child objects from Linux (not from the MC) and
+ * closes the DPRC device in the MC.
+ */
+static int dprc_remove(struct fsl_mc_device *mc_dev)
+{
+ int error;
+
+ if (WARN_ON(strcmp(mc_dev->obj_desc.type, "dprc") != 0))
+ return -EINVAL;
+ if (WARN_ON(mc_dev->mc_io == NULL))
+ return -EINVAL;
+
+ device_for_each_child(&mc_dev->dev, NULL, __fsl_mc_device_remove);
+ error = dprc_close(mc_dev->mc_io, mc_dev->mc_handle);
+ if (error < 0)
+ dev_err(&mc_dev->dev, "dprc_close() failed: %d\n", error);
+
+ dev_info(&mc_dev->dev, "DPRC device unbound from driver");
+ return 0;
+}
+
+static const struct fsl_mc_device_match_id match_id_table[] = {
+ {
+ .vendor = FSL_MC_VENDOR_FREESCALE,
+ .obj_type = "dprc",
+ .ver_major = DPRC_VER_MAJOR,
+ .ver_minor = DPRC_VER_MINOR},
+ {.vendor = 0x0},
+};
+
+static struct fsl_mc_driver dprc_driver = {
+ .driver = {
+ .name = FSL_MC_DPRC_DRIVER_NAME,
+ .owner = THIS_MODULE,
+ .pm = NULL,
+ },
+ .match_id_table = match_id_table,
+ .probe = dprc_probe,
+ .remove = dprc_remove,
+};
+
+int __init dprc_driver_init(void)
+{
+ return fsl_mc_driver_register(&dprc_driver);
+}
+
+void __exit dprc_driver_exit(void)
+{
+ fsl_mc_driver_unregister(&dprc_driver);
+}
diff --git a/drivers/bus/fsl-mc/mc-bus.c b/drivers/bus/fsl-mc/mc-bus.c
index d19fb18..79e5ad8 100644
--- a/drivers/bus/fsl-mc/mc-bus.c
+++ b/drivers/bus/fsl-mc/mc-bus.c
@@ -536,8 +536,15 @@ static int __init fsl_mc_bus_driver_init(void)
goto error_cleanup_bus;
}

+ error = dprc_driver_init();
+ if (error < 0)
+ goto error_cleanup_driver;
+
return 0;

+error_cleanup_driver:
+ platform_driver_unregister(&fsl_mc_bus_driver);
+
error_cleanup_bus:
bus_unregister(&fsl_mc_bus_type);

@@ -553,6 +560,7 @@ static void __exit fsl_mc_bus_driver_exit(void)
if (WARN_ON(mc_dev_cache == NULL))
return;

+ dprc_driver_exit();
platform_driver_unregister(&fsl_mc_bus_driver);
bus_unregister(&fsl_mc_bus_type);
kmem_cache_destroy(mc_dev_cache);
diff --git a/include/linux/fsl/mc-private.h b/include/linux/fsl/mc-private.h
index 604832a..431a0b1 100644
--- a/include/linux/fsl/mc-private.h
+++ b/include/linux/fsl/mc-private.h
@@ -15,6 +15,8 @@
#include <linux/mutex.h>
#include <linux/stringify.h>

+#define FSL_MC_DPRC_DRIVER_NAME "fsl_mc_dprc"
+
#define FSL_MC_DEVICE_MATCH(_mc_dev, _obj_desc) \
(strcmp((_mc_dev)->obj_desc.type, (_obj_desc)->type) == 0 && \
(_mc_dev)->obj_desc.id == (_obj_desc)->id)
@@ -30,4 +32,12 @@ int __must_check fsl_mc_device_add(struct dprc_obj_desc *obj_desc,

void fsl_mc_device_remove(struct fsl_mc_device *mc_dev);

+int dprc_scan_container(struct fsl_mc_device *mc_bus_dev);
+
+int dprc_scan_objects(struct fsl_mc_device *mc_bus_dev);
+
+int __init dprc_driver_init(void);
+
+void __exit dprc_driver_exit(void);
+
#endif /* _FSL_MC_PRIVATE_H_ */
--
1.7.9.7

2014-10-05 14:53:27

by Timur Tabi

[permalink] [raw]
Subject: Re: [PATCH 3/3 v3] drivers/bus: Device driver for FSL-MC DPRC devices

On Sat, Oct 4, 2014 at 8:23 AM, J. German Rivera
<[email protected]> wrote:
> +EXPORT_SYMBOL_GPL(dprc_scan_objects);

I didn't notice this earlier, but I it was Freescale policy to use
EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL(). Has that changed?

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

2014-10-06 14:49:13

by J. German Rivera

[permalink] [raw]
Subject: Re: [PATCH 3/3 v3] drivers/bus: Device driver for FSL-MC DPRC devices


On 10/05/2014 09:53 AM, Timur Tabi wrote:
> On Sat, Oct 4, 2014 at 8:23 AM, J. German Rivera
> <[email protected]> wrote:
>> +EXPORT_SYMBOL_GPL(dprc_scan_objects);
>
> I didn't notice this earlier, but I it was Freescale policy to use
> EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL(). Has that changed?
>
Please see change history in the cover letter for this patch series.

Thanks,

German

2014-11-06 13:50:08

by Alexander Graf

[permalink] [raw]
Subject: Re: [PATCH 1/3 v3] drivers/bus: Added Freescale Management Complex APIs



On 04.10.14 15:23, J. German Rivera wrote:
> From: "J. German Rivera" <[email protected]>
>
> APIs to access the Management Complex (MC) hardware
> module of Freescale LS2 SoCs. This patch includes
> APIs to check the MC firmware version and to manipulate
> DPRC objects in the MC.
>
> Signed-off-by: J. German Rivera <[email protected]>
> Signed-off-by: Stuart Yoder <[email protected]>
> ---
> Changes in v3:
> - Addressed comment from Greg Kroah-Hartman:
> * Removed doxygen comments
>
> - Addressed comment from Scott Wood:
> * Replaced udelay() call with usleep_range() call in polling loop
> - Addressed comments from Kim Phillips:
> * Fixed license text in all files
> * Renamed files:
> drivers/bus/fsl-mc/fsl_dpmng_cmd.h -> drivers/bus/fsl-mc/dpmng-cmd.h
> drivers/bus/fsl-mc/fsl_dprc_cmd.h -> drivers/bus/fsl-mc/dprc-cmd.h
> drivers/bus/fsl-mc/fsl_mc_sys.c -> drivers/bus/fsl-mc/mc-sys.c
> include/linux/fsl_dpmng.h -> include/linux/fsl/dpmng.h
> include/linux/fsl_dprc.h -> include/linux/fsl/dprc.h
> include/linux/fsl_mc_cmd.h -> include/linux/fsl/mc-cmd.h
> include/linux/fsl_mc_sys.h -> include/linux/fsl/mc-sys.h
> * Changed dpmng_load_iop() to take the DMA address directly,
> instead of the image virtual address.
> * Removed if and WARN_ON that checks for NULL fsl_destroy_mc_io()
> * Removed locking from mc_send_command(). Now the caller of MC flib
> APIs is responsible for protecting concurrent accesses to the same
> MC portal.
>
> Changes in v2:
> - Addressed comment from Joe Perches:
> * Refactored logic to actively fail on err and proceed at
> the same indent level on success, for all functions in dprc.c
> and dpmng.c.
>
> - Addressed comments from Kim Phillips:
> * Fixed warning in mc_send_command
> * Changed serialization logic in mc_send_command() to only use
> spinlock_irqsave() when both threads and interrupt handlers
> concurrently access the same portal.
> * Changed switch to lookup table in mc_status_to_error()
> * Removed macros iowrite64(), ioread64(), ENOTSUP from fsl_mc_sys.h
> * Removed #ifdef side for FSL_MC_FIRMWARE in fsl_mc_cmd.h
> * Changed non-devm_ API calls to devm_ API calls and refactored
> fsl_create_mc_io()/fsl_destroy_mc_io() to simplify cleanup logic.
>
> - Addressed comments from Scott Wood:
> * Return -ENXIO instead of -EFAULT when ioremap_nocache() fails
>
> - Addressed comments from Alex Graf:
> * Added MAINTAINERS file entries for new files
> * Added dev param to fsl_create_mc_io(), to enable the use
> of devm_ APIs in this function and fsl_destroy_mc_io().
> * Changed the value of the timeout for MC command completion
> to be a function of HZ instead of a hard-coded jiffies value.
>
> MAINTAINERS | 8 +
> drivers/bus/fsl-mc/dpmng-cmd.h | 83 +++++
> drivers/bus/fsl-mc/dpmng.c | 94 +++++
> drivers/bus/fsl-mc/dprc-cmd.h | 545 +++++++++++++++++++++++++++
> drivers/bus/fsl-mc/dprc.c | 521 ++++++++++++++++++++++++++
> drivers/bus/fsl-mc/mc-sys.c | 189 ++++++++++
> include/linux/fsl/dpmng.h | 121 ++++++
> include/linux/fsl/dprc.h | 791 ++++++++++++++++++++++++++++++++++++++++
> include/linux/fsl/mc-cmd.h | 169 +++++++++
> include/linux/fsl/mc-sys.h | 68 ++++
> 10 files changed, 2589 insertions(+)
> create mode 100644 drivers/bus/fsl-mc/dpmng-cmd.h
> create mode 100644 drivers/bus/fsl-mc/dpmng.c
> create mode 100644 drivers/bus/fsl-mc/dprc-cmd.h
> create mode 100644 drivers/bus/fsl-mc/dprc.c
> create mode 100644 drivers/bus/fsl-mc/mc-sys.c
> create mode 100644 include/linux/fsl/dpmng.h
> create mode 100644 include/linux/fsl/dprc.h
> create mode 100644 include/linux/fsl/mc-cmd.h
> create mode 100644 include/linux/fsl/mc-sys.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8fd05d4..907b50d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3874,6 +3874,14 @@ F: sound/soc/fsl/fsl*
> F: sound/soc/fsl/imx*
> F: sound/soc/fsl/mpc8610_hpcd.c
>
> +FREESCALE QORIQ MANAGEMENT COMPLEX DRIVER
> +M: J. German Rivera <[email protected]>
> +L: [email protected]
> +S: Maintained
> +F: include/linux/fsl_mc*
> +F: include/linux/fsl_dp*
> +F: drivers/bus/fsl-mc/*
> +
> FREEVXFS FILESYSTEM
> M: Christoph Hellwig <[email protected]>
> W: ftp://ftp.openlinux.org/pub/people/hch/vxfs
> diff --git a/drivers/bus/fsl-mc/dpmng-cmd.h b/drivers/bus/fsl-mc/dpmng-cmd.h
> new file mode 100644
> index 0000000..cdeaa16
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/dpmng-cmd.h
> @@ -0,0 +1,83 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +/*************************************************************************//*
> + dpmng-cmd.h
> +
> + defines portal commands
> +
> + *//**************************************************************************/
> +
> +#ifndef __FSL_DPMNG_CMD_H
> +#define __FSL_DPMNG_CMD_H
> +
> +/* Command IDs */
> +#define DPMNG_CMDID_GET_VERSION 0x831
> +#define DPMNG_CMDID_RESET_AIOP 0x832
> +#define DPMNG_CMDID_LOAD_AIOP 0x833
> +#define DPMNG_CMDID_RUN_AIOP 0x834
> +
> +/* Command sizes */
> +#define DPMNG_CMDSZ_GET_VERSION (8 * 2)
> +#define DPMNG_CMDSZ_RESET_AIOP 8
> +#define DPMNG_CMDSZ_LOAD_AIOP (8 * 2)
> +#define DPMNG_CMDSZ_RUN_AIOP (8 * 2)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPMNG_RSP_GET_VERSION(cmd, mc_ver_info) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, mc_ver_info->revision);\
> + MC_RSP_PARAM_OP(cmd, 0, 32, 32, uint32_t, mc_ver_info->major); \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 8, uint32_t, mc_ver_info->minor); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPMNG_CMD_RESET_AIOP(cmd, aiop_tile_id) \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, aiop_tile_id)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPMNG_CMD_LOAD_AIOP(cmd, aiop_tile_id, img_size, img_paddr) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, aiop_tile_id); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 32, int, img_size); \
> + MC_CMD_PARAM_OP(cmd, 1, 0, 64, uint64_t, img_paddr); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPMNG_CMD_RUN_AIOP(cmd, aiop_tile_id, cores_mask, options) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, aiop_tile_id); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 32, uint32_t, cores_mask); \
> + MC_CMD_PARAM_OP(cmd, 1, 0, 64, uint64_t, options); \
> +} while (0)
> +
> +#endif /* __FSL_DPMNG_CMD_H */
> diff --git a/drivers/bus/fsl-mc/dpmng.c b/drivers/bus/fsl-mc/dpmng.c
> new file mode 100644
> index 0000000..8a32448
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/dpmng.c
> @@ -0,0 +1,94 @@

I don't think it's extremely obvious what "dpmng" means, so having some
description at the head of the file makes things a lot easier to understand.

This obviously applies to all files, not just this one ;).

> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include <linux/fsl/mc-sys.h>
> +#include <linux/fsl/mc-cmd.h>
> +#include <linux/fsl/dpmng.h>
> +#include "dpmng-cmd.h"
> +
> +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPMNG_CMDID_GET_VERSION,
> + DPMNG_CMDSZ_GET_VERSION,
> + MC_CMD_PRI_LOW, 0);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPMNG_RSP_GET_VERSION(cmd, mc_ver_info);

Sorry if this came up before, but you have all these nicely abstracted
helper functions (like mc_get_version()) to encapsulate command
submission. Why do you need to call yet another macro inside of it to
extract all of the fields?

I would find a simple

mc_ver_info->revision = u64_dec(cmd.params[0], 0, 32);
mc_ver_info->major = u64_dec(cmd.params[0], 32, 32);
mc_ver_info->minor = u64_dec(cmd.params[1], 0, 8);

right here a lot more easy to understand.

> + return 0;
> +}
> +
> +int dpmng_reset_aiop(struct fsl_mc_io *mc_io, int aiop_tile_id)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPMNG_CMDID_RESET_AIOP,
> + DPMNG_CMDSZ_RESET_AIOP,
> + MC_CMD_PRI_LOW, 0);
> +
> + DPMNG_CMD_RESET_AIOP(cmd, aiop_tile_id);

The same goes here. Imagine this would be

cmd.params[0] |= u64_enc(0, 32, aiop_tile_id);

then it would be immediately clear that we're modifying the parameters
for cmd. With the macro as is, the occasional reader would have no idea
what fields are different from before after the call.

I think if you do this for all the functions in the patch, you will see
that the code will suddenly become crystal clear to read.

> +
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dpmng_load_aiop(struct fsl_mc_io *mc_io,
> + int aiop_tile_id, dma_addr_t img_dma_addr, int img_size)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPMNG_CMDID_LOAD_AIOP,
> + DPMNG_CMDSZ_LOAD_AIOP,
> + MC_CMD_PRI_LOW, 0);
> +
> + DPMNG_CMD_LOAD_AIOP(cmd, aiop_tile_id, img_size, img_dma_addr);
> +
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dpmng_run_aiop(struct fsl_mc_io *mc_io,
> + int aiop_tile_id, uint32_t cores_mask, uint64_t options)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPMNG_CMDID_RUN_AIOP,
> + DPMNG_CMDSZ_RUN_AIOP,
> + MC_CMD_PRI_LOW, 0);
> +
> + DPMNG_CMD_RUN_AIOP(cmd, aiop_tile_id, cores_mask, options);
> +
> + return mc_send_command(mc_io, &cmd);
> +}
> diff --git a/drivers/bus/fsl-mc/dprc-cmd.h b/drivers/bus/fsl-mc/dprc-cmd.h
> new file mode 100644
> index 0000000..0ce3ada
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/dprc-cmd.h
> @@ -0,0 +1,545 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +/*************************************************************************//*
> + dprc-cmd.h
> +
> + defines dprc portal commands
> +
> + *//**************************************************************************/
> +
> +#ifndef _FSL_DPRC_CMD_H
> +#define _FSL_DPRC_CMD_H
> +
> +/* DPRC Version */
> +#define DPRC_VER_MAJOR 1
> +#define DPRC_VER_MINOR 0
> +
> +/* Command IDs */
> +#define MC_CMDID_CLOSE 0x800
> +#define MC_DPRC_CMDID_OPEN 0x805
> +#define MC_DPRC_CMDID_CREATE 0x905
> +
> +#define DPRC_CMDID_CREATE_CONT 0x151
> +#define DPRC_CMDID_DESTROY_CONT 0x152
> +#define DPRC_CMDID_GET_CONT_ID 0x830
> +#define DPRC_CMDID_RESET_CONT 0x154
> +#define DPRC_CMDID_SET_RES_QUOTA 0x155
> +#define DPRC_CMDID_GET_RES_QUOTA 0x156
> +#define DPRC_CMDID_ASSIGN 0x157
> +#define DPRC_CMDID_UNASSIGN 0x158
> +#define DPRC_CMDID_GET_OBJ_COUNT 0x159
> +#define DPRC_CMDID_GET_OBJECT 0x15A
> +#define DPRC_CMDID_GET_RES_COUNT 0x15B
> +#define DPRC_CMDID_GET_RES_IDS 0x15C
> +#define DPRC_CMDID_GET_ATTR 0x15D
> +#define DPRC_CMDID_GET_OBJ_REG 0x15E
> +#define DPRC_CMDID_SET_IRQ 0x15F
> +#define DPRC_CMDID_GET_IRQ 0x160
> +#define DPRC_CMDID_SET_IRQ_ENABLE 0x161
> +#define DPRC_CMDID_GET_IRQ_ENABLE 0x162
> +#define DPRC_CMDID_SET_IRQ_MASK 0x163
> +#define DPRC_CMDID_GET_IRQ_MASK 0x164
> +#define DPRC_CMDID_GET_IRQ_STATUS 0x165
> +#define DPRC_CMDID_CLEAR_IRQ_STATUS 0x166
> +#define DPRC_CMDID_CONNECT 0x167
> +#define DPRC_CMDID_DISCONNECT 0x168
> +#define DPRC_CMDID_GET_POOL 0x169
> +#define DPRC_CMDID_GET_POOL_COUNT 0x16A
> +#define DPRC_CMDID_GET_PORTAL_PADDR 0x16B
> +
> +/* Command sizes */
> +#define MC_CMD_OPEN_SIZE 8
> +#define MC_CMD_CLOSE_SIZE 0
> +#define DPRC_CMDSZ_CREATE_CONT (8 * 2)
> +#define DPRC_CMDSZ_DESTROY_CONT 8
> +#define DPRC_CMDSZ_GET_CONT_ID 8
> +#define DPRC_CMDSZ_RESET_CONT 8
> +#define DPRC_CMDSZ_SET_RES_QUOTA (8 * 3)
> +#define DPRC_CMDSZ_GET_RES_QUOTA (8 * 3)
> +#define DPRC_CMDSZ_ASSIGN (8 * 4)
> +#define DPRC_CMDSZ_UNASSIGN (8 * 4)
> +#define DPRC_CMDSZ_GET_OBJ_COUNT 0
> +#define DPRC_CMDSZ_GET_OBJECT (8 * 5)
> +#define DPRC_CMDSZ_GET_RES_COUNT 8
> +#define DPRC_CMDSZ_GET_RES_IDS (8 * 4)
> +#define DPRC_CMDSZ_GET_ATTR (8 * 3)
> +#define DPRC_CMDSZ_GET_OBJ_REG (8 * 5)
> +#define DPRC_CMDSZ_SET_IRQ (8 * 3)
> +#define DPRC_CMDSZ_GET_IRQ (8 * 3)
> +#define DPRC_CMDSZ_SET_IRQ_ENABLE 8
> +#define DPRC_CMDSZ_GET_IRQ_ENABLE 8
> +#define DPRC_CMDSZ_SET_IRQ_MASK 8
> +#define DPRC_CMDSZ_GET_IRQ_MASK 8
> +#define DPRC_CMDSZ_GET_IRQ_STATUS 8
> +#define DPRC_CMDSZ_CLEAR_IRQ_STATUS 8
> +#define DPRC_CMDSZ_CONNECT (8 * 7)
> +#define DPRC_CMDSZ_DISCONNECT (8 * 3)
> +#define DPRC_CMDSZ_GET_POOL (8 * 3)
> +#define DPRC_CMDSZ_GET_POOL_COUNT 8
> +#define DPRC_CMDSZ_GET_PORTAL_PADDR (8 * 2)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_OPEN(cmd, container_id) \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, container_id)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_CONTAINER_ID(cmd, container_id) \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, container_id)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_CREATE_CONTAINER(cmd, cfg) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 16, uint16_t, cfg->icid); \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, cfg->options); \
> + MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, cfg->portal_id); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_CREATE_CONTAINER(cmd, child_container_id, child_portal_paddr) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 32, int, child_container_id); \
> + MC_RSP_PARAM_OP(cmd, 2, 0, 64, uint64_t, child_portal_paddr); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_DESTROY_CONTAINER(cmd, child_container_id) \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_RESET_CONTAINER(cmd, child_container_id) \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_SET_RES_QUOTA(cmd, child_container_id, type, quota) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 16, uint16_t, quota);\
> + MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
> + MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
> + MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
> + MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
> + MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
> + MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
> + MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
> + MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_RES_QUOTA(cmd, child_container_id, type) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id); \
> + MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
> + MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
> + MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
> + MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
> + MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
> + MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
> + MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
> + MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_RES_QUOTA(cmd, quota) \
> + MC_RSP_PARAM_OP(cmd, 0, 32, 16, uint16_t, quota)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_ASSIGN(cmd, container_id, res_req) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, container_id); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 32, uint32_t, res_req->options);\
> + MC_CMD_PARAM_OP(cmd, 1, 0, 32, uint32_t, res_req->num); \
> + MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, res_req->id_base_align); \
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, res_req->type[0]);\
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, res_req->type[1]);\
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, res_req->type[2]);\
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, res_req->type[3]);\
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, res_req->type[4]);\
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, res_req->type[5]);\
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, res_req->type[6]);\
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, res_req->type[7]);\
> + MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, res_req->type[8]);\
> + MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, res_req->type[9]);\
> + MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, res_req->type[10]);\
> + MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, res_req->type[11]);\
> + MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, res_req->type[12]);\
> + MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, res_req->type[13]);\
> + MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, res_req->type[14]);\
> + MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, res_req->type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_UNASSIGN(cmd, child_container_id, res_req) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, child_container_id); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 32, uint32_t, res_req->options);\
> + MC_CMD_PARAM_OP(cmd, 1, 0, 32, uint32_t, res_req->num); \
> + MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, res_req->id_base_align); \
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, res_req->type[0]);\
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, res_req->type[1]);\
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, res_req->type[2]);\
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, res_req->type[3]);\
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, res_req->type[4]);\
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, res_req->type[5]);\
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, res_req->type[6]);\
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, res_req->type[7]);\
> + MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, res_req->type[8]);\
> + MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, res_req->type[9]);\
> + MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, res_req->type[10]);\
> + MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, res_req->type[11]);\
> + MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, res_req->type[12]);\
> + MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, res_req->type[13]);\
> + MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, res_req->type[14]);\
> + MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, res_req->type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_OBJ_COUNT(cmd, obj_count) \
> + MC_RSP_PARAM_OP(cmd, 0, 32, 32, int, obj_count)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_OBJECT(cmd, obj_index) \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, obj_index)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_OBJECT(cmd, obj_desc) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 0, 32, 32, int, obj_desc->id); \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 16, uint16_t, obj_desc->vendor); \
> + MC_RSP_PARAM_OP(cmd, 1, 16, 8, uint8_t, obj_desc->irq_count); \
> + MC_RSP_PARAM_OP(cmd, 1, 24, 8, uint8_t, obj_desc->region_count); \
> + MC_RSP_PARAM_OP(cmd, 1, 32, 32, uint32_t, obj_desc->state);\
> + MC_RSP_PARAM_OP(cmd, 2, 0, 32, uint32_t, obj_desc->ver_minor); \
> + MC_RSP_PARAM_OP(cmd, 2, 32, 32, uint32_t, obj_desc->ver_major); \
> + MC_RSP_PARAM_OP(cmd, 3, 0, 8, char, obj_desc->type[0]);\
> + MC_RSP_PARAM_OP(cmd, 3, 8, 8, char, obj_desc->type[1]);\
> + MC_RSP_PARAM_OP(cmd, 3, 16, 8, char, obj_desc->type[2]);\
> + MC_RSP_PARAM_OP(cmd, 3, 24, 8, char, obj_desc->type[3]);\
> + MC_RSP_PARAM_OP(cmd, 3, 32, 8, char, obj_desc->type[4]);\
> + MC_RSP_PARAM_OP(cmd, 3, 40, 8, char, obj_desc->type[5]);\
> + MC_RSP_PARAM_OP(cmd, 3, 48, 8, char, obj_desc->type[6]);\
> + MC_RSP_PARAM_OP(cmd, 3, 56, 8, char, obj_desc->type[7]);\
> + MC_RSP_PARAM_OP(cmd, 4, 0, 8, char, obj_desc->type[8]);\
> + MC_RSP_PARAM_OP(cmd, 4, 8, 8, char, obj_desc->type[9]);\
> + MC_RSP_PARAM_OP(cmd, 4, 16, 8, char, obj_desc->type[10]);\
> + MC_RSP_PARAM_OP(cmd, 4, 24, 8, char, obj_desc->type[11]);\
> + MC_RSP_PARAM_OP(cmd, 4, 32, 8, char, obj_desc->type[12]);\
> + MC_RSP_PARAM_OP(cmd, 4, 40, 8, char, obj_desc->type[13]);\
> + MC_RSP_PARAM_OP(cmd, 4, 48, 8, char, obj_desc->type[14]);\
> + MC_RSP_PARAM_OP(cmd, 4, 56, 8, char, obj_desc->type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_RES_COUNT(cmd, type) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
> + MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
> + MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
> + MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
> + MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
> + MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
> + MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
> + MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_RES_COUNT(cmd, res_count) \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, res_count)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_RES_IDS(cmd, type, range_desc) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 42, 7, enum dprc_iter_status, \
> + range_desc->iter_status);\
> + MC_CMD_PARAM_OP(cmd, 1, 0, 32, int, range_desc->base_id); \
> + MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, range_desc->last_id);\
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, type[0]);\
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, type[1]);\
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, type[2]);\
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, type[3]);\
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, type[4]);\
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, type[5]);\
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, type[6]);\
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, type[7]);\
> + MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, type[8]);\
> + MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, type[9]);\
> + MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, type[10]);\
> + MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, type[11]);\
> + MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, type[12]);\
> + MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, type[13]);\
> + MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, type[14]);\
> + MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_RES_IDS(cmd, range_desc) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 0, 42, 7, enum dprc_iter_status, \
> + range_desc->iter_status);\
> + MC_RSP_PARAM_OP(cmd, 1, 0, 32, int, range_desc->base_id); \
> + MC_RSP_PARAM_OP(cmd, 1, 32, 32, int, range_desc->last_id);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_ATTRIBUTES(cmd, attr) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, attr->container_id); \
> + MC_RSP_PARAM_OP(cmd, 0, 32, 16, uint16_t, attr->icid); \
> + MC_RSP_PARAM_OP(cmd, 0, 48, 16, uint16_t, attr->portal_id); \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 32, uint32_t, attr->options);\
> + MC_RSP_PARAM_OP(cmd, 2, 0, 32, uint32_t, attr->version.major);\
> + MC_RSP_PARAM_OP(cmd, 2, 32, 32, uint32_t, attr->version.minor);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_OBJ_REGION(cmd, obj_id, region_index, obj_type) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, obj_id); \
> + MC_CMD_PARAM_OP(cmd, 0, 48, 8, uint8_t, region_index);\
> + MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, obj_type[0]);\
> + MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, obj_type[1]);\
> + MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, obj_type[2]);\
> + MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, obj_type[3]);\
> + MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, obj_type[4]);\
> + MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, obj_type[5]);\
> + MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, obj_type[6]);\
> + MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, obj_type[7]);\
> + MC_CMD_PARAM_OP(cmd, 4, 0, 8, char, obj_type[8]);\
> + MC_CMD_PARAM_OP(cmd, 4, 8, 8, char, obj_type[9]);\
> + MC_CMD_PARAM_OP(cmd, 4, 16, 8, char, obj_type[10]);\
> + MC_CMD_PARAM_OP(cmd, 4, 24, 8, char, obj_type[11]);\
> + MC_CMD_PARAM_OP(cmd, 4, 32, 8, char, obj_type[12]);\
> + MC_CMD_PARAM_OP(cmd, 4, 40, 8, char, obj_type[13]);\
> + MC_CMD_PARAM_OP(cmd, 4, 48, 8, char, obj_type[14]);\
> + MC_CMD_PARAM_OP(cmd, 4, 56, 8, char, obj_type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_OBJ_REGION(cmd, region_desc) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 64, uint64_t, region_desc->base_paddr);\
> + MC_RSP_PARAM_OP(cmd, 2, 0, 32, uint32_t, region_desc->size); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_SET_IRQ(cmd, irq_index, irq_val, irq_paddr, user_irq_id) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index); \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, irq_val); \
> + MC_CMD_PARAM_OP(cmd, 1, 0, 64, uint64_t, irq_paddr);\
> + MC_CMD_PARAM_OP(cmd, 2, 0, 32, int, user_irq_id); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_IRQ(cmd, irq_index) \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_IRQ(cmd, irq_val, irq_paddr, user_irq_id, type) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, irq_val); \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 64, uint64_t, irq_paddr);\
> + MC_RSP_PARAM_OP(cmd, 2, 0, 32, int, user_irq_id); \
> + MC_RSP_PARAM_OP(cmd, 2, 32, 32, int, type); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_SET_IRQ_ENABLE(cmd, enable_state, irq_index) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 8, uint8_t, enable_state); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_IRQ_ENABLE(cmd, irq_index) \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_IRQ_ENABLE(cmd, enable_state) \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 8, uint8_t, enable_state)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_SET_IRQ_MASK(cmd, mask, irq_index) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, mask); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_IRQ_MASK(cmd, irq_index) \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_IRQ_MASK(cmd, mask) \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, mask)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_IRQ_STATUS(cmd, irq_index) \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_IRQ_STATUS(cmd, status) \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, uint32_t, status)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_CLEAR_IRQ_STATUS(cmd, status, irq_index) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, uint32_t, status); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 8, uint8_t, irq_index);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_CONNECT(cmd, endpoint1, endpoint2) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, endpoint1->id); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 32, int, endpoint1->interface_id); \
> + MC_CMD_PARAM_OP(cmd, 1, 0, 32, int, endpoint2->id); \
> + MC_CMD_PARAM_OP(cmd, 1, 32, 32, int, endpoint2->interface_id); \
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, endpoint1->type[0]); \
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, endpoint1->type[1]); \
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, endpoint1->type[2]); \
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, endpoint1->type[3]); \
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, endpoint1->type[4]); \
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, endpoint1->type[5]); \
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, endpoint1->type[6]); \
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, endpoint1->type[7]); \
> + MC_CMD_PARAM_OP(cmd, 3, 0, 8, char, endpoint1->type[8]); \
> + MC_CMD_PARAM_OP(cmd, 3, 8, 8, char, endpoint1->type[9]); \
> + MC_CMD_PARAM_OP(cmd, 3, 16, 8, char, endpoint1->type[10]); \
> + MC_CMD_PARAM_OP(cmd, 3, 24, 8, char, endpoint1->type[11]); \
> + MC_CMD_PARAM_OP(cmd, 3, 32, 8, char, endpoint1->type[12]); \
> + MC_CMD_PARAM_OP(cmd, 3, 40, 8, char, endpoint1->type[13]); \
> + MC_CMD_PARAM_OP(cmd, 3, 48, 8, char, endpoint1->type[14]); \
> + MC_CMD_PARAM_OP(cmd, 3, 56, 8, char, endpoint1->type[15]); \
> + MC_CMD_PARAM_OP(cmd, 5, 0, 8, char, endpoint2->type[0]); \
> + MC_CMD_PARAM_OP(cmd, 5, 8, 8, char, endpoint2->type[1]); \
> + MC_CMD_PARAM_OP(cmd, 5, 16, 8, char, endpoint2->type[2]); \
> + MC_CMD_PARAM_OP(cmd, 5, 24, 8, char, endpoint2->type[3]); \
> + MC_CMD_PARAM_OP(cmd, 5, 32, 8, char, endpoint2->type[4]); \
> + MC_CMD_PARAM_OP(cmd, 5, 40, 8, char, endpoint2->type[5]); \
> + MC_CMD_PARAM_OP(cmd, 5, 48, 8, char, endpoint2->type[6]); \
> + MC_CMD_PARAM_OP(cmd, 5, 56, 8, char, endpoint2->type[7]); \
> + MC_CMD_PARAM_OP(cmd, 6, 0, 8, char, endpoint2->type[8]); \
> + MC_CMD_PARAM_OP(cmd, 6, 8, 8, char, endpoint2->type[9]); \
> + MC_CMD_PARAM_OP(cmd, 6, 16, 8, char, endpoint2->type[10]); \
> + MC_CMD_PARAM_OP(cmd, 6, 24, 8, char, endpoint2->type[11]); \
> + MC_CMD_PARAM_OP(cmd, 6, 32, 8, char, endpoint2->type[12]); \
> + MC_CMD_PARAM_OP(cmd, 6, 40, 8, char, endpoint2->type[13]); \
> + MC_CMD_PARAM_OP(cmd, 6, 48, 8, char, endpoint2->type[14]); \
> + MC_CMD_PARAM_OP(cmd, 6, 56, 8, char, endpoint2->type[15]); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_DISCONNECT(cmd, endpoint) \
> +do { \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, endpoint->id); \
> + MC_CMD_PARAM_OP(cmd, 0, 32, 32, int, endpoint->interface_id); \
> + MC_CMD_PARAM_OP(cmd, 1, 0, 8, char, endpoint->type[0]); \
> + MC_CMD_PARAM_OP(cmd, 1, 8, 8, char, endpoint->type[1]); \
> + MC_CMD_PARAM_OP(cmd, 1, 16, 8, char, endpoint->type[2]); \
> + MC_CMD_PARAM_OP(cmd, 1, 24, 8, char, endpoint->type[3]); \
> + MC_CMD_PARAM_OP(cmd, 1, 32, 8, char, endpoint->type[4]); \
> + MC_CMD_PARAM_OP(cmd, 1, 40, 8, char, endpoint->type[5]); \
> + MC_CMD_PARAM_OP(cmd, 1, 48, 8, char, endpoint->type[6]); \
> + MC_CMD_PARAM_OP(cmd, 1, 56, 8, char, endpoint->type[7]); \
> + MC_CMD_PARAM_OP(cmd, 2, 0, 8, char, endpoint->type[8]); \
> + MC_CMD_PARAM_OP(cmd, 2, 8, 8, char, endpoint->type[9]); \
> + MC_CMD_PARAM_OP(cmd, 2, 16, 8, char, endpoint->type[10]); \
> + MC_CMD_PARAM_OP(cmd, 2, 24, 8, char, endpoint->type[11]); \
> + MC_CMD_PARAM_OP(cmd, 2, 32, 8, char, endpoint->type[12]); \
> + MC_CMD_PARAM_OP(cmd, 2, 40, 8, char, endpoint->type[13]); \
> + MC_CMD_PARAM_OP(cmd, 2, 48, 8, char, endpoint->type[14]); \
> + MC_CMD_PARAM_OP(cmd, 2, 56, 8, char, endpoint->type[15]); \
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_POOL(cmd, pool_index) \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, pool_index)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_POOL(cmd, type) \
> +do { \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 8, char, type[0]);\
> + MC_RSP_PARAM_OP(cmd, 1, 8, 8, char, type[1]);\
> + MC_RSP_PARAM_OP(cmd, 1, 16, 8, char, type[2]);\
> + MC_RSP_PARAM_OP(cmd, 1, 24, 8, char, type[3]);\
> + MC_RSP_PARAM_OP(cmd, 1, 32, 8, char, type[4]);\
> + MC_RSP_PARAM_OP(cmd, 1, 40, 8, char, type[5]);\
> + MC_RSP_PARAM_OP(cmd, 1, 48, 8, char, type[6]);\
> + MC_RSP_PARAM_OP(cmd, 1, 56, 8, char, type[7]);\
> + MC_RSP_PARAM_OP(cmd, 2, 0, 8, char, type[8]);\
> + MC_RSP_PARAM_OP(cmd, 2, 8, 8, char, type[9]);\
> + MC_RSP_PARAM_OP(cmd, 2, 16, 8, char, type[10]);\
> + MC_RSP_PARAM_OP(cmd, 2, 24, 8, char, type[11]);\
> + MC_RSP_PARAM_OP(cmd, 2, 32, 8, char, type[12]);\
> + MC_RSP_PARAM_OP(cmd, 2, 40, 8, char, type[13]);\
> + MC_RSP_PARAM_OP(cmd, 2, 48, 8, char, type[14]);\
> + MC_RSP_PARAM_OP(cmd, 2, 56, 8, char, type[15]);\
> +} while (0)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_POOL_COUNT(cmd, pool_count) \
> + MC_RSP_PARAM_OP(cmd, 0, 0, 32, int, pool_count)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_CMD_GET_PORTAL_PADDR(cmd, portal_id) \
> + MC_CMD_PARAM_OP(cmd, 0, 0, 32, int, portal_id)
> +
> +/* param, offset, width, type, arg_name */
> +#define DPRC_RSP_GET_PORTAL_PADDR(cmd, portal_addr) \
> + MC_RSP_PARAM_OP(cmd, 1, 0, 64, uint64_t, portal_addr)
> +
> +#endif /* _FSL_DPRC_CMD_H */
> diff --git a/drivers/bus/fsl-mc/dprc.c b/drivers/bus/fsl-mc/dprc.c
> new file mode 100644
> index 0000000..77315fe
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/dprc.c
> @@ -0,0 +1,521 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include <linux/fsl/mc-sys.h>
> +#include <linux/fsl/mc-cmd.h>
> +#include <linux/fsl/dprc.h>
> +#include "dprc-cmd.h"
> +
> +int dprc_get_container_id(struct fsl_mc_io *mc_io, int *container_id)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_CONT_ID,
> + DPRC_CMDSZ_GET_CONT_ID,
> + MC_CMD_PRI_LOW, 0);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_CONTAINER_ID(cmd, *container_id);
> + return 0;
> +}
> +
> +int dprc_open(struct fsl_mc_io *mc_io, int container_id, uint16_t *dprc_handle)
> +{
> + int err;
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(MC_DPRC_CMDID_OPEN,
> + MC_CMD_OPEN_SIZE, MC_CMD_PRI_LOW, 0);
> +
> + DPRC_CMD_OPEN(cmd, container_id);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + *dprc_handle = MC_CMD_HDR_READ_AUTHID(cmd.header);
> + return 0;
> +}
> +
> +int dprc_close(struct fsl_mc_io *mc_io, uint16_t dprc_handle)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(MC_CMDID_CLOSE,
> + MC_CMD_CLOSE_SIZE,
> + MC_CMD_PRI_HIGH, dprc_handle);
> +
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_create_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_cfg *cfg,
> + int *child_container_id,
> + uint64_t *child_portal_paddr)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_CREATE_CONT,
> + DPRC_CMDSZ_CREATE_CONT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_CREATE_CONTAINER(cmd, cfg);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_CREATE_CONTAINER(cmd, *child_container_id,
> + *child_portal_paddr);
> +
> + return 0;
> +}
> +
> +int dprc_destroy_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_DESTROY_CONT,
> + DPRC_CMDSZ_DESTROY_CONT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_DESTROY_CONTAINER(cmd, child_container_id);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_reset_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_RESET_CONT,
> + DPRC_CMDSZ_RESET_CONT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_RESET_CONTAINER(cmd, child_container_id);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_set_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id, char *type, uint16_t quota)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_RES_QUOTA,
> + DPRC_CMDSZ_SET_RES_QUOTA,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_SET_RES_QUOTA(cmd, child_container_id, type, quota);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_get_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id, char *type, uint16_t *quota)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_RES_QUOTA,
> + DPRC_CMDSZ_GET_RES_QUOTA,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_RES_QUOTA(cmd, child_container_id, type);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_RES_QUOTA(cmd, *quota);
> + return 0;
> +}
> +
> +int dprc_assign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int container_id, struct dprc_res_req *res_req)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_ASSIGN,
> + DPRC_CMDSZ_ASSIGN,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_ASSIGN(cmd, container_id, res_req);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_unassign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id, struct dprc_res_req *res_req)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_UNASSIGN,
> + DPRC_CMDSZ_UNASSIGN,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_UNASSIGN(cmd, child_container_id, res_req);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_get_obj_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int *obj_count)
> +{
> + int err;
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_OBJ_COUNT,
> + DPRC_CMDSZ_GET_OBJ_COUNT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_OBJ_COUNT(cmd, *obj_count);
> + return 0;
> +}
> +
> +int dprc_get_obj(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int obj_index, struct dprc_obj_desc *obj_desc)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_OBJECT,
> + DPRC_CMDSZ_GET_OBJECT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_OBJECT(cmd, obj_index);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_OBJECT(cmd, obj_desc);
> + return 0;
> +}
> +
> +int dprc_get_res_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + char *type, int *res_count)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + *res_count = 0;
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_RES_COUNT,
> + DPRC_CMDSZ_GET_RES_COUNT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_RES_COUNT(cmd, type);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_RES_COUNT(cmd, *res_count);
> + return 0;
> +}
> +
> +int dprc_get_res_ids(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + char *type, struct dprc_res_ids_range_desc *range_desc)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_RES_IDS,
> + DPRC_CMDSZ_GET_RES_IDS,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_RES_IDS(cmd, type, range_desc);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_RES_IDS(cmd, range_desc);
> + return 0;
> +}
> +
> +int dprc_get_attributes(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_attributes *attr)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_ATTR,
> + DPRC_CMDSZ_GET_ATTR,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_ATTRIBUTES(cmd, attr);
> + return 0;
> +}
> +
> +int dprc_get_obj_region(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + char *obj_type,
> + int obj_id,
> + uint8_t region_index,
> + struct dprc_region_desc *region_desc)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_OBJ_REG,
> + DPRC_CMDSZ_GET_OBJ_REG,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_OBJ_REGION(cmd, obj_id, region_index, obj_type);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_OBJ_REGION(cmd, region_desc);
> + return 0;
> +}
> +
> +int dprc_get_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index,
> + int *type,
> + uint64_t *irq_paddr, uint32_t *irq_val, int *user_irq_id)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ,
> + DPRC_CMDSZ_GET_IRQ,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_IRQ(cmd, irq_index);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_IRQ(cmd, *irq_val, *irq_paddr, *user_irq_id, *type);
> + return 0;
> +}
> +
> +int dprc_set_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index,
> + uint64_t irq_paddr, uint32_t irq_val, int user_irq_id)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_IRQ,
> + DPRC_CMDSZ_SET_IRQ,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_SET_IRQ(cmd, irq_index, irq_val, irq_paddr, user_irq_id);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_get_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint8_t *enable_state)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ_ENABLE,
> + DPRC_CMDSZ_GET_IRQ_ENABLE,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_IRQ_ENABLE(cmd, irq_index);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_IRQ_ENABLE(cmd, *enable_state);
> + return 0;
> +}
> +
> +int dprc_set_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint8_t enable_state)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_IRQ_ENABLE,
> + DPRC_CMDSZ_SET_IRQ_ENABLE,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_SET_IRQ_ENABLE(cmd, enable_state, irq_index);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_get_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t *mask)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ_MASK,
> + DPRC_CMDSZ_GET_IRQ_MASK,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_IRQ_MASK(cmd, irq_index);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_IRQ_MASK(cmd, *mask);
> + return 0;
> +}
> +
> +int dprc_set_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t mask)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_IRQ_MASK,
> + DPRC_CMDSZ_SET_IRQ_MASK,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_SET_IRQ_MASK(cmd, mask, irq_index);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_get_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t *status)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_IRQ_STATUS,
> + DPRC_CMDSZ_GET_IRQ_STATUS,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_IRQ_STATUS(cmd, irq_index);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_IRQ_STATUS(cmd, *status);
> + return 0;
> +}
> +
> +int dprc_clear_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t status)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_CLEAR_IRQ_STATUS,
> + DPRC_CMDSZ_CLEAR_IRQ_STATUS,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_CLEAR_IRQ_STATUS(cmd, status, irq_index);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_get_pool_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int *pool_count)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_POOL_COUNT,
> + DPRC_CMDSZ_GET_POOL_COUNT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_POOL_COUNT(cmd, *pool_count);
> + return 0;
> +}
> +
> +int dprc_get_pool(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int pool_index, char *type)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_POOL,
> + DPRC_CMDSZ_GET_POOL,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_POOL(cmd, pool_index);
> +
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_POOL(cmd, type);
> + return 0;
> +}
> +
> +int dprc_get_portal_paddr(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int portal_id, uint64_t *portal_addr)
> +{
> + struct mc_command cmd = { 0 };
> + int err;
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_PORTAL_PADDR,
> + DPRC_CMDSZ_GET_PORTAL_PADDR,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_GET_PORTAL_PADDR(cmd, portal_id);
> + err = mc_send_command(mc_io, &cmd);
> + if (err)
> + return err;
> +
> + DPRC_RSP_GET_PORTAL_PADDR(cmd, *portal_addr);
> + return 0;
> +}
> +
> +int dprc_connect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_endpoint *endpoint1,
> + struct dprc_endpoint *endpoint2)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_CONNECT,
> + DPRC_CMDSZ_CONNECT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_CONNECT(cmd, endpoint1, endpoint2);
> + return mc_send_command(mc_io, &cmd);
> +}
> +
> +int dprc_disconnect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_endpoint *endpoint)
> +{
> + struct mc_command cmd = { 0 };
> +
> + cmd.header = mc_encode_cmd_header(DPRC_CMDID_DISCONNECT,
> + DPRC_CMDSZ_DISCONNECT,
> + MC_CMD_PRI_LOW, dprc_handle);
> +
> + DPRC_CMD_DISCONNECT(cmd, endpoint);
> + return mc_send_command(mc_io, &cmd);
> +}
> diff --git a/drivers/bus/fsl-mc/mc-sys.c b/drivers/bus/fsl-mc/mc-sys.c
> new file mode 100644
> index 0000000..a598bbe
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/mc-sys.c
> @@ -0,0 +1,189 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include <linux/fsl/mc-sys.h>
> +#include <linux/fsl/mc-cmd.h>
> +#include <linux/delay.h>
> +#include <linux/slab.h>
> +#include <linux/ioport.h>
> +#include <linux/device.h>
> +
> +/**
> + * Timeout in jiffies to wait for the completion of an MC command
> + */
> +#define MC_CMD_COMPLETION_TIMEOUT_JIFFIES (HZ / 2) /* 500 ms */
> +
> +/*
> + * usleep_range() min and max values used to throttle down polling
> + * iterations while waiting for MC command completion
> + */
> +#define MC_CMD_COMPLETION_POLLING_MIN_SLEEP_USECS 10
> +#define MC_CMD_COMPLETION_POLLING_MAX_SLEEP_USECS 500
> +
> +/**
> + * Creates an MC I/O object
> + *
> + * @dev: device to be associated with the MC I/O object
> + * @mc_portal_phys_addr: physical address of the MC portal to use
> + * @mc_portal_size: size in bytes of the MC portal
> + * @flags: flags for the new MC I/O object
> + * @new_mc_io: Area to return pointer to newly created MC I/O object
> + *
> + * Returns '0' on Success; Error code otherwise.
> + */
> +int __must_check fsl_create_mc_io(struct device *dev,
> + phys_addr_t mc_portal_phys_addr,
> + uint32_t mc_portal_size,
> + uint32_t flags, struct fsl_mc_io **new_mc_io)
> +{
> + struct fsl_mc_io *mc_io;
> + void __iomem *mc_portal_virt_addr;
> + struct resource *res;
> +
> + mc_io = devm_kzalloc(dev, sizeof(*mc_io), GFP_KERNEL);
> + if (mc_io == NULL)
> + return -ENOMEM;
> +
> + mc_io->dev = dev;
> + mc_io->flags = flags;
> + mc_io->portal_phys_addr = mc_portal_phys_addr;
> + mc_io->portal_size = mc_portal_size;
> + res = devm_request_mem_region(dev,
> + mc_portal_phys_addr,
> + mc_portal_size,
> + "mc_portal");
> + if (res == NULL) {
> + dev_err(dev,
> + "devm_request_mem_region failed for MC portal %#llx\n",
> + mc_portal_phys_addr);
> + return -EBUSY;
> + }
> +
> + mc_portal_virt_addr = devm_ioremap_nocache(dev,
> + mc_portal_phys_addr,
> + mc_portal_size);
> + if (mc_portal_virt_addr == NULL) {
> + dev_err(dev,
> + "devm_ioremap_nocache failed for MC portal %#llx\n",
> + mc_portal_phys_addr);
> + return -ENXIO;
> + }
> +
> + mc_io->portal_virt_addr = mc_portal_virt_addr;
> + *new_mc_io = mc_io;
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(fsl_create_mc_io);
> +
> +/**
> + * Destroys an MC I/O object
> + *
> + * @mc_io: MC I/O object to destroy
> + */
> +void fsl_destroy_mc_io(struct fsl_mc_io *mc_io)
> +{
> + devm_iounmap(mc_io->dev, mc_io->portal_virt_addr);
> + devm_release_mem_region(mc_io->dev,
> + mc_io->portal_phys_addr,
> + mc_io->portal_size);
> +
> + mc_io->portal_virt_addr = NULL;
> + devm_kfree(mc_io->dev, mc_io);
> +}
> +EXPORT_SYMBOL_GPL(fsl_destroy_mc_io);
> +
> +static int mc_status_to_error(enum mc_cmd_status status)
> +{
> + static const int mc_status_to_error_map[] = {
> + [MC_CMD_STATUS_OK] = 0,
> + [MC_CMD_STATUS_AUTH_ERR] = -EACCES,
> + [MC_CMD_STATUS_NO_PRIVILEGE] = -EPERM,
> + [MC_CMD_STATUS_DMA_ERR] = -EIO,
> + [MC_CMD_STATUS_CONFIG_ERR] = -ENXIO,
> + [MC_CMD_STATUS_TIMEOUT] = -ETIMEDOUT,
> + [MC_CMD_STATUS_NO_RESOURCE] = -ENAVAIL,
> + [MC_CMD_STATUS_NO_MEMORY] = -ENOMEM,
> + [MC_CMD_STATUS_BUSY] = -EBUSY,
> + [MC_CMD_STATUS_UNSUPPORTED_OP] = -ENOTSUPP,
> + [MC_CMD_STATUS_INVALID_STATE] = -ENODEV,
> + };
> +
> + if (WARN_ON(status >= ARRAY_SIZE(mc_status_to_error_map)))
> + return -EINVAL;

Unfortunately gcc may or may not make the enum signed. If it's signed,
this check will not catch the case where the number is negative.

Maybe cast status to u32 to explicitly make sure we catch negative
values as well?

> +
> + return mc_status_to_error_map[status];
> +}
> +
> +/**
> + * Sends an command to the MC device using the given MC I/O object
> + *
> + * @mc_io: MC I/O object to be used
> + * @cmd: command to be sent
> + *
> + * Returns '0' on Success; Error code otherwise.
> + *
> + * NOTE: This function cannot be invoked from from atomic contexts.
> + */
> +int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd)
> +{
> + enum mc_cmd_status status;
> + unsigned long irqsave_flags = 0;
> + unsigned long jiffies_until_timeout =
> + jiffies + MC_CMD_COMPLETION_TIMEOUT_JIFFIES;
> +
> + /*
> + * Send command to the MC hardware:
> + */
> + mc_write_command(mc_io->portal_virt_addr, cmd);
> +
> + /*
> + * Wait for response from the MC hardware:
> + */
> + for (;;) {
> + status = mc_read_response(mc_io->portal_virt_addr, cmd);
> + if (status != MC_CMD_STATUS_READY)
> + break;
> +
> + /*
> + * TODO: When MC command completion interrupts are supported
> + * call wait function here instead of usleep_range()
> + */
> + usleep_range(MC_CMD_COMPLETION_POLLING_MIN_SLEEP_USECS,
> + MC_CMD_COMPLETION_POLLING_MAX_SLEEP_USECS);
> +
> + if (time_after_eq(jiffies, jiffies_until_timeout))
> + return -ETIMEDOUT;
> + }
> +
> + return mc_status_to_error(status);
> +}
> +EXPORT_SYMBOL(mc_send_command);
> diff --git a/include/linux/fsl/dpmng.h b/include/linux/fsl/dpmng.h
> new file mode 100644
> index 0000000..3b5d81b
> --- /dev/null
> +++ b/include/linux/fsl/dpmng.h
> @@ -0,0 +1,121 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +/*
> + * dpmng.h
> + * Management Complex General API
> + */
> +
> +#ifndef __FSL_DPMNG_H
> +#define __FSL_DPMNG_H
> +
> +/*
> + * grp_dpmng Management Complex General API
> + *
> + * Contains general API for the Management Complex firmware
> + *
> + */
> +
> +struct fsl_mc_io;
> +
> +/*
> + * Management Complex firmware version information
> + */
> +#define MC_VER_MAJOR 2
> +#define MC_VER_MINOR 0
> +
> +struct mc_version {
> + uint32_t major;
> + /*
> + * Major version number: incremented on API compatibility changes
> + */
> + uint32_t minor;
> + /*
> + * Minor version number: incremented on API additions (backward
> + * compatible); reset when major version is incremented.
> + */
> + uint32_t revision;
> + /*
> + * Internal revision number: incremented on implementation changes
> + * and/or bug fixes that have no impact on API
> + */
> +};
> +
> +/*
> + * Retrieves the Management Complex firmware version information
> + *
> + * mc_io - Pointer to opaque I/O object
> + * mc_ver_info - Pointer to version information structure
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info);
> +
> +/*
> + * Resets an AIOP tile
> + *
> + * mc_io - Pointer to opaque I/O object
> + * aiop_tile_id - AIOP tile ID to reset
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dpmng_reset_aiop(struct fsl_mc_io *mc_io, int aiop_tile_id);
> +
> +/*
> + * Loads an image to AIOP tile
> + *
> + * mc_io - Pointer to opaque I/O object
> + * aiop_tile_id - AIOP tile ID
> + * img_dma_addr - DMA address (bus address) for the AIOP ELF image in memory
> + * img_size - Size in bytes of AIOP ELF image in memory
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dpmng_load_aiop(struct fsl_mc_io *mc_io,
> + int aiop_tile_id, dma_addr_t img_dma_addr, int img_size);
> +
> +/*
> + * Starts AIOP tile execution
> + *
> + * mc_io - Pointer to opaque I/O object
> + * aiop_tile_id - AIOP tile ID to run
> + * cores_mask - Mask of AIOP cores to run (core 0 in msb)
> + * options - Execution options (currently none defined)
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dpmng_run_aiop(struct fsl_mc_io *mc_io,
> + int aiop_tile_id, uint32_t cores_mask, uint64_t options);
> +
> +/* */
> +
> +#endif /* __FSL_DPMNG_H */
> diff --git a/include/linux/fsl/dprc.h b/include/linux/fsl/dprc.h
> new file mode 100644
> index 0000000..02ad590
> --- /dev/null
> +++ b/include/linux/fsl/dprc.h
> @@ -0,0 +1,791 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +/*
> + * dprc.h
> + * Data Path Resource Container API
> + */
> +
> +#ifndef _FSL_DPRC_H
> +#define _FSL_DPRC_H
> +
> +/*
> + * grp_dprc Data Path Resource Container API
> + *
> + * Contains DPRC API for managing and querying LDPAA resources
> + *
> + */
> +
> +struct fsl_mc_io;
> +
> +/*
> + * Set this value as the icid value in dprc_cfg structure when creating a
> + * container, in case the ICID is not selected by the user and should be
> + * allocated by the DPRC from the pool of ICIDs.
> + */
> +#define DPRC_GET_ICID_FROM_POOL (uint16_t)(~(0))
> +/*
> + * Set this value as the portal_id value in dprc_cfg structure when creating a
> + * container, in case the portal id is not specifically selected by the
> + * user and should be allocated by the DPRC from the pool of portal ids.
> + */
> +#define DPRC_GET_PORTAL_ID_FROM_POOL (int)(~(0))
> +
> +/*
> + * Resource request options
> + */
> +#define DPRC_RES_REQ_OPT_EXPLICIT 0x00000001
> +/* Explicit resource id request - The requested objects/resources
> + * are explicit and sequential (in case of resources).
> + * The base ID is given at res_req at base_align field */
> +#define DPRC_RES_REQ_OPT_ALIGNED 0x00000002
> +/* Aligned resources request - Relevant only for resources
> + * request (and not objects). Indicates that resources base id should be
> + * sequential and aligned to the value given at dprc_res_req base_align field*/
> +#define DPRC_RES_REQ_OPT_PLUGGED 0x00000004
> +/* Plugged Flag - Relevant only for object assignment request.
> + * Indicates that after all objects assigned. An interrupt will be invoked at
> + * the relevant GPP. The assigned object will be marked as plugged.
> + * plugged objects can't be assigned from their container */
> +/* */
> +
> +/*
> + * Container general options
> + *
> + * These options may be selected at container creation by the container creator
> + * and can be retrieved using dprc_get_attributes()
> + */
> +#define DPRC_CFG_OPT_SPAWN_ALLOWED 0x00000001
> +/* Spawn Policy Option allowed - Indicates that the new container is allowed
> + * to spawn and have its own child containers. */
> +#define DPRC_CFG_OPT_ALLOC_ALLOWED 0x00000002
> +/* General Container allocation policy - Indicates that the new container is
> + * allowed to allocate requested resources from its parent container; if not
> + * set, the container is only allowed to use resources in its own pools; Note
> + * that this is a container's global policy, but the parent container may
> + * override it and set specific quota per resource type. */
> +#define DPRC_CFG_OPT_OBJ_CREATE_ALLOWED 0x00000004
> +/* Object initialization allowed - software context associated with this
> + * container is allowed to invoke object initialization operations. */
> +#define DPRC_CFG_OPT_TOPOLOGY_CHANGES_ALLOWED 0x00000008
> +/* Topology change allowed - software context associated with this
> + * container is allowed to invoke topology operations, such as attach/detach
> + * of network objects. */
> +#define DPRC_CFG_OPT_IOMMU_BYPASS 0x00000010
> +/*IOMMU bypass - indicates whether objects of this container are permitted
> + * to bypass the IOMMU. */
> +#define DPRC_CFG_OPT_AIOP 0x00000020
> +/*AIOP -Indicates that container belongs to aiop. */
> +/* */
> +
> +/*
> + * Objects Attributes Flags
> + */
> +#define DPRC_OBJ_STATE_OPEN 0x00000001
> +/* Opened state - Indicates that an object is open by at least one owner */
> +#define DPRC_OBJ_STATE_PLUGGED 0x00000002
> +/* Plugged state - Indicates that the object is plugged */
> +/* */
> +
> +/*
> + * Irq
> + */
> +#define DPRC_NUM_OF_IRQS 1
> +/* Number of dprc's IRQs */
> +/* */
> +
> +/*
> + * Object irq events
> + */
> +#define DPRC_IRQ_EVENT_OBJ_ASSIGNED 0x00000001
> +/* Irq event - Indicates that a new object assigned to the container */
> +#define DPRC_IRQ_EVENT_OBJ_UNASSIGNED 0x00000002
> +/* Irq event - Indicates that an object was unassigned from the container */
> +#define DPRC_IRQ_EVENT_RES_ASSIGNED 0x00000004
> +/* Irq event - Indicates that resources assigned to the container */
> +#define DPRC_IRQ_EVENT_RES_UNASSIGNED 0x00000008
> +/* Irq event - Indicates that resources unassigned from the container */
> +#define DPRC_IRQ_EVENT_CONTAINER_DESTROYED 0x00000010
> +/* Irq event - Indicates that one of the descendant containers that opened by
> + * this container is destroyed */
> +#define DPRC_IRQ_EVENT_OBJ_DESTROYED 0x00000011
> +/* Irq event - Indicates that on one of the container's opened object is
> + destroyed */
> +/* */
> +
> +/*
> + * Resource request descriptor, to be used in assignment or
> + * un-assignment of resources and objects.
> + */
> +struct dprc_res_req {
> + char type[16];
> + /*
> + * Resource/object type: Represent as a NULL terminated string.
> + * This string may received by using dprc_get_pool() to get resource
> + * type and dprc_get_obj() to get object type.
> + * Note: it is not possible to assign/unassign DP_OBJ_DPRC objects
> + */
> + uint32_t num;
> + /* Number of resources */
> + uint32_t options;
> + /* Request options: combination of DPRC_RES_REQ_OPT_ options */
> + int id_base_align;
> + /*
> + * In case of explicit assignment (DPRC_RES_REQ_OPT_EXPLICIT is set at
> + * option), this field represents the required base ID for resource
> + * allocation;
> + * In case of aligned assignment (DPRC_RES_REQ_OPT_ALIGNED is set at
> + * option), this field indicates the required alignment for the
> + * resource ID(s) - use 0 if there is no alignment or explicit id
> + * requirements.
> + */
> +};
> +
> +/*
> + * Object descriptor, returned from dprc_get_obj()
> + */
> +struct dprc_obj_desc {
> + uint16_t vendor;
> + /* Object vendor identifier */
> + char type[16];
> + /* Type of object: NULL terminated string */
> + int id;
> + /* ID of logical object resource */
> + uint32_t ver_major;
> + /* Major version number */
> + uint32_t ver_minor;
> + /* Minor version number */
> + uint8_t irq_count;
> + /* Number of interrupts supported by the object */
> + uint8_t region_count;
> + /* Number of mappable regions supported by the object */
> + uint32_t state;
> + /* Object state: combination of DPRC_OBJ_STATE_ states */
> +};
> +
> +/*
> + * Mappable region descriptor, returned by dprc_get_obj_region()
> + */
> +struct dprc_region_desc {
> + uint64_t base_paddr;
> + /* Region base physical address */
> + uint32_t size;
> + /* Region size (in bytes) */
> +};
> +
> +/*
> + * Iteration status, for use with dprc_get_res_ids() function
> + *
> + */
> +enum dprc_iter_status {
> + DPRC_ITER_STATUS_FIRST = 0,
> + /* Perform first iteration */
> + DPRC_ITER_STATUS_MORE = 1,
> + /* Indicates more/next iteration is needed */
> + DPRC_ITER_STATUS_LAST = 2
> + /* Indicates last iteration */
> +};
> +
> +/*
> + * Resource Id range descriptor, Used at dprc_get_res_ids() and
> + * contains one range details.
> + */
> +struct dprc_res_ids_range_desc {
> + int base_id;
> + /* Base resource ID of this range */
> + int last_id;
> + /* Last resource ID of this range */
> + enum dprc_iter_status iter_status;
> + /*
> + * Iteration status - should be set to DPRC_ITER_STATUS_FIRST at
> + * first iteration; while the returned marker is DPRC_ITER_STATUS_MORE,
> + * additional iterations are needed, until the returned marker is
> + * DPRC_ITER_STATUS_LAST
> + */
> +};
> +
> +/*
> + * Container attributes, returned by dprc_get_attributes()
> + */
> +struct dprc_attributes {
> + int container_id;
> + /* Container's ID */
> + uint16_t icid;
> + /* Container's ICID */
> + int portal_id;
> + /* Container's portal ID */
> + uint64_t options;
> + /* Container's options as set at container's creation */
> + struct {
> + uint32_t major; /* DPRC major version */
> + uint32_t minor; /* DPRC minor version */
> + } version;
> + /* DPRC version */
> +};
> +
> +/*
> + * Container configuration options, used in dprc_create_container()
> + */
> +struct dprc_cfg {
> + uint16_t icid;
> + /* Container's ICID; if set to DPRC_GET_ICID_FROM_POOL, a free ICID
> + * will be allocated by the DPRC */
> + int portal_id;
> + /* portal id; if set to DPRC_GET_PORTAL_ID_FROM_POOL, a free portal id
> + * will be allocated by the DPRC */
> + uint64_t options;
> + /* Combination of DPRC_CFG_OPT_ options */
> +};
> +
> +/*
> + * Endpoint description for link connect/disconnect operations
> + */
> +struct dprc_endpoint {
> + char type[16];
> + /* Endpoint object type: NULL terminated string */
> + int id;
> + /* Endpoint object id */
> + int interface_id;
> + /*
> + * Interface id; should be set for endpoints with multiple interfaces
> + * (DP_OBJ_DPSW, DP_OBJ_DPDMUX); for others, always set to 0.
> + */
> +};
> +
> +/*
> + * Obtains the container id associated with a given portal.
> + *
> + * mc_io Pointer to opaque I/O object
> + * container_id Requested container ID
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_container_id(struct fsl_mc_io *mc_io, int *container_id);
> +
> +/*
> + * Opens a DPRC object for use
> + *
> + * mc_io Pointer to opaque I/O object
> + * container_id Container ID to open
> + * dprc_handle Handle to the DPRC object
> + *
> + * returns '0' on Success; Error code otherwise.
> + *
> + * Required before any operation on the object.
> + */
> +int dprc_open(struct fsl_mc_io *mc_io, int container_id,
> + uint16_t *dprc_handle);
> +
> +/*
> + * Closes the DPRC object handle
> + *
> + * No further operations on the object are allowed after this call without
> + * re-opening the object.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_close(struct fsl_mc_io *mc_io, uint16_t dprc_handle);
> +
> +/*
> + * Creates a child container
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * cfg Child container configuration
> + * child_container_id Child container ID
> + * child_portal_paddr Base physical address of the
> + * child portal
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_create_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_cfg *cfg,
> + int *child_container_id,
> + uint64_t *child_portal_paddr);
> +
> +/*
> + * Destroys a child container.
> + *
> + * This function terminates the child container, so following this call the
> + * child container ID becomes invalid.
> + *
> + * Notes:
> + * - All resources and objects of the destroyed container are returned to the
> + * parent container or destroyed if were created be the destroyed container.
> + * - This function destroy all the child containers of the specified
> + * container prior to destroying the container itself.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * child_container_id ID of the container to destroy
> + *
> + * returns '0' on Success; Error code otherwise.
> + *
> + * Only the parent container is allowed to destroy a child policy
> + * Container 0 can't be destroyed
> + */
> +int dprc_destroy_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id);
> +
> +/*
> + * Sets allocation policy for a specific resource/object type in a
> + * child container
> + *
> + * Allocation policy determines whether or not a container may allocate
> + * resources from its parent. Each container has a 'global' allocation policy
> + * that is set when the container is created.
> + *
> + * This function sets allocation policy for a specific resource type.
> + * The default policy for all resource types matches the container's 'global'
> + * allocation policy.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * child_container_id ID of the child container
> + * type resource/object type
> + * quota Sets the maximum number of resources of
> + * the selected type that the child
> + * container is allowed to allocate
> + * from its parent;
> + * when quota is set to -1, the policy is
> + * the same as container's general policy.
> + *
> + * returns '0' on Success; Error code otherwise.
> + *
> + * Only the parent container is allowed to change a child policy.
> + */
> +int dprc_set_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id, char *type, uint16_t quota);
> +
> +/*
> + * Gets the allocation policy of a specific resource/object type
> + * in a child container
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * child_container_id ID of the child container
> + * type resource/object type
> + * quota Holds the maximum number of resources of
> + * the selected type that the child
> + * container is allowed to allocate from
> + * the parent;
> + * when quota is set to -1, the policy is
> + * the same as container's general policy.
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_res_quota(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id, char *type, uint16_t *quota);
> +
> +/*
> + * Resets a child container.
> + *
> + * In case a software context crashes or becomes non-responsive, the parent
> + * may wish to reset its resources container before the software context is
> + * restarted.
> + *
> + * This routine informs all objects assigned to the child container that the
> + * container is being reset, so they may perform any cleanup operations that are
> + * needed. All objects handles that were owned by the child container shall be
> + * closed.
> + *
> + * Note that such request may be submitted even if the child software context
> + * has not crashed, but the resulting object cleanup operations will not be
> + * aware of that.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * child_container_id ID of the container to reset
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_reset_container(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id);
> +
> +/*
> + * Assigns objects or resource to a child container.
> + *
> + * Assignment is usually done by a parent (this DPRC) to one of its child
> + * containers.
> + *
> + * According to the DPRC allocation policy, the assigned resources may be taken
> + * (allocated) from the container's ancestors, if not enough resources are
> + * available in the container itself.
> + *
> + * The type of assignment depends on the dprc_res_req options, as follows:
> + * - DPRC_RES_REQ_OPT_EXPLICIT: indicates that assigned resources should have
> + * the explicit base ID specified at the id_base_align field of res_req.
> + * - DPRC_RES_REQ_OPT_ALIGNED: indicates that the assigned resources should be
> + * aligned to the value given at id_base_align field of res_req.
> + * - DPRC_RES_REQ_OPT_PLUGGED: Relevant only for object assignment,
> + * and indicates that the object must be set to the plugged state.
> + *
> + * A container may use this function with its own ID in order to change a
> + * object state to plugged or unplugged.
> + *
> + * If IRQ information has been set in the child DPRC, it will signal an
> + * interrupt following every change in its object assignment.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * container_id ID of the child container
> + * res_req Describes the type and amount of resources to
> + * assign to the given container.
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_assign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int container_id, struct dprc_res_req *res_req);
> +
> +/*
> + * Un-assigns objects or resources from a child container
> + * and moves them into this (parent) DPRC.
> + *
> + * Un-assignment of objects can succeed only if the object is not in the
> + * plugged or opened state.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * child_container_id ID of the child container
> + * res_req Describes the type and amount of
> + * resources to un-assign from the child
> + * container
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_unassign(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int child_container_id, struct dprc_res_req *res_req);
> +
> +/*
> + * Get the number of dprc's pools
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * pool_count Number of resource pools in the dprc.
> + *
> + * returns '0' on Success; Error code otherwise.
> + * */
> +int dprc_get_pool_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int *pool_count);
> +
> +/*
> + * Get the type (string) of a certain dprc's pool
> + *
> + * The pool types retrieved one by one by incrementing
> + * pool_index up to (not including) the value of pool_count returned
> + * from dprc_get_pool_count(). dprc_get_pool_count() must
> + * be called prior to dprc_get_pool().
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * pool_index Index of the pool to be queried (< pool_count)
> + * type The type of the pool.
> + *
> + * returns '0' on Success; Error code otherwise.
> + * */
> +int dprc_get_pool(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int pool_index, char *type);
> +
> +/*
> + * Obtains the number of objects in the DPRC
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * obj_count Number of objects assigned to the DPRC
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_obj_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int *obj_count);
> +
> +/*
> + * Obtains general information on an object
> + *
> + * The object descriptors are retrieved one by one by incrementing
> + * obj_index up to (not including) the value of obj_count returned
> + * from dprc_get_obj_count(). dprc_get_obj_count() must
> + * be called prior to dprc_get_obj().
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * obj_index Index of the object to be queried (< obj_count)
> + * obj_desc Returns the requested object descriptor
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_obj(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int obj_index, struct dprc_obj_desc *obj_desc);
> +
> +/*
> + * Obtains the number of free resources that are assigned
> + * to this container, by pool type
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * type pool type
> + * res_count Number of free resources of the given
> + * resource type that are assigned to this DPRC
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_res_count(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + char *type, int *res_count);
> +
> +/*
> + * Obtains IDs of free resources in the container
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * type pool type
> + * range_desc range descriptor
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_res_ids(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + char *type, struct dprc_res_ids_range_desc *range_desc);
> +
> +/*
> + * Obtains the physical address of MC portals
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * portal_id MC portal id
> + * portal_addr The physical address of the MC portal id
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_portal_paddr(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + int portal_id, uint64_t *portal_addr);
> +
> +/*
> + * Obtains container attributes
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * attributes Container attributes
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_attributes(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_attributes *attributes);
> +
> +/*
> + * Returns region information for a specified object.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * obj_type Object type as returned in dprc_get_obj()
> + * obj_id Unique object instance as returned in
> + * dprc_get_obj()
> + * region_index The specific region to query
> + * region_desc Returns the requested region descriptor
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_obj_region(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + char *obj_type,
> + int obj_id,
> + uint8_t region_index,
> + struct dprc_region_desc *region_desc);
> +
> +/*
> + * Sets IRQ information for the DPRC to trigger an interrupt.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index Identifies the interrupt index to configure
> + * DPRC supports only irq_index 0 - this interrupt
> + * will be signaled on every change to
> + * resource/object assignment in this DPRC.
> + * irq_paddr Physical IRQ address that must be written to
> + * signal a message-based interrupt
> + * irq_val Value to write into irq_paddr address
> + * user_irq_id A user defined number associated with this IRQ;
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_set_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index,
> + uint64_t irq_paddr, uint32_t irq_val, int user_irq_id);
> +
> +/*
> + * Gets IRQ information from the DPRC.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index The interrupt index to configure;
> + * DPRC supports only irq_index 0 - this interrupt
> + * will be signaled on every change to
> + * resource/object assignment in this DPRC.
> + * type Interrupt type: 0 represents message interrupt
> + * type (both irq_paddr and irq_val are valid);
> + * irq_paddr Physical address that must be written in order
> + * to signal the message-based interrupt
> + * irq_val Value to write in order to signal the
> + * message-based interrupt
> + * user_irq_id A user defined number associated with this IRQ;
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_irq(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index,
> + int *type,
> + uint64_t *irq_paddr, uint32_t *irq_val, int *user_irq_id);
> +
> +/*
> + * Sets overall interrupt state.
> + *
> + * Allows GPP software to control when interrupts are generated.
> + * Each interrupt can have up to 32 causes. The enable/disable control's the
> + * overall interrupt state. if the interrupt is disabled no causes will cause an
> + * interrupt.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index The interrupt index to configure
> + * enable_state Interrupt state - enable = 1, disable = 0.
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_set_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint8_t enable_state);
> +
> +/*
> + * Gets overall interrupt state
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index The interrupt index to configure
> + * enable_state Interrupt state - enable = 1, disable = 0.
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_irq_enable(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint8_t *enable_state);
> +
> +/*
> + * Sets interrupt mask.
> + *
> + * Every interrupt can have up to 32 causes and the interrupt model supports
> + * masking/unmasking each cause independently
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index The interrupt index to configure
> + * mask Event mask to trigger interrupt.
> + * each bit:
> + * 0 = ignore event
> + * 1 = consider event for asserting irq
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_set_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t mask);
> +
> +/*
> + * Gets interrupt mask.
> + *
> + * Every interrupt can have up to 32 causes and the interrupt model supports
> + * masking/unmasking each cause independently
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index The interrupt index to configure
> + * mask Event mask to trigger interrupt
> + *
> + * returns '0' on Success; Error code otherwise.
> + */
> +int dprc_get_irq_mask(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t *mask);
> +
> +/*
> + * Gets the current status of any pending interrupts.
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index The interrupt index to configure
> + * status Interrupts status - one bit per cause
> + * 0 = no interrupt pending
> + * 1 = interrupt pending
> + *
> + * returns '0' on Success; Error code otherwise.
> + * */
> +int dprc_get_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t *status);
> +
> +/*
> + * Clears a pending interrupt's status
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * irq_index The interrupt index to configure
> + * status Bits to clear (W1C) - one bit per cause
> + * 0 = don't change
> + * 1 = clear status bit
> + *
> + * returns '0' on Success; Error code otherwise.
> + * */
> +int dprc_clear_irq_status(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + uint8_t irq_index, uint32_t status);
> +
> +/*
> + * Connects two endpoints to create a network link between them
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * endpoint1 Endpoint 1 configuration parameters.
> + * endpoint2 Endpoint 2 configuration parameters.
> + *
> + * returns '0' on Success; Error code otherwise.
> + * */
> +int dprc_connect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_endpoint *endpoint1,
> + struct dprc_endpoint *endpoint2);
> +
> +/*
> + * Disconnects one endpoint to remove its network link
> + *
> + * mc_io Pointer to opaque I/O object
> + * dprc_handle Handle to the DPRC object
> + * endpoint Endpoint configuration parameters.
> + *
> + * returns '0' on Success; Error code otherwise.
> + * */
> +int dprc_disconnect(struct fsl_mc_io *mc_io, uint16_t dprc_handle,
> + struct dprc_endpoint *endpoint);
> +
> +/* */
> +
> +#endif /* _FSL_DPRC_H */
> diff --git a/include/linux/fsl/mc-cmd.h b/include/linux/fsl/mc-cmd.h
> new file mode 100644
> index 0000000..737e372
> --- /dev/null
> +++ b/include/linux/fsl/mc-cmd.h
> @@ -0,0 +1,169 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#ifndef __FSL_MC_CMD_H
> +#define __FSL_MC_CMD_H
> +
> +#include <linux/fsl/mc-sys.h>
> +
> +/*
> + * MC clients (GPP side) encode MC command parameters and decode MC response
> + * parameters
> + */
> +
> +#define MC_CMD_PARAM_OP(_cmd, _param, _offset, _width, _type, _arg) \
> + ((_cmd).params[_param] |= u64_enc((_offset), (_width), (_type)(_arg)))
> +
> +#define MC_RSP_PARAM_OP(_cmd, _param, _offset, _width, _type, _arg) \
> + ((_arg) = (_type)u64_dec((_cmd).params[_param], (_offset), (_width)))
> +
> +#define MAKE_UMASK64(_width) \
> + ((uint64_t)((_width) < 64 ? ((uint64_t)1 << (_width)) - 1 : -1))
> +
> +static inline uint64_t u64_enc(int lsoffset, int width, uint64_t val)
> +{
> + return (uint64_t)(((uint64_t)val & MAKE_UMASK64(width)) << lsoffset);
> +}
> +
> +static inline uint64_t u64_dec(uint64_t val, int lsoffset, int width)
> +{
> + return (uint64_t)((val >> lsoffset) & MAKE_UMASK64(width));
> +}

I find u64_enc and u64_dec slightly too common for functions that would
be defined inside of a device header. There's a good chance someone will
introduce functions that are called the same in some other place and
then we suddenly clash. How about mc_enc and mc_dec?

> +
> +#define MC_CMD_NUM_OF_PARAMS 7
> +
> +struct mc_command {
> + uint64_t header;
> + uint64_t params[MC_CMD_NUM_OF_PARAMS];
> +};
> +
> +enum mc_cmd_status {
> + MC_CMD_STATUS_OK = 0x0, /*!< Completed successfully */
> + MC_CMD_STATUS_READY = 0x1, /*!< Ready to be processed */
> + MC_CMD_STATUS_AUTH_ERR = 0x3, /*!< Authentication error */
> + MC_CMD_STATUS_NO_PRIVILEGE = 0x4, /*!< No privilege */
> + MC_CMD_STATUS_DMA_ERR = 0x5, /*!< DMA or I/O error */
> + MC_CMD_STATUS_CONFIG_ERR = 0x6, /*!< Configuration error */
> + MC_CMD_STATUS_TIMEOUT = 0x7, /*!< Operation timed out */
> + MC_CMD_STATUS_NO_RESOURCE = 0x8, /*!< No resources */
> + MC_CMD_STATUS_NO_MEMORY = 0x9, /*!< No memory available */
> + MC_CMD_STATUS_BUSY = 0xA, /*!< Device is busy */
> + MC_CMD_STATUS_UNSUPPORTED_OP = 0xB, /*!< Unsupported operation */
> + MC_CMD_STATUS_INVALID_STATE = 0xC /*!< Invalid state */
> +};
> +
> +#define MC_CMD_HDR_CMDID_O 52 /* Command ID field offset */
> +#define MC_CMD_HDR_CMDID_S 12 /* Command ID field size */
> +#define MC_CMD_HDR_AUTHID_O 38 /* Authentication ID field offset */
> +#define MC_CMD_HDR_AUTHID_S 10 /* Authentication ID field size */
> +#define MC_CMD_HDR_SIZE_O 31 /* Size field offset */
> +#define MC_CMD_HDR_SIZE_S 6 /* Size field size */
> +#define MC_CMD_HDR_STATUS_O 16 /* Status field offset */
> +#define MC_CMD_HDR_STATUS_S 8 /* Status field size */
> +#define MC_CMD_HDR_PRI_O 15 /* Priority field offset */
> +#define MC_CMD_HDR_PRI_S 1 /* Priority field size */
> +
> +#define MC_CMD_HDR_READ_STATUS(_hdr) \
> + ((enum mc_cmd_status)u64_dec((_hdr), \
> + MC_CMD_HDR_STATUS_O, MC_CMD_HDR_STATUS_S))
> +
> +#define MC_CMD_HDR_READ_AUTHID(_hdr) \
> + ((uint16_t)u64_dec((_hdr), MC_CMD_HDR_AUTHID_O, MC_CMD_HDR_AUTHID_S))
> +
> +#define MC_CMD_PRI_LOW 0 /*!< Low Priority command indication */
> +#define MC_CMD_PRI_HIGH 1 /*!< High Priority command indication */
> +
> +static inline uint64_t mc_encode_cmd_header(uint16_t cmd_id,
> + uint8_t cmd_size,
> + uint8_t priority, uint16_t auth_id)
> +{
> + uint64_t hdr;
> +
> + hdr = u64_enc(MC_CMD_HDR_CMDID_O, MC_CMD_HDR_CMDID_S, cmd_id);
> + hdr |= u64_enc(MC_CMD_HDR_AUTHID_O, MC_CMD_HDR_AUTHID_S, auth_id);
> + hdr |= u64_enc(MC_CMD_HDR_SIZE_O, MC_CMD_HDR_SIZE_S, cmd_size);
> + hdr |= u64_enc(MC_CMD_HDR_PRI_O, MC_CMD_HDR_PRI_S, priority);
> + hdr |= u64_enc(MC_CMD_HDR_STATUS_O, MC_CMD_HDR_STATUS_S,
> + MC_CMD_STATUS_READY);
> +
> + return hdr;
> +}
> +
> +/**
> + * mc_write_command - writes a command to a Management Complex (MC) portal
> + *
> + * @portal: pointer to an MC portal
> + * @cmd: pointer to a filled command
> + */
> +static inline void mc_write_command(struct mc_command __iomem *portal,
> + struct mc_command *cmd)

Why does this function live inside a header, not inside the only .c file
that uses it?


> +{
> + int i;
> +
> + /* copy command parameters into the portal */
> + for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++)
> + writeq(cmd->params[i], &portal->params[i]);

I'm sure you will want to optimize this to only write parameters that
are actually used later, but I guess for now it's good enough :). Better
start simple.

> +
> + /* submit the command by writing the header */
> + writeq(cmd->header, &portal->header);
> +}
> +
> +/**
> + * mc_read_response - reads the response for the last MC command from a
> + * Management Complex (MC) portal
> + *
> + * @portal: pointer to an MC portal
> + * @resp: pointer to command response buffer
> + *
> + * Returns MC_CMD_STATUS_OK on Success; Error code otherwise.
> + */
> +static inline enum mc_cmd_status mc_read_response(struct mc_command __iomem *
> + portal,
> + struct mc_command *resp)

Same here


Alex

> +{
> + int i;
> + enum mc_cmd_status status;
> +
> + /* Copy command response header from MC portal: */
> + resp->header = readq(&portal->header);
> + status = MC_CMD_HDR_READ_STATUS(resp->header);
> + if (status != MC_CMD_STATUS_OK)
> + return status;
> +
> + /* Copy command response data from MC portal: */
> + for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++)
> + resp->params[i] = readq(&portal->params[i]);
> +
> + return status;
> +}
> +
> +#endif /* __FSL_MC_CMD_H */
> diff --git a/include/linux/fsl/mc-sys.h b/include/linux/fsl/mc-sys.h
> new file mode 100644
> index 0000000..ee57cd6
> --- /dev/null
> +++ b/include/linux/fsl/mc-sys.h
> @@ -0,0 +1,68 @@
> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + * * Neither the name of the above-listed copyright holders nor the
> + * names of any contributors may be used to endorse or promote products
> + * derived from this software without specific prior written permission.
> + *
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation, either version 2 of that License or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#ifndef _FSL_MC_SYS_H
> +#define _FSL_MC_SYS_H
> +
> +#include <linux/types.h>
> +#include <linux/errno.h>
> +#include <linux/io.h>
> +#include <linux/dma-mapping.h>
> +
> +struct mc_command;
> +
> +/**
> + * struct fsl_mc_io - MC I/O object to be passed-in to mc_send_command()
> + * @dev: device associated with this Mc I/O object
> + * @flags: flags for mc_send_command()
> + * @portal_size: MC command portal size in bytes
> + * @portal_phys_addr: MC command portal physical address
> + * @portal_virt_addr: MC command portal virtual address
> + */
> +struct fsl_mc_io {
> + struct device *dev;
> + uint32_t flags;
> + uint32_t portal_size;
> + phys_addr_t portal_phys_addr;
> + void __iomem *portal_virt_addr;
> +};
> +
> +int __must_check fsl_create_mc_io(struct device *dev,
> + phys_addr_t mc_portal_phys_addr,
> + uint32_t mc_portal_size,
> + uint32_t flags, struct fsl_mc_io **new_mc_io);
> +
> +void fsl_destroy_mc_io(struct fsl_mc_io *mc_io);
> +
> +int mc_send_command(struct fsl_mc_io *mc_io, struct mc_command *cmd);
> +
> +#endif /* _FSL_MC_SYS_H */
> --
> 1.7.9.7
>

2014-11-06 13:50:24

by Alexander Graf

[permalink] [raw]
Subject: Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver



On 04.10.14 15:23, J. German Rivera wrote:
> From: "J. German Rivera" <[email protected]>
>
> Platform device driver that sets up the basic bus infrastructure
> for the fsl-mc bus type, including support for adding/removing
> fsl-mc devices, register/unregister of fsl-mc drivers, and bus
> match support to bind devices to drivers.
>
> Signed-off-by: J. German Rivera <[email protected]>
> Signed-off-by: Stuart Yoder <[email protected]>
> ---
> Changes in v3:
> - Addressed changes from Kim Phillips:
> * Renamed files:
> drivers/bus/fsl-mc/fsl_mc_bus.c -> drivers/bus/fsl-mc/mc-bus.c
> include/linux/fsl_mc.h -> include/linux/fsl/mc.h
> include/linux/fsl_mc_private.h -> include/linux/fsl/mc-private.h
>
> - Addressed comments from Timur Tabi:
> * Changed all functions that had goto out/error when no common cleanup
> was done, to just have multiple return points.
> * Replaced error cleanup boolean flags with multiple exit points.
>
> Changes in v2:
> - Addressed comment from Joe Perches:
> * Changed pr_debug to dev_dbg in fsl_mc_bus_match
>
> - Addressed comments from Kim Phillips and Alex Graf:
> * Changed version check to allow the driver to run with MC
> firmware that has major version number greater than or equal
> to the driver's major version number.
> * Removed minor version check
>
> - Removed unused variable parent_dev in fsl_mc_device_remove
>
> drivers/bus/Kconfig | 3 +
> drivers/bus/Makefile | 3 +
> drivers/bus/fsl-mc/Kconfig | 13 +
> drivers/bus/fsl-mc/Makefile | 14 +
> drivers/bus/fsl-mc/mc-bus.c | 566 ++++++++++++++++++++++++++++++++++++++++
> include/linux/fsl/mc-private.h | 33 +++
> include/linux/fsl/mc.h | 137 ++++++++++
> 7 files changed, 769 insertions(+)
> create mode 100644 drivers/bus/fsl-mc/Kconfig
> create mode 100644 drivers/bus/fsl-mc/Makefile
> create mode 100644 drivers/bus/fsl-mc/mc-bus.c
> create mode 100644 include/linux/fsl/mc-private.h
> create mode 100644 include/linux/fsl/mc.h
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 603eb1b..2fbb1fd 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -67,4 +67,7 @@ config VEXPRESS_CONFIG
> help
> Platform configuration infrastructure for the ARM Ltd.
> Versatile Express.
> +
> +source "drivers/bus/fsl-mc/Kconfig"
> +
> endmenu
> diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
> index 2973c18..6abcab1 100644
> --- a/drivers/bus/Makefile
> +++ b/drivers/bus/Makefile
> @@ -15,3 +15,6 @@ obj-$(CONFIG_ARM_CCI) += arm-cci.o
> obj-$(CONFIG_ARM_CCN) += arm-ccn.o
>
> obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress-config.o
> +
> +# Freescale Management Complex (MC) bus drivers
> +obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/
> diff --git a/drivers/bus/fsl-mc/Kconfig b/drivers/bus/fsl-mc/Kconfig
> new file mode 100644
> index 0000000..e3226f9
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/Kconfig
> @@ -0,0 +1,13 @@
> +#
> +# Freescale Management Complex (MC) bus drivers
> +#
> +# Copyright (C) 2014 Freescale Semiconductor, Inc.
> +#
> +# This file is released under the GPLv2
> +#
> +
> +config FSL_MC_BUS
> + tristate "Freescale Management Complex (MC) bus driver"
> + help
> + Driver to enable the bus infrastructure for the Freescale
> + QorIQ Management Complex.

Isn't this missing some scope limitations? Should we really have the
driver enabled on x86 for example?

I would also make this slightly more verbose. People don't necessarily
know what the QorIQ Management Complex is. Give people some idea what
they're dealing with and preferably tell them hints that guide them from
"SoC name" to "should I enable this option?".

Also, usually the help text gives some guidance on what to do with the
option if you're not sure. In this case, I would say advise the user to
say N.


Alex

2014-11-06 13:51:23

by Alexander Graf

[permalink] [raw]
Subject: Re: [PATCH 3/3 v3] drivers/bus: Device driver for FSL-MC DPRC devices



On 04.10.14 15:23, J. German Rivera wrote:
> From: "J. German Rivera" <[email protected]>
>
> A DPRC (Data Path Resource Container) is an isolation device
> that contains a set of DPAA networking devices to be
> assigned to an isolation domain (e.g., a virtual machine).
>
> Signed-off-by: J. German Rivera <[email protected]>
> Signed-off-by: Stuart Yoder <[email protected]>
> ---
> Changes in v3:
> - Addressed comments from Kim Phillips:
> * Renamed files:
> drivers/bus/fsl-mc/fsl_mc_dprc.c -> drivers/bus/fsl-mc/dprc-driver.c
>
> - Addressed comments from Timur Tabi:
> * Changed dprc_scan_container() to just return dprc_scan_objects()
> * Changed all functions that had goto out/error when no common cleanup
> was done, to just have multiple return points.
> * Replaced error cleanup boolean flags with multiple exit points.
> * REmoved __must_chewck from dprc_scan_*() functions
>
> Changes in v2:
> - Addressed comments from Kim Phillips:
> * Fix warning in drivers/bus/fsl-mc/fsl_mc_dprc.c:173
> * Fixed linker errors when MC bus driver built as module
>
> drivers/bus/fsl-mc/Makefile | 3 +-
> drivers/bus/fsl-mc/dprc-driver.c | 383 ++++++++++++++++++++++++++++++++++++++
> drivers/bus/fsl-mc/mc-bus.c | 8 +
> include/linux/fsl/mc-private.h | 10 +
> 4 files changed, 403 insertions(+), 1 deletion(-)
> create mode 100644 drivers/bus/fsl-mc/dprc-driver.c
>
> diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
> index decd339..424e58e 100644
> --- a/drivers/bus/fsl-mc/Makefile
> +++ b/drivers/bus/fsl-mc/Makefile
> @@ -10,5 +10,6 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
> mc-bus-driver-objs := mc-bus.o \
> mc-sys.o \
> dprc.o \
> - dpmng.o
> + dpmng.o \
> + dprc-driver.o
>
> diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
> new file mode 100644
> index 0000000..8be6a2a
> --- /dev/null
> +++ b/drivers/bus/fsl-mc/dprc-driver.c
> @@ -0,0 +1,383 @@
> +/*
> + * Freescale daata path resource container (DPRC) driver

daata? ;)

Is there any way I can play with this bus? How far do I get with only
these 3 patches applied today?


Alex

2014-11-10 04:44:06

by Timur Tabi

[permalink] [raw]
Subject: Re: [PATCH 3/3 v3] drivers/bus: Device driver for FSL-MC DPRC devices

On Mon, Oct 6, 2014 at 9:48 AM, German Rivera
<[email protected]> wrote:
>>
>> I didn't notice this earlier, but I it was Freescale policy to use
>> EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL(). Has that changed?
>>
> Please see change history in the cover letter for this patch series.

So I looked at the change history, and I looked at
http://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg708858.html,
and I don't see any explanation why you changed it to _GPL. Like I
said, last I checked, it was Freescale policy to use EXPORT_SYMBOL
only, so I still don't understand why you made the change.

2014-11-12 02:02:06

by J. German Rivera

[permalink] [raw]
Subject: Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

On 11/06/2014 07:50 AM, Alexander Graf wrote:
>
[cut]
>> +++ b/drivers/bus/fsl-mc/Kconfig
>> @@ -0,0 +1,13 @@
>> +#
>> +# Freescale Management Complex (MC) bus drivers
>> +#
>> +# Copyright (C) 2014 Freescale Semiconductor, Inc.
>> +#
>> +# This file is released under the GPLv2
>> +#
>> +
>> +config FSL_MC_BUS
>> + tristate "Freescale Management Complex (MC) bus driver"
>> + help
>> + Driver to enable the bus infrastructure for the Freescale
>> + QorIQ Management Complex.
>
> Isn't this missing some scope limitations? Should we really have the
> driver enabled on x86 for example?
>
I will add depends on OF && ARM64

> I would also make this slightly more verbose. People don't necessarily
> know what the QorIQ Management Complex is. Give people some idea what
> they're dealing with and preferably tell them hints that guide them from
> "SoC name" to "should I enable this option?".
>
> Also, usually the help text gives some guidance on what to do with the
> option if you're not sure. In this case, I would say advise the user to
> say N.
>
Will do.

>
> Alex
>

2014-11-12 01:22:55

by J. German Rivera

[permalink] [raw]
Subject: Re: [PATCH 1/3 v3] drivers/bus: Added Freescale Management Complex APIs

On 11/06/2014 07:49 AM, Alexander Graf wrote:
>
>
> On 04.10.14 15:23, J. German Rivera wrote:
>> From: "J. German Rivera" <[email protected]>
>>
>> APIs to access the Management Complex (MC) hardware
>> module of Freescale LS2 SoCs. This patch includes
>> APIs to check the MC firmware version and to manipulate
>> DPRC objects in the MC.
>>
>> Signed-off-by: J. German Rivera <[email protected]>
>> Signed-off-by: Stuart Yoder <[email protected]>
>> ---
[cut]
>> diff --git a/drivers/bus/fsl-mc/dpmng.c b/drivers/bus/fsl-mc/dpmng.c
>> new file mode 100644
>> index 0000000..8a32448
>> --- /dev/null
>> +++ b/drivers/bus/fsl-mc/dpmng.c
>> @@ -0,0 +1,94 @@
>
> I don't think it's extremely obvious what "dpmng" means, so having some
> description at the head of the file makes things a lot easier to understand.
>
> This obviously applies to all files, not just this one ;).
>
Done

>> +/* Copyright 2013-2014 Freescale Semiconductor Inc.
[cut]
>> +
>> +int mc_get_version(struct fsl_mc_io *mc_io, struct mc_version *mc_ver_info)
>> +{
>> + struct mc_command cmd = { 0 };
>> + int err;
>> +
>> + cmd.header = mc_encode_cmd_header(DPMNG_CMDID_GET_VERSION,
>> + DPMNG_CMDSZ_GET_VERSION,
>> + MC_CMD_PRI_LOW, 0);
>> +
>> + err = mc_send_command(mc_io, &cmd);
>> + if (err)
>> + return err;
>> +
>> + DPMNG_RSP_GET_VERSION(cmd, mc_ver_info);
>
> Sorry if this came up before, but you have all these nicely abstracted
> helper functions (like mc_get_version()) to encapsulate command
> submission. Why do you need to call yet another macro inside of it to
> extract all of the fields?
>
> I would find a simple
>
> mc_ver_info->revision = u64_dec(cmd.params[0], 0, 32);
> mc_ver_info->major = u64_dec(cmd.params[0], 32, 32);
> mc_ver_info->minor = u64_dec(cmd.params[1], 0, 8);
>
> right here a lot more easy to understand.
>
>> + return 0;
>> +}
>> +
>> +int dpmng_reset_aiop(struct fsl_mc_io *mc_io, int aiop_tile_id)
>> +{
>> + struct mc_command cmd = { 0 };
>> +
>> + cmd.header = mc_encode_cmd_header(DPMNG_CMDID_RESET_AIOP,
>> + DPMNG_CMDSZ_RESET_AIOP,
>> + MC_CMD_PRI_LOW, 0);
>> +
>> + DPMNG_CMD_RESET_AIOP(cmd, aiop_tile_id);
>
> The same goes here. Imagine this would be
>
> cmd.params[0] |= u64_enc(0, 32, aiop_tile_id);
>
> then it would be immediately clear that we're modifying the parameters
> for cmd. With the macro as is, the occasional reader would have no idea
> what fields are different from before after the call.
>
> I think if you do this for all the functions in the patch, you will see
> that the code will suddenly become crystal clear to read.
>
Done.

[cut]
>> +static int mc_status_to_error(enum mc_cmd_status status)
>> +{
>> + static const int mc_status_to_error_map[] = {
>> + [MC_CMD_STATUS_OK] = 0,
>> + [MC_CMD_STATUS_AUTH_ERR] = -EACCES,
>> + [MC_CMD_STATUS_NO_PRIVILEGE] = -EPERM,
>> + [MC_CMD_STATUS_DMA_ERR] = -EIO,
>> + [MC_CMD_STATUS_CONFIG_ERR] = -ENXIO,
>> + [MC_CMD_STATUS_TIMEOUT] = -ETIMEDOUT,
>> + [MC_CMD_STATUS_NO_RESOURCE] = -ENAVAIL,
>> + [MC_CMD_STATUS_NO_MEMORY] = -ENOMEM,
>> + [MC_CMD_STATUS_BUSY] = -EBUSY,
>> + [MC_CMD_STATUS_UNSUPPORTED_OP] = -ENOTSUPP,
>> + [MC_CMD_STATUS_INVALID_STATE] = -ENODEV,
>> + };
>> +
>> + if (WARN_ON(status >= ARRAY_SIZE(mc_status_to_error_map)))
>> + return -EINVAL;
>
> Unfortunately gcc may or may not make the enum signed. If it's signed,
> this check will not catch the case where the number is negative.
>
> Maybe cast status to u32 to explicitly make sure we catch negative
> values as well?
>
Done.

[cut]
>> +
>> +#define MC_CMD_PARAM_OP(_cmd, _param, _offset, _width, _type, _arg) \
>> + ((_cmd).params[_param] |= u64_enc((_offset), (_width), (_type)(_arg)))
>> +
>> +#define MC_RSP_PARAM_OP(_cmd, _param, _offset, _width, _type, _arg) \
>> + ((_arg) = (_type)u64_dec((_cmd).params[_param], (_offset), (_width)))
>> +
>> +#define MAKE_UMASK64(_width) \
>> + ((uint64_t)((_width) < 64 ? ((uint64_t)1 << (_width)) - 1 : -1))
>> +
>> +static inline uint64_t u64_enc(int lsoffset, int width, uint64_t val)
>> +{
>> + return (uint64_t)(((uint64_t)val & MAKE_UMASK64(width)) << lsoffset);
>> +}
>> +
>> +static inline uint64_t u64_dec(uint64_t val, int lsoffset, int width)
>> +{
>> + return (uint64_t)((val >> lsoffset) & MAKE_UMASK64(width));
>> +}
>
> I find u64_enc and u64_dec slightly too common for functions that would
> be defined inside of a device header. There's a good chance someone will
> introduce functions that are called the same in some other place and
> then we suddenly clash. How about mc_enc and mc_dec?
>
Sounds good.

[cut]
>> +
>> +/**
>> + * mc_write_command - writes a command to a Management Complex (MC) portal
>> + *
>> + * @portal: pointer to an MC portal
>> + * @cmd: pointer to a filled command
>> + */
>> +static inline void mc_write_command(struct mc_command __iomem *portal,
>> + struct mc_command *cmd)
>
> Why does this function live inside a header, not inside the only .c file
> that uses it?
>
Function moved to the .c file.

>
>> +{
>> + int i;
>> +
>> + /* copy command parameters into the portal */
>> + for (i = 0; i < MC_CMD_NUM_OF_PARAMS; i++)
>> + writeq(cmd->params[i], &portal->params[i]);
>
> I'm sure you will want to optimize this to only write parameters that
> are actually used later, but I guess for now it's good enough :). Better
> start simple.
>
>> +
>> + /* submit the command by writing the header */
>> + writeq(cmd->header, &portal->header);
>> +}
>> +
>> +/**
>> + * mc_read_response - reads the response for the last MC command from a
>> + * Management Complex (MC) portal
>> + *
>> + * @portal: pointer to an MC portal
>> + * @resp: pointer to command response buffer
>> + *
>> + * Returns MC_CMD_STATUS_OK on Success; Error code otherwise.
>> + */
>> +static inline enum mc_cmd_status mc_read_response(struct mc_command __iomem *
>> + portal,
>> + struct mc_command *resp)
>
> Same here
>
Function moved to the .c file

Thanks,

German

2014-11-13 17:38:06

by J. German Rivera

[permalink] [raw]
Subject: Re: [PATCH 3/3 v3] drivers/bus: Device driver for FSL-MC DPRC devices



On 11/06/2014 07:51 AM, Alexander Graf wrote:
>
>
> On 04.10.14 15:23, J. German Rivera wrote:
>> From: "J. German Rivera" <[email protected]>
>>
>> A DPRC (Data Path Resource Container) is an isolation device
>> that contains a set of DPAA networking devices to be
>> assigned to an isolation domain (e.g., a virtual machine).
>>
>> Signed-off-by: J. German Rivera <[email protected]>
>> Signed-off-by: Stuart Yoder <[email protected]>
>> ---
>> Changes in v3:
>> - Addressed comments from Kim Phillips:
>> * Renamed files:
>> drivers/bus/fsl-mc/fsl_mc_dprc.c -> drivers/bus/fsl-mc/dprc-driver.c
>>
>> - Addressed comments from Timur Tabi:
>> * Changed dprc_scan_container() to just return dprc_scan_objects()
>> * Changed all functions that had goto out/error when no common cleanup
>> was done, to just have multiple return points.
>> * Replaced error cleanup boolean flags with multiple exit points.
>> * REmoved __must_chewck from dprc_scan_*() functions
>>
>> Changes in v2:
>> - Addressed comments from Kim Phillips:
>> * Fix warning in drivers/bus/fsl-mc/fsl_mc_dprc.c:173
>> * Fixed linker errors when MC bus driver built as module
>>
>> drivers/bus/fsl-mc/Makefile | 3 +-
>> drivers/bus/fsl-mc/dprc-driver.c | 383 ++++++++++++++++++++++++++++++++++++++
>> drivers/bus/fsl-mc/mc-bus.c | 8 +
>> include/linux/fsl/mc-private.h | 10 +
>> 4 files changed, 403 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/bus/fsl-mc/dprc-driver.c
>>
>> diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
>> index decd339..424e58e 100644
>> --- a/drivers/bus/fsl-mc/Makefile
>> +++ b/drivers/bus/fsl-mc/Makefile
>> @@ -10,5 +10,6 @@ obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
>> mc-bus-driver-objs := mc-bus.o \
>> mc-sys.o \
>> dprc.o \
>> - dpmng.o
>> + dpmng.o \
>> + dprc-driver.o
>>
>> diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
>> new file mode 100644
>> index 0000000..8be6a2a
>> --- /dev/null
>> +++ b/drivers/bus/fsl-mc/dprc-driver.c
>> @@ -0,0 +1,383 @@
>> +/*
>> + * Freescale daata path resource container (DPRC) driver
>
> daata? ;)
>
Fixed.

> Is there any way I can play with this bus? How far do I get with only
> these 3 patches applied today?
>
With these three patches applied you will be able to see the fsl-mc bus
added in sysfs and the device present in the root DPRC.
Also, since this patch series only contains one MC object driver
(the driver for DPRC objects), you will be able so see that
driver under the fsl-mc bus. Below is a fragment of console
output with an example to illustrate this:

root@ls2085a-simu:~# find /sys/bus/fsl-mc/
/sys/bus/fsl-mc/
/sys/bus/fsl-mc/devices
/sys/bus/fsl-mc/devices/dpbp.1
/sys/bus/fsl-mc/devices/dpio.1
/sys/bus/fsl-mc/devices/dpni.1
/sys/bus/fsl-mc/devices/dprc.1
/sys/bus/fsl-mc/drivers
/sys/bus/fsl-mc/drivers/fsl_mc_dprc
/sys/bus/fsl-mc/drivers/fsl_mc_dprc/bind
/sys/bus/fsl-mc/drivers/fsl_mc_dprc/dprc.1
/sys/bus/fsl-mc/drivers/fsl_mc_dprc/uevent
/sys/bus/fsl-mc/drivers/fsl_mc_dprc/unbind
/sys/bus/fsl-mc/uevent
/sys/bus/fsl-mc/drivers_probe
/sys/bus/fsl-mc/drivers_autoprobe

root@ls2085a-simu:~# ls -l /sys/bus/fsl-mc/devices/dprc.1/
drwxr-xr-x 3 root root 0 Jan 1 1970 dpbp.1
drwxr-xr-x 3 root root 0 Jan 1 1970 dpio.1
drwxr-xr-x 3 root root 0 Jan 1 1970 dpni.1
lrwxrwxrwx 1 root root 0 Nov 7 20:38 driver ->
../../../bus/fsl-mc/drivers/fsl_mc_dprc
drwxr-xr-x 2 root root 0 Nov 7 20:38 power
lrwxrwxrwx 1 root root 0 Jan 1 1970 subsystem ->
../../../bus/fsl-mc
-rw-r--r-- 1 root root 4096 Jan 1 1970 uevent

Thanks,

German

>
> Alex
>