2022-08-03 19:50:23

by Maya Matuszczyk

Subject: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

From: Maya Matuszczyk <[email protected]>

This device is another x86 gaming handheld, and as (hopefully) there is
only one set of DMI IDs it's using DMI_EXACT_MATCH

Signed-off-by: Maya Matuszczyk <[email protected]>
---
drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index d4e0f2e85548..a8681610ede7 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
},
.driver_data = (void *)&lcd800x1280_rightside_up,
+ }, { /* Anbernic Win600 */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
+ },
+ .driver_data = (void *)&lcd720x1280_rightside_up,
}, { /* Asus T100HA */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
--
2.37.1

2022-08-04 08:41:46

by Hans de Goede

Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

Hi,

On 8/3/22 20:24, Maccraft123 wrote:
> From: Maya Matuszczyk <[email protected]>
>
> This device is another x86 gaming handheld, and as (hopefully) there is
> only one set of DMI IDs it's using DMI_EXACT_MATCH
>
> Signed-off-by: Maya Matuszczyk <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Since we are currently in the middle of the merge window
and this patch needs to go to a -fixes branch I'm not quite
sure how to handle this.

Hopefully one of the drm-misc maintainers can pick this
up (once rc1 is out?) .

Regards,

Hans



> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index d4e0f2e85548..a8681610ede7 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
> },
> .driver_data = (void *)&lcd800x1280_rightside_up,
> + }, { /* Anbernic Win600 */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
> + },
> + .driver_data = (void *)&lcd720x1280_rightside_up,
> }, { /* Asus T100HA */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),

2022-08-19 17:41:34

by Maya Matuszczyk

Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

Hello,

czw., 4 sie 2022 o 10:32 Hans de Goede <[email protected]> napisał(a):
>
> Hi,
>
> On 8/3/22 20:24, Maccraft123 wrote:
> > From: Maya Matuszczyk <[email protected]>
> >
> > This device is another x86 gaming handheld, and as (hopefully) there is
> > only one set of DMI IDs it's using DMI_EXACT_MATCH
> >
> > Signed-off-by: Maya Matuszczyk <[email protected]>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <[email protected]>
>
> Since we are currently in the middle of the merge window
> and this patch needs to go to a -fixes branch I'm not quite
> sure how to handle this.
>
> Hopefully one of the drm-misc maintainers can pick this
> up (once rc1 is out?) .

We're at -rc1 now, and -rc2 will likely release within couple
of days, can anyone take a look at this patch now?

Best Regards,
Maya Matuszczyk

>
> Regards,
>
> Hans
>
>
>
> > ---
> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index d4e0f2e85548..a8681610ede7 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
> > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
> > },
> > .driver_data = (void *)&lcd800x1280_rightside_up,
> > + }, { /* Anbernic Win600 */
> > + .matches = {
> > + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
> > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
> > + },
> > + .driver_data = (void *)&lcd720x1280_rightside_up,
> > }, { /* Asus T100HA */
> > .matches = {
> > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>

2022-09-17 13:25:10

by Hans de Goede

Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

Hi,

On 8/3/22 20:24, Maccraft123 wrote:
> From: Maya Matuszczyk <[email protected]>
>
> This device is another x86 gaming handheld, and as (hopefully) there is
> only one set of DMI IDs it's using DMI_EXACT_MATCH
>
> Signed-off-by: Maya Matuszczyk <[email protected]>

Thanks I have added this patch to my local drm-misc-next branch.

I will push this out to the official drm-misc-next branch after
running some local tests.

(unfortunately it is too late now to push this to drm-misc-fixes
for this cycle, sorry).

Regards,

Hans



> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index d4e0f2e85548..a8681610ede7 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
> },
> .driver_data = (void *)&lcd800x1280_rightside_up,
> + }, { /* Anbernic Win600 */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
> + },
> + .driver_data = (void *)&lcd720x1280_rightside_up,
> }, { /* Asus T100HA */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),

2022-09-17 18:08:03

by Maya Matuszczyk

Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

Hello,

sob., 17 wrz 2022 o 15:04 Hans de Goede <[email protected]> napisał(a):
>
> Hi,
>
> On 8/3/22 20:24, Maccraft123 wrote:
> > From: Maya Matuszczyk <[email protected]>
> >
> > This device is another x86 gaming handheld, and as (hopefully) there is
> > only one set of DMI IDs it's using DMI_EXACT_MATCH
> >
> > Signed-off-by: Maya Matuszczyk <[email protected]>
>
> Thanks I have added this patch to my local drm-misc-next branch.
>
> I will push this out to the official drm-misc-next branch after
> running some local tests.

Can you also take a look at this patch too?
https://patchwork.freedesktop.org/patch/499589/

Best Regards,
Maya Matuszczyk

>
> (unfortunately it is too late now to push this to drm-misc-fixes
> for this cycle, sorry).
>
> Regards,
>
> Hans
>
>
>
> > ---
> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index d4e0f2e85548..a8681610ede7 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
> > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
> > },
> > .driver_data = (void *)&lcd800x1280_rightside_up,
> > + }, { /* Anbernic Win600 */
> > + .matches = {
> > + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
> > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
> > + },
> > + .driver_data = (void *)&lcd720x1280_rightside_up,
> > }, { /* Asus T100HA */
> > .matches = {
> > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
>