2017-08-30 13:07:16

by Stephen Rothwell

Subject: linux-next: Signed-off-by missing for commit in the arm-soc tree

Hi all,

Commit

1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")

is missing a Signed-off-by from its author.

--
Cheers,
Stephen Rothwell

2017-08-30 13:19:34

by Alexandre Belloni

Subject: Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
>
> is missing a Signed-off-by from its author.
>

Oh crap, it was the only one not in linux-next... iThe original
submission had the SoB:
https://patchwork.kernel.org/patch/9794803/

Olof, how do you want to proceed?

> --
> Cheers,
> Stephen Rothwell

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

2017-08-30 16:21:53

by Olof Johansson

Subject: Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
<[email protected]> wrote:
> On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>> 1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
>>
>> is missing a Signed-off-by from its author.
>>
>
> Oh crap, it was the only one not in linux-next... iThe original
> submission had the SoB:
> https://patchwork.kernel.org/patch/9794803/
>
> Olof, how do you want to proceed?

Please prepare a new branch. I'll rebuild next/dt (and our for-next)
to drop your previous version, and merge it when it's ready.

Thanks for the heads up, Stephen. I presume you have a script that
checks this? It's something we should run too, do you keep it in a
shared location?


-Olof

2017-08-30 16:42:03

by Alexandre Belloni

Subject: Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

On 30/08/2017 at 09:21:47 -0700, Olof Johansson wrote:
> On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
> <[email protected]> wrote:
> > On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Commit
> >>
> >> 1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
> >>
> >> is missing a Signed-off-by from its author.
> >>
> >
> > Oh crap, it was the only one not in linux-next... iThe original
> > submission had the SoB:
> > https://patchwork.kernel.org/patch/9794803/
> >
> > Olof, how do you want to proceed?
>
> Please prepare a new branch. I'll rebuild next/dt (and our for-next)
> to drop your previous version, and merge it when it's ready.
>
> Thanks for the heads up, Stephen. I presume you have a script that
> checks this? It's something we should run too, do you keep it in a
> shared location?
>

Yeah, I'm interested as well as I'm already using a pre_push hook to check
that my SoB is there.


--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

2017-08-30 17:21:52

by Stephen Rothwell

Subject: Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

Hi Olof,

On Wed, 30 Aug 2017 09:21:47 -0700 Olof Johansson <[email protected]> wrote:
>
> Thanks for the heads up, Stephen. I presume you have a script that
> checks this? It's something we should run too, do you keep it in a
> shared location?

Script below.

--
Cheers,
Stephen Rothwell

#!/bin/bash

if [ "$#" -lt 1 ]; then
printf "Usage: %s <commit range>\n", "$0" 1>&2
exit 1
fi

for c in $(git rev-list --no-merges "$@"); do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i '^[[:space:]]*Signed-off-by:')

am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true

if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done

exec gitk "$@"