2018-07-15 22:08:18

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commits in the amlogic tree

Hi all,

Commits

3f1ad8c53b29 ("ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi")
4dabd157d48e ("ARM64: dts: meson-gx-p23x-q20x: move the wifi node to each board's .dts")

are missing a Signed-off-by from their committer.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-07-19 19:27:43

by Kevin Hilman

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the amlogic tree

Stephen Rothwell <[email protected]> writes:

> Commits
>
> 3f1ad8c53b29 ("ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi")
> 4dabd157d48e ("ARM64: dts: meson-gx-p23x-q20x: move the wifi node to each board's .dts")
>
> are missing a Signed-off-by from their committer.

Oops. I missed these.

Olof, these were just merged by you in my PR[1]. How do you want me to
handle this?

I could respin the PR, or just send another with them reverted then
re-applied with signoff?

Or, since these branches don't need to be static (yet), I suppose you
could just edit the commits and add my signoff.

I'm OK with any of the above, let me know your preferene.

Kevin

[1] https://marc.info/?l=linux-arm-kernel&m=153184268320170

2018-07-19 21:58:10

by Olof Johansson

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the amlogic tree

On Thu, Jul 19, 2018 at 12:26 PM, Kevin Hilman <[email protected]> wrote:
> Stephen Rothwell <[email protected]> writes:
>
>> Commits
>>
>> 3f1ad8c53b29 ("ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi")
>> 4dabd157d48e ("ARM64: dts: meson-gx-p23x-q20x: move the wifi node to each board's .dts")
>>
>> are missing a Signed-off-by from their committer.
>
> Oops. I missed these.
>
> Olof, these were just merged by you in my PR[1]. How do you want me to
> handle this?
>
> I could respin the PR, or just send another with them reverted then
> re-applied with signoff?
>
> Or, since these branches don't need to be static (yet), I suppose you
> could just edit the commits and add my signoff.
>
> I'm OK with any of the above, let me know your preferene.

Hi,

Fresh pull requests is probably easiest for all. I'll drop the one I brought in.


-Olof

2018-07-20 15:24:48

by Kevin Hilman

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the amlogic tree

Olof Johansson <[email protected]> writes:

> On Thu, Jul 19, 2018 at 12:26 PM, Kevin Hilman <[email protected]> wrote:
>> Stephen Rothwell <[email protected]> writes:
>>
>>> Commits
>>>
>>> 3f1ad8c53b29 ("ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi")
>>> 4dabd157d48e ("ARM64: dts: meson-gx-p23x-q20x: move the wifi node to each board's .dts")
>>>
>>> are missing a Signed-off-by from their committer.
>>
>> Oops. I missed these.
>>
>> Olof, these were just merged by you in my PR[1]. How do you want me to
>> handle this?
>>
>> I could respin the PR, or just send another with them reverted then
>> re-applied with signoff?
>>
>> Or, since these branches don't need to be static (yet), I suppose you
>> could just edit the commits and add my signoff.
>>
>> I'm OK with any of the above, let me know your preferene.
>
> Hi,
>
> Fresh pull requests is probably easiest for all. I'll drop the one I brought in.
>

Ack, I'll resend. Thanks.

Kevin