2018-07-11 14:28:54

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs

This allows to derive the kernel flavor from the kernel version at
runtime.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
v2:
- Handle "new" multi_v4t_defconfig.
---
arch/arm/configs/multi_v4t_defconfig | 1 +
arch/arm/configs/multi_v5_defconfig | 1 +
arch/arm/configs/multi_v7_defconfig | 1 +
3 files changed, 3 insertions(+)

diff --git a/arch/arm/configs/multi_v4t_defconfig b/arch/arm/configs/multi_v4t_defconfig
index 9a6390c172d6b676..9bbb76e8260611df 100644
--- a/arch/arm/configs/multi_v4t_defconfig
+++ b/arch/arm/configs/multi_v4t_defconfig
@@ -1,3 +1,4 @@
+CONFIG_LOCALVERSION="-multi_v4t"
CONFIG_KERNEL_LZMA=y
CONFIG_SYSVIPC=y
CONFIG_LOG_BUF_SHIFT=14
diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/multi_v5_defconfig
index 7c41bee284630d14..5797c8b40c763b55 100644
--- a/arch/arm/configs/multi_v5_defconfig
+++ b/arch/arm/configs/multi_v5_defconfig
@@ -1,3 +1,4 @@
+CONFIG_LOCALVERSION="-multi_v5"
CONFIG_SYSVIPC=y
CONFIG_FHANDLE=y
CONFIG_NO_HZ=y
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 4c71fcb03bccfb8d..155d1eb10c6580fe 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -1,3 +1,4 @@
+CONFIG_LOCALVERSION="-multi_v7"
CONFIG_SYSVIPC=y
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
--
2.17.1



2018-07-12 03:01:22

by Olof Johansson

[permalink] [raw]
Subject: Re: [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs

Hi,

On Wed, Jul 11, 2018 at 7:26 AM, Geert Uytterhoeven
<[email protected]> wrote:
> This allows to derive the kernel flavor from the kernel version at
> runtime.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

I prefer not to have this go in -- this is extremely likely to creep
into derivative configs and as such it would have no value (you can't
be sure it's still the same config).

/proc/config.gz is the way to keep track of exactly what config you're
running anyway, right?

-Olof

2018-07-12 07:26:19

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] ARM: defconfig: Set CONFIG_LOCALVERSION in multi v4t/v5/v7 defconfigs

Hi Olof,

On Wed, Jul 11, 2018 at 11:46 PM Olof Johansson <[email protected]> wrote:
> On Wed, Jul 11, 2018 at 7:26 AM, Geert Uytterhoeven
> <[email protected]> wrote:
> > This allows to derive the kernel flavor from the kernel version at
> > runtime.
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> I prefer not to have this go in -- this is extremely likely to creep
> into derivative configs and as such it would have no value (you can't
> be sure it's still the same config).

Fair enough. Unfortunately we cannot prevent that from happening :-(

> /proc/config.gz is the way to keep track of exactly what config you're
> running anyway, right?

Yes, in some convoluted and hard to identify way ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds