2020-08-21 05:21:36

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commits in the arm-soc-fixes tree

Hi all,

Commits

8d53ecfbf231 ("arm64: dts: xilinx: Align IOMMU nodename with dtschema")
b4b6fb8de8dc ("arm64: dts: zynqmp: Add GTR transceivers")

are missing a Signed-off-by from their committer.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2020-08-21 17:09:54

by Olof Johansson

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the arm-soc-fixes tree

Hi,

On Thu, Aug 20, 2020 at 10:19 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> Commits
>
> 8d53ecfbf231 ("arm64: dts: xilinx: Align IOMMU nodename with dtschema")
> b4b6fb8de8dc ("arm64: dts: zynqmp: Add GTR transceivers")
>
> are missing a Signed-off-by from their committer.

Ah, I see what happened here. I've been relying on some of my
semi-automation scripts for catching this, but I had to use regular
manual git merge for this branch due to GPG signatures not capturing
it in patchwork.

Since the committer was Michal, and the pull request came from him, we
still have the chain of contribution documented, but I'll keep this in
mind on future manual merges.


-Olof

2020-08-24 07:21:01

by Michal Simek

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commits in the arm-soc-fixes tree



On 21. 08. 20 18:18, Olof Johansson wrote:
> Hi,
>
> On Thu, Aug 20, 2020 at 10:19 PM Stephen Rothwell <[email protected]> wrote:
>>
>> Hi all,
>>
>> Commits
>>
>> 8d53ecfbf231 ("arm64: dts: xilinx: Align IOMMU nodename with dtschema")
>> b4b6fb8de8dc ("arm64: dts: zynqmp: Add GTR transceivers")
>>
>> are missing a Signed-off-by from their committer.
>
> Ah, I see what happened here. I've been relying on some of my
> semi-automation scripts for catching this, but I had to use regular
> manual git merge for this branch due to GPG signatures not capturing
> it in patchwork.
>
> Since the committer was Michal, and the pull request came from him, we
> still have the chain of contribution documented, but I'll keep this in
> mind on future manual merges.

Sorry about it. I expect I don't need to do anything but I have at least
add checking to git hooks to make sure that this won't happen again.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs