Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent
additions") removed explicit enable line for CONFIG_DEBUG_FS, because
that feature has been selected by other enabled options: CONFIG_TRACING,
which were enabled by CONFIG_PERF_EVENTS.
In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
dependency") removed the dependency between CONFIG_DEBUG_FS and
CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds.
Enable it again explicitly, as debugfs support is essential for various
automated testing tools.
Signed-off-by: Marek Szyprowski <[email protected]>
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 24962d0e71c7..0ffa957f2c94 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -1121,3 +1121,4 @@ CONFIG_CRYPTO_DEV_ROCKCHIP=m
CONFIG_CMA_SIZE_MBYTES=64
CONFIG_PRINTK_TIME=y
CONFIG_MAGIC_SYSRQ=y
+CONFIG_DEBUG_FS=y
--
2.17.1
On Fri, Dec 6, 2019 at 4:51 AM Marek Szyprowski
<[email protected]> wrote:
>
> Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent
> additions") removed explicit enable line for CONFIG_DEBUG_FS, because
> that feature has been selected by other enabled options: CONFIG_TRACING,
> which were enabled by CONFIG_PERF_EVENTS.
>
> In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> dependency") removed the dependency between CONFIG_DEBUG_FS and
> CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds.
>
> Enable it again explicitly, as debugfs support is essential for various
> automated testing tools.
>
> Signed-off-by: Marek Szyprowski <[email protected]>
Please cc patches you want us to apply to [email protected] (and, if you
want, [email protected]).
Applying. Thanks!
-Olof
Hi Marek,
On Fri, Dec 6, 2019 at 1:51 PM Marek Szyprowski
<[email protected]> wrote:
> Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent
> additions") removed explicit enable line for CONFIG_DEBUG_FS, because
> that feature has been selected by other enabled options: CONFIG_TRACING,
> which were enabled by CONFIG_PERF_EVENTS.
>
> In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> dependency") removed the dependency between CONFIG_DEBUG_FS and
> CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds.
>
> Enable it again explicitly, as debugfs support is essential for various
> automated testing tools.
... and for systemd :-(
E.g. with Debian 9 nfsroot:
[FAILED] Failed to mount /sys/kernel/debug.
See 'systemctl status sys-kernel-debug.mount' for details.
[DEPEND] Dependency failed for Local File Systems.
...
You are in emergGive root password for maintenance
(or press Control-D to continue):
> Signed-off-by: Marek Szyprowski <[email protected]>
Thank you!
Acked-by: Geert Uytterhoeven <[email protected]>
This is gonna bite lots of people (and defconfigs)...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
+Kevin, since this seems like something ideally we would see some
coverage of from Kernel CI at some point.
On Mon, Dec 9, 2019 at 1:29 AM Geert Uytterhoeven <[email protected]> wrote:
>
> Hi Marek,
>
> On Fri, Dec 6, 2019 at 1:51 PM Marek Szyprowski
> <[email protected]> wrote:
> > Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent
> > additions") removed explicit enable line for CONFIG_DEBUG_FS, because
> > that feature has been selected by other enabled options: CONFIG_TRACING,
> > which were enabled by CONFIG_PERF_EVENTS.
> >
> > In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> > dependency") removed the dependency between CONFIG_DEBUG_FS and
> > CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds.
> >
> > Enable it again explicitly, as debugfs support is essential for various
> > automated testing tools.
>
> ... and for systemd :-(
>
> E.g. with Debian 9 nfsroot:
>
> [FAILED] Failed to mount /sys/kernel/debug.
> See 'systemctl status sys-kernel-debug.mount' for details.
> [DEPEND] Dependency failed for Local File Systems.
> ...
> You are in emergGive root password for maintenance
> (or press Control-D to continue):
>
> > Signed-off-by: Marek Szyprowski <[email protected]>
>
> Thank you!
>
> Acked-by: Geert Uytterhoeven <[email protected]>
>
> This is gonna bite lots of people (and defconfigs)...
Looks like the in-tree affected defconfigs are:
olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $ fgrep -L
CONFIG_DEBUG_FS $(fgrep -l CONFIG_PERF_EVENTS *)
aspeed_g4_defconfig
aspeed_g5_defconfig
exynos_defconfig
imx_v6_v7_defconfig
milbeaut_m10v_defconfig
mvebu_v7_defconfig
mxs_defconfig
oxnas_v6_defconfig
shmobile_defconfig
tegra_defconfig
olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $
I'll revisit with patches for those later today.
-Olof
On Mon, 9 Dec 2019 at 18:45, Olof Johansson <[email protected]> wrote:
>
> +Kevin, since this seems like something ideally we would see some
> coverage of from Kernel CI at some point.
>
>
> On Mon, Dec 9, 2019 at 1:29 AM Geert Uytterhoeven <[email protected]> wrote:
> >
> > Hi Marek,
> >
> > On Fri, Dec 6, 2019 at 1:51 PM Marek Szyprowski
> > <[email protected]> wrote:
> > > Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent
> > > additions") removed explicit enable line for CONFIG_DEBUG_FS, because
> > > that feature has been selected by other enabled options: CONFIG_TRACING,
> > > which were enabled by CONFIG_PERF_EVENTS.
> > >
> > > In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> > > dependency") removed the dependency between CONFIG_DEBUG_FS and
> > > CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds.
> > >
> > > Enable it again explicitly, as debugfs support is essential for various
> > > automated testing tools.
> >
> > ... and for systemd :-(
> >
> > E.g. with Debian 9 nfsroot:
> >
> > [FAILED] Failed to mount /sys/kernel/debug.
> > See 'systemctl status sys-kernel-debug.mount' for details.
> > [DEPEND] Dependency failed for Local File Systems.
> > ...
> > You are in emergGive root password for maintenance
> > (or press Control-D to continue):
> >
> > > Signed-off-by: Marek Szyprowski <[email protected]>
> >
> > Thank you!
> >
> > Acked-by: Geert Uytterhoeven <[email protected]>
> >
> > This is gonna bite lots of people (and defconfigs)...
>
> Looks like the in-tree affected defconfigs are:
>
> olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $ fgrep -L
> CONFIG_DEBUG_FS $(fgrep -l CONFIG_PERF_EVENTS *)
> aspeed_g4_defconfig
> aspeed_g5_defconfig
> exynos_defconfig
I picked up already Marek's patch for exynos_defconfig.
Best regards,
Krzysztof