2022-12-15 17:36:47

by Arnd Bergmann

Subject: [PATCH] cpufreq: apple: remove duplicate intializer

From: Arnd Bergmann <[email protected]>

When -Woverride-init is enabled, gcc notices that the .attr
field is initialized twice:

drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
331 | .attr = apple_soc_cpufreq_hw_attr,
| ^~~~~~~~~~~~~~~~~~~~~~~~~

Remove the first one, since this is not actually used.

Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/cpufreq/apple-soc-cpufreq.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c
index d1801281cdd9..6f26395184c4 100644
--- a/drivers/cpufreq/apple-soc-cpufreq.c
+++ b/drivers/cpufreq/apple-soc-cpufreq.c
@@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = {
.flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV,
.verify = cpufreq_generic_frequency_table_verify,
- .attr = cpufreq_generic_attr,
.get = apple_soc_cpufreq_get_rate,
.init = apple_soc_cpufreq_init,
.exit = apple_soc_cpufreq_exit,
--
2.35.1

2022-12-15 17:59:26

by Eric Curtin

Subject: Re: [PATCH] cpufreq: apple: remove duplicate intializer

On Thu, 15 Dec 2022 at 17:05, Arnd Bergmann <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> When -Woverride-init is enabled, gcc notices that the .attr
> field is initialized twice:
>
> drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
> 331 | .attr = apple_soc_cpufreq_hw_attr,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Remove the first one, since this is not actually used.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Eric Curtin <[email protected]>

> ---
> drivers/cpufreq/apple-soc-cpufreq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c
> index d1801281cdd9..6f26395184c4 100644
> --- a/drivers/cpufreq/apple-soc-cpufreq.c
> +++ b/drivers/cpufreq/apple-soc-cpufreq.c
> @@ -321,7 +321,6 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = {
> .flags = CPUFREQ_HAVE_GOVERNOR_PER_POLICY |
> CPUFREQ_NEED_INITIAL_FREQ_CHECK | CPUFREQ_IS_COOLING_DEV,
> .verify = cpufreq_generic_frequency_table_verify,
> - .attr = cpufreq_generic_attr,
> .get = apple_soc_cpufreq_get_rate,
> .init = apple_soc_cpufreq_init,
> .exit = apple_soc_cpufreq_exit,
> --
> 2.35.1
>
>

2022-12-16 05:07:46

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: apple: remove duplicate intializer

On 15-12-22, 17:10, Eric Curtin wrote:
> On Thu, 15 Dec 2022 at 17:05, Arnd Bergmann <[email protected]> wrote:
> >
> > From: Arnd Bergmann <[email protected]>
> >
> > When -Woverride-init is enabled, gcc notices that the .attr
> > field is initialized twice:
> >
> > drivers/cpufreq/apple-soc-cpufreq.c:331:27: error: initialized field overwritten [-Werror=override-init]
> > 331 | .attr = apple_soc_cpufreq_hw_attr,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Remove the first one, since this is not actually used.
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> Reviewed-by: Eric Curtin <[email protected]>

Applied. Thanks.

--
viresh