2022-10-22 00:03:10

by Konrad Dybcio

Subject: [PATCH] irqchip/apple-aic: Mark aic_info structs __initconst

These structs hold information used only at init time that never
gets modified, hence mark them __initconst.

Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/irqchip/irq-apple-aic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 1c2813ad8bbe..ae3437f03e6c 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -248,14 +248,14 @@ struct aic_info {
bool fast_ipi;
};

-static const struct aic_info aic1_info = {
+static const struct aic_info aic1_info __initconst = {
.version = 1,

.event = AIC_EVENT,
.target_cpu = AIC_TARGET_CPU,
};

-static const struct aic_info aic1_fipi_info = {
+static const struct aic_info aic1_fipi_info __initconst = {
.version = 1,

.event = AIC_EVENT,
@@ -264,7 +264,7 @@ static const struct aic_info aic1_fipi_info = {
.fast_ipi = true,
};

-static const struct aic_info aic2_info = {
+static const struct aic_info aic2_info __initconst = {
.version = 2,

.irq_cfg = AIC2_IRQ_CFG,
--
2.38.1

2022-10-22 00:04:03

by Konrad Dybcio

Subject: Re: [PATCH] irqchip/apple-aic: Mark aic_info structs __initconst

On 22.10.2022 01:55, Konrad Dybcio wrote:
> These structs hold information used only at init time that never
> gets modified, hence mark them __initconst.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
Forgot to add:

Suggested-by: Marc Zyngier <[email protected]>


Konrad
> drivers/irqchip/irq-apple-aic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 1c2813ad8bbe..ae3437f03e6c 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -248,14 +248,14 @@ struct aic_info {
> bool fast_ipi;
> };
>
> -static const struct aic_info aic1_info = {
> +static const struct aic_info aic1_info __initconst = {
> .version = 1,
>
> .event = AIC_EVENT,
> .target_cpu = AIC_TARGET_CPU,
> };
>
> -static const struct aic_info aic1_fipi_info = {
> +static const struct aic_info aic1_fipi_info __initconst = {
> .version = 1,
>
> .event = AIC_EVENT,
> @@ -264,7 +264,7 @@ static const struct aic_info aic1_fipi_info = {
> .fast_ipi = true,
> };
>
> -static const struct aic_info aic2_info = {
> +static const struct aic_info aic2_info __initconst = {
> .version = 2,
>
> .irq_cfg = AIC2_IRQ_CFG,

2022-10-22 14:04:19

by Eric Curtin

Subject: Re: [PATCH] irqchip/apple-aic: Mark aic_info structs __initconst

On Sat, 22 Oct 2022 at 01:04, Konrad Dybcio
<[email protected]> wrote:
>
>
>
> On 22.10.2022 01:55, Konrad Dybcio wrote:
> > These structs hold information used only at init time that never
> > gets modified, hence mark them __initconst.
> >
> > Signed-off-by: Konrad Dybcio <[email protected]>

Reviewed-by: Eric Curtin <[email protected]>

> > ---
> Forgot to add:
>
> Suggested-by: Marc Zyngier <[email protected]>
>
>
> Konrad
> > drivers/irqchip/irq-apple-aic.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> > index 1c2813ad8bbe..ae3437f03e6c 100644
> > --- a/drivers/irqchip/irq-apple-aic.c
> > +++ b/drivers/irqchip/irq-apple-aic.c
> > @@ -248,14 +248,14 @@ struct aic_info {
> > bool fast_ipi;
> > };
> >
> > -static const struct aic_info aic1_info = {
> > +static const struct aic_info aic1_info __initconst = {
> > .version = 1,
> >
> > .event = AIC_EVENT,
> > .target_cpu = AIC_TARGET_CPU,
> > };
> >
> > -static const struct aic_info aic1_fipi_info = {
> > +static const struct aic_info aic1_fipi_info __initconst = {
> > .version = 1,
> >
> > .event = AIC_EVENT,
> > @@ -264,7 +264,7 @@ static const struct aic_info aic1_fipi_info = {
> > .fast_ipi = true,
> > };
> >
> > -static const struct aic_info aic2_info = {
> > +static const struct aic_info aic2_info __initconst = {
> > .version = 2,
> >
> > .irq_cfg = AIC2_IRQ_CFG,
>

2022-11-26 14:02:49

by tip-bot2 for Haifeng Xu

Subject: [irqchip: irq/irqchip-next] irqchip/apple-aic: Mark aic_info structs __initconst

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: d46b99656a16c450681985661a249dbb18e55cc4
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d46b99656a16c450681985661a249dbb18e55cc4
Author: Konrad Dybcio <[email protected]>
AuthorDate: Sat, 22 Oct 2022 01:55:23 +02:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Sat, 26 Nov 2022 13:29:42

irqchip/apple-aic: Mark aic_info structs __initconst

These structs hold information used only at init time that never
gets modified, hence mark them __initconst.

Signed-off-by: Konrad Dybcio <[email protected]>
Suggested-by: Marc Zyngier <[email protected]>
Reviewed-by: Eric Curtin <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-apple-aic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 1c2813a..ae3437f 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -248,14 +248,14 @@ struct aic_info {
bool fast_ipi;
};

-static const struct aic_info aic1_info = {
+static const struct aic_info aic1_info __initconst = {
.version = 1,

.event = AIC_EVENT,
.target_cpu = AIC_TARGET_CPU,
};

-static const struct aic_info aic1_fipi_info = {
+static const struct aic_info aic1_fipi_info __initconst = {
.version = 1,

.event = AIC_EVENT,
@@ -264,7 +264,7 @@ static const struct aic_info aic1_fipi_info = {
.fast_ipi = true,
};

-static const struct aic_info aic2_info = {
+static const struct aic_info aic2_info __initconst = {
.version = 2,

.irq_cfg = AIC2_IRQ_CFG,