2022-04-20 21:14:28

by Anup Patel

Subject: [PATCH v2 3/7] RISC-V: KVM: Treat SBI HFENCE calls as NOPs

We should treat SBI HFENCE calls as NOPs until nested virtualization
is supported by KVM RISC-V. This will help us test booting a hypervisor
under KVM RISC-V.

Signed-off-by: Anup Patel <[email protected]>
---
arch/riscv/kvm/vcpu_sbi_replace.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/kvm/vcpu_sbi_replace.c b/arch/riscv/kvm/vcpu_sbi_replace.c
index 0f217365c287..3c1dcd38358e 100644
--- a/arch/riscv/kvm/vcpu_sbi_replace.c
+++ b/arch/riscv/kvm/vcpu_sbi_replace.c
@@ -117,7 +117,11 @@ static int kvm_sbi_ext_rfence_handler(struct kvm_vcpu *vcpu, struct kvm_run *run
case SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA_VMID:
case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA:
case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID:
- /* TODO: implement for nested hypervisor case */
+ /*
+ * Until nested virtualization is implemented, the
+ * SBI HFENCE calls should be treated as NOPs
+ */
+ break;
default:
ret = -EOPNOTSUPP;
}
--
2.25.1

2022-05-05 19:54:23

by Atish Patra

Subject: Re: [PATCH v2 3/7] RISC-V: KVM: Treat SBI HFENCE calls as NOPs

On Wed, Apr 20, 2022 at 4:25 AM Anup Patel <[email protected]> wrote:
>
> We should treat SBI HFENCE calls as NOPs until nested virtualization
> is supported by KVM RISC-V. This will help us test booting a hypervisor
> under KVM RISC-V.
>
> Signed-off-by: Anup Patel <[email protected]>
> ---
> arch/riscv/kvm/vcpu_sbi_replace.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/vcpu_sbi_replace.c b/arch/riscv/kvm/vcpu_sbi_replace.c
> index 0f217365c287..3c1dcd38358e 100644
> --- a/arch/riscv/kvm/vcpu_sbi_replace.c
> +++ b/arch/riscv/kvm/vcpu_sbi_replace.c
> @@ -117,7 +117,11 @@ static int kvm_sbi_ext_rfence_handler(struct kvm_vcpu *vcpu, struct kvm_run *run
> case SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA_VMID:
> case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA:
> case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID:
> - /* TODO: implement for nested hypervisor case */
> + /*
> + * Until nested virtualization is implemented, the
> + * SBI HFENCE calls should be treated as NOPs
> + */
> + break;
> default:
> ret = -EOPNOTSUPP;
> }
> --
> 2.25.1
>


Reviewed-by: Atish Patra <[email protected]>
--
Regards,
Atish

2022-05-09 10:10:18

by Anup Patel

Subject: Re: [PATCH v2 3/7] RISC-V: KVM: Treat SBI HFENCE calls as NOPs

On Wed, May 4, 2022 at 7:44 AM Atish Patra <[email protected]> wrote:
>
> On Wed, Apr 20, 2022 at 4:25 AM Anup Patel <[email protected]> wrote:
> >
> > We should treat SBI HFENCE calls as NOPs until nested virtualization
> > is supported by KVM RISC-V. This will help us test booting a hypervisor
> > under KVM RISC-V.
> >
> > Signed-off-by: Anup Patel <[email protected]>
> > ---
> > arch/riscv/kvm/vcpu_sbi_replace.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/kvm/vcpu_sbi_replace.c b/arch/riscv/kvm/vcpu_sbi_replace.c
> > index 0f217365c287..3c1dcd38358e 100644
> > --- a/arch/riscv/kvm/vcpu_sbi_replace.c
> > +++ b/arch/riscv/kvm/vcpu_sbi_replace.c
> > @@ -117,7 +117,11 @@ static int kvm_sbi_ext_rfence_handler(struct kvm_vcpu *vcpu, struct kvm_run *run
> > case SBI_EXT_RFENCE_REMOTE_HFENCE_GVMA_VMID:
> > case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA:
> > case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID:
> > - /* TODO: implement for nested hypervisor case */
> > + /*
> > + * Until nested virtualization is implemented, the
> > + * SBI HFENCE calls should be treated as NOPs
> > + */
> > + break;
> > default:
> > ret = -EOPNOTSUPP;
> > }
> > --
> > 2.25.1
> >
>
>
> Reviewed-by: Atish Patra <[email protected]>

Queued this patch for 5.19

Thanks,
Anup

> --
> Regards,
> Atish