Currently, only esdhc1 is described in vfxxx.dtsi. This quick patch
adds support for esdhc0 also.
Regards,
-Cory
Cory Tusar (1):
ARM: dts: vfxxx: Include support for esdhc0 functionality.
arch/arm/boot/dts/vfxxx.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
--
2.3.6
Extend the existing Vybrid eSDHC devicetree implementation to also
describe the esdhc0 functional block.
Tested on a custom VF610-based board with a Toshiba THGBM1G5D2EBAI7 eMMC
module attached to esdhc0.
Signed-off-by: Cory Tusar <[email protected]>
---
arch/arm/boot/dts/vfxxx.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 4aa3351..7e97017 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi
@@ -445,6 +445,17 @@
status = "disabled";
};
+ esdhc0: esdhc@400b1000 {
+ compatible = "fsl,imx53-esdhc";
+ reg = <0x400b1000 0x1000>;
+ interrupts = <27 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks VF610_CLK_IPG_BUS>,
+ <&clks VF610_CLK_PLATFORM_BUS>,
+ <&clks VF610_CLK_ESDHC0>;
+ clock-names = "ipg", "ahb", "per";
+ status = "disabled";
+ };
+
esdhc1: esdhc@400b2000 {
compatible = "fsl,imx53-esdhc";
reg = <0x400b2000 0x1000>;
--
2.3.6
> Cory Tusar (1):
> ARM: dts: vfxxx: Include support for esdhc0 functionality.
>
> arch/arm/boot/dts/vfxxx.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> --
> 2.3.6
Your patch looks empty.
On 2015-07-09 08:07, Holger Schurig wrote:
>> Cory Tusar (1):
>> ARM: dts: vfxxx: Include support for esdhc0 functionality.
>>
>> arch/arm/boot/dts/vfxxx.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> --
>> 2.3.6
>
> Your patch looks empty.
This is a cover letter which provides overview over a whole patchset.
The patch is a separate reply message of this mail (PATCH 1/1).
@Cory
However, it is unusual to use a cover letter when there is only a single
patch. If you want to add additional comments which should not be part
of the commit message, you can edit the patch and insert text after the
three dashes, just before the diffstat. This text won't be part of the
commit when applied later.
--
Stefan
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/09/2015 02:13 AM, Stefan Agner wrote:
> On 2015-07-09 08:07, Holger Schurig wrote:
>>> Cory Tusar (1):
>>> ARM: dts: vfxxx: Include support for esdhc0 functionality.
>>>
>>> arch/arm/boot/dts/vfxxx.dtsi | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> --
>>> 2.3.6
>>
>> Your patch looks empty.
>
> This is a cover letter which provides overview over a whole patchset.
> The patch is a separate reply message of this mail (PATCH 1/1).
>
> @Cory
> However, it is unusual to use a cover letter when there is only a single
> patch. If you want to add additional comments which should not be part
> of the commit message, you can edit the patch and insert text after the
> three dashes, just before the diffstat. This text won't be part of the
> commit when applied later.
Hi Stefan,
Duly noted. Appreciate the feedback, and will keep in mind for next
time.
Best regards,
- -Cory
- --
Cory Tusar
Principal
PID 1 Solutions, Inc.
"There are two ways of constructing a software design. One way is to
make it so simple that there are obviously no deficiencies, and the
other way is to make it so complicated that there are no obvious
deficiencies." --Sir Charles Anthony Richard Hoare
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlWea6EACgkQHT1tsfGwHJ8CYACgqK20a6hhtl66aA+an5lWX4Ob
jTgAoKiygJTWpw9oYrmiZWk874tzkoZa
=YMvj
-----END PGP SIGNATURE-----
On 2015-07-08 22:51, Cory Tusar wrote:
> Extend the existing Vybrid eSDHC devicetree implementation to also
> describe the esdhc0 functional block.
>
> Tested on a custom VF610-based board with a Toshiba THGBM1G5D2EBAI7 eMMC
> module attached to esdhc0.
>
> Signed-off-by: Cory Tusar <[email protected]>
Looks good to me:
Acked-by: Stefan Agner <[email protected]>
> ---
> arch/arm/boot/dts/vfxxx.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 4aa3351..7e97017 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -445,6 +445,17 @@
> status = "disabled";
> };
>
> + esdhc0: esdhc@400b1000 {
> + compatible = "fsl,imx53-esdhc";
> + reg = <0x400b1000 0x1000>;
> + interrupts = <27 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks VF610_CLK_IPG_BUS>,
> + <&clks VF610_CLK_PLATFORM_BUS>,
> + <&clks VF610_CLK_ESDHC0>;
> + clock-names = "ipg", "ahb", "per";
> + status = "disabled";
> + };
> +
> esdhc1: esdhc@400b2000 {
> compatible = "fsl,imx53-esdhc";
> reg = <0x400b2000 0x1000>;
On Wed, Jul 08, 2015 at 04:51:06PM -0400, Cory Tusar wrote:
> Extend the existing Vybrid eSDHC devicetree implementation to also
> describe the esdhc0 functional block.
>
> Tested on a custom VF610-based board with a Toshiba THGBM1G5D2EBAI7 eMMC
> module attached to esdhc0.
>
> Signed-off-by: Cory Tusar <[email protected]>
Applied, thanks.