2023-11-01 09:41:39

by Christophe JAILLET

Subject: [PATCH] ipack: Remove usage of the deprecated ida_simple_xx() API

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/ipack/ipack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index cc1ecfd49928..b1471ba016a5 100644
--- a/drivers/ipack/ipack.c
+++ b/drivers/ipack/ipack.c
@@ -207,7 +207,7 @@ struct ipack_bus_device *ipack_bus_register(struct device *parent, int slots,
if (!bus)
return NULL;

- bus_nr = ida_simple_get(&ipack_ida, 0, 0, GFP_KERNEL);
+ bus_nr = ida_alloc(&ipack_ida, GFP_KERNEL);
if (bus_nr < 0) {
kfree(bus);
return NULL;
@@ -237,7 +237,7 @@ int ipack_bus_unregister(struct ipack_bus_device *bus)
{
bus_for_each_dev(&ipack_bus_type, NULL, bus,
ipack_unregister_bus_member);
- ida_simple_remove(&ipack_ida, bus->bus_nr);
+ ida_free(&ipack_ida, bus->bus_nr);
kfree(bus);
return 0;
}
--
2.34.1

2023-11-07 07:06:32

by Vaibhav Gupta

Subject: Re: [PATCH] ipack: Remove usage of the deprecated ida_simple_xx() API

Hello Christophe,
Thank you for your patch.

Acked-by: Vaibhav Gupta <[email protected]>

Hey Greg, could you please add this patch to your misc tree?

Thanks,
Vaibhav

On Wed, Nov 1, 2023 at 10:41 AM Christophe JAILLET
<[email protected]> wrote:
>
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
>
> This is less verbose.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/ipack/ipack.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
> index cc1ecfd49928..b1471ba016a5 100644
> --- a/drivers/ipack/ipack.c
> +++ b/drivers/ipack/ipack.c
> @@ -207,7 +207,7 @@ struct ipack_bus_device *ipack_bus_register(struct device *parent, int slots,
> if (!bus)
> return NULL;
>
> - bus_nr = ida_simple_get(&ipack_ida, 0, 0, GFP_KERNEL);
> + bus_nr = ida_alloc(&ipack_ida, GFP_KERNEL);
> if (bus_nr < 0) {
> kfree(bus);
> return NULL;
> @@ -237,7 +237,7 @@ int ipack_bus_unregister(struct ipack_bus_device *bus)
> {
> bus_for_each_dev(&ipack_bus_type, NULL, bus,
> ipack_unregister_bus_member);
> - ida_simple_remove(&ipack_ida, bus->bus_nr);
> + ida_free(&ipack_ida, bus->bus_nr);
> kfree(bus);
> return 0;
> }
> --
> 2.34.1
>

2023-11-07 07:20:31

by Greg Kroah-Hartman

Subject: Re: [PATCH] ipack: Remove usage of the deprecated ida_simple_xx() API

On Tue, Nov 07, 2023 at 08:04:45AM +0100, Vaibhav Gupta wrote:
> Hello Christophe,
> Thank you for your patch.
>
> Acked-by: Vaibhav Gupta <[email protected]>
>
> Hey Greg, could you please add this patch to your misc tree?

Will do after -rc1 is out.