The commit fc51fc87b1b8 factored out the helper functions to a library
but the new file had execute permission. Due to the way it detects
the shell test scripts, it showed up in the perf test list unexpectedly.
$ ./perf test list 2>&1 | grep 86
76: x86 bp modify
77: x86 Sample parsing
78: x86 hybrid
86: <---- (here)
$ ./perf test -v 86
86: :
--- start ---
test child forked, pid 1932207
test child finished with 0
---- end ----
: Ok
As it's a collection of library functions, it should not run as is.
Let's remove the execute permission.
Fixes: fc51fc87b1b8 ("perf test: Move all the check functions of stat CSV output to lib")
Cc: Kan Liang <[email protected]>
Cc: Andi Kleen <[email protected]>
Signed-off-by: Namhyung Kim <[email protected]>
---
tools/perf/tests/shell/lib/stat_output.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 tools/perf/tests/shell/lib/stat_output.sh
diff --git a/tools/perf/tests/shell/lib/stat_output.sh b/tools/perf/tests/shell/lib/stat_output.sh
old mode 100755
new mode 100644
--
2.41.0.162.gfafddb0af9-goog
On Wed, Jun 21, 2023 at 10:58 PM Namhyung Kim <[email protected]> wrote:
>
> The commit fc51fc87b1b8 factored out the helper functions to a library
> but the new file had execute permission. Due to the way it detects
> the shell test scripts, it showed up in the perf test list unexpectedly.
>
> $ ./perf test list 2>&1 | grep 86
> 76: x86 bp modify
> 77: x86 Sample parsing
> 78: x86 hybrid
> 86: <---- (here)
>
> $ ./perf test -v 86
> 86: :
> --- start ---
> test child forked, pid 1932207
> test child finished with 0
> ---- end ----
> : Ok
>
> As it's a collection of library functions, it should not run as is.
> Let's remove the execute permission.
>
> Fixes: fc51fc87b1b8 ("perf test: Move all the check functions of stat CSV output to lib")
> Cc: Kan Liang <[email protected]>
> Cc: Andi Kleen <[email protected]>
> Signed-off-by: Namhyung Kim <[email protected]>
Acked-by: Ian Rogers <[email protected]>
Thanks,
Ian
> ---
> tools/perf/tests/shell/lib/stat_output.sh | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> mode change 100755 => 100644 tools/perf/tests/shell/lib/stat_output.sh
>
> diff --git a/tools/perf/tests/shell/lib/stat_output.sh b/tools/perf/tests/shell/lib/stat_output.sh
> old mode 100755
> new mode 100644
> --
> 2.41.0.162.gfafddb0af9-goog
>