2022-08-24 05:25:54

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the bpf-next tree

Hi all,

In commit

2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")

Fixes tag

Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-08-24 17:46:26

by Kumar Kartikeya Dwivedi

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the bpf-next tree

On Wed, 24 Aug 2022 at 07:00, Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> 2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")
>
> Fixes tag
>
> Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
>

Ugh, really sorry, I must have fat fingered and pressed 'x' in vim
while editing the commit message. I always generate these using a git
fixes alias.

> --
> Cheers,
> Stephen Rothwell

2022-08-25 01:29:12

by Alexei Starovoitov

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the bpf-next tree

On Wed, Aug 24, 2022 at 10:05 AM Kumar Kartikeya Dwivedi
<[email protected]> wrote:
>
> On Wed, 24 Aug 2022 at 07:00, Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > In commit
> >
> > 2e5e0e8ede02 ("bpf: Fix reference state management for synchronous callbacks")
> >
> > Fixes tag
> >
> > Fixes: 69c87ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper")
> >
>
> Ugh, really sorry, I must have fat fingered and pressed 'x' in vim
> while editing the commit message. I always generate these using a git
> fixes alias.

Since that was caught quickly there weren't that many commits on top.
Fixed and force pushed bpf-next.

We actually have a script that checks such sha-s. Not sure how we missed it.