LinuxLists.cc - [Linux v5.11-rc7] x86: entry: Leftover of _TIF

2021-02-07 23:12:35

Subject: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?

Hi,

congrats to Linux v5.11-rc7.

after commit 6342adcaa683 ("entry: Ensure trap after single-step on
system call return"):

$ git grep '\_TIF_SINGLESTEP' arch/x86/
arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
(1 << TIF_SINGLESTEP)

Is this a leftover and can be removed (now)?

Thanks.

Regards,
- Sedat -

[1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
[2] https://git.kernel.org/linus/6342adcaa683

2021-02-07 23:30:52

by Kyle Huey

[permalink] [raw]

Subject: Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?

On Sun, Feb 7, 2021 at 3:09 PM Sedat Dilek <[email protected]> wrote:
>
> Hi,
>
> congrats to Linux v5.11-rc7.
>
> after commit 6342adcaa683 ("entry: Ensure trap after single-step on
> system call return"):
>
> $ git grep '\_TIF_SINGLESTEP' arch/x86/
> arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
> (1 << TIF_SINGLESTEP)
>
> Is this a leftover and can be removed (now)?
>
> Thanks.
>
> Regards,
> - Sedat -
>
> [1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
> [2] https://git.kernel.org/linus/6342adcaa683

Yes it looks like that can be removed now.

- Kyle

2021-02-07 23:32:14

by Bhaskar Chowdhury

[permalink] [raw]

Subject: Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?

On 00:08 Mon 08 Feb 2021, Sedat Dilek wrote:
>Hi,
>
>congrats to Linux v5.11-rc7.
>
>after commit 6342adcaa683 ("entry: Ensure trap after single-step on
>system call return"):
>
>$ git grep '\_TIF_SINGLESTEP' arch/x86/
>arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
> (1 << TIF_SINGLESTEP)
>
Does it failed the build???

Just curious??

>Is this a leftover and can be removed (now)?
>
>Thanks.
>
>Regards,
>- Sedat -
>
>[1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
>[2] https://git.kernel.org/linus/6342adcaa683

Attachments:

(No filename) (565.00 B)
signature.asc (499.00 B)
Download all attachments

2021-02-08 02:21:48

by Sedat Dilek

[permalink] [raw]

Subject: Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?

On Mon, Feb 8, 2021 at 12:25 AM Kyle Huey <[email protected]> wrote:
>
> On Sun, Feb 7, 2021 at 3:09 PM Sedat Dilek <[email protected]> wrote:
> >
> > Hi,
> >
> > congrats to Linux v5.11-rc7.
> >
> > after commit 6342adcaa683 ("entry: Ensure trap after single-step on
> > system call return"):
> >
> > $ git grep '\_TIF_SINGLESTEP' arch/x86/
> > arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
> > (1 << TIF_SINGLESTEP)
> >
> > Is this a leftover and can be removed (now)?
> >
> > Thanks.
> >
> > Regards,
> > - Sedat -
> >
> > [1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
> > [2] https://git.kernel.org/linus/6342adcaa683
>
> Yes it looks like that can be removed now.
>

Hi Kylem

Thanks for the confirmation.

Shall I send a patch?
With an ACK of you or mention in the commit message?

- Sedat -

2021-02-08 02:22:41

by Sedat Dilek

[permalink] [raw]

Subject: Re: [Linux v5.11-rc7] x86: entry: Leftover of _TIF_SINGLESTEP define?

On Mon, Feb 8, 2021 at 12:27 AM Bhaskar Chowdhury <[email protected]> wrote:
>
> On 00:08 Mon 08 Feb 2021, Sedat Dilek wrote:
> >Hi,
> >
> >congrats to Linux v5.11-rc7.
> >
> >after commit 6342adcaa683 ("entry: Ensure trap after single-step on
> >system call return"):
> >
> >$ git grep '\_TIF_SINGLESTEP' arch/x86/
> >arch/x86/include/asm/thread_info.h:#define _TIF_SINGLESTEP
> > (1 << TIF_SINGLESTEP)
> >
> Does it failed the build???
>
> Just curious??
>

No, it is simply a leftover.
Kyle confirmed.

I was able to build and boot into bare metal.

- Sedat -

> >Is this a leftover and can be removed (now)?
> >
> >Thanks.
> >
> >Regards,
> >- Sedat -
> >
> >[1] https://marc.info/?l=linux-kernel&m=161273724611262&w=2
> >[2] https://git.kernel.org/linus/6342adcaa683