2017-03-23 15:19:23

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] x86/syscalls/32: ignore arch_prctl for other architectures

sys_arch_prctl is only provided on x86, and there is no reason
to add it elsewhere. However, including it on the 32-bit syscall
table caused a warning for most configurations on non-x86:

:1328:2: warning: #warning syscall arch_prctl not implemented [-Wcpp]

This adds an exception to the syscall table checking script.

Fixes: 79170fda313e ("x86/syscalls/32: Wire up arch_prctl on x86-32")
Signed-off-by: Arnd Bergmann <[email protected]>
---
scripts/checksyscalls.sh | 1 +
1 file changed, 1 insertion(+)

Thomas, can you apply this on top of the x86 patch?

diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
index f7ad07128811..0cce56da3706 100755
--- a/scripts/checksyscalls.sh
+++ b/scripts/checksyscalls.sh
@@ -148,6 +148,7 @@ cat << EOF
#define __IGNORE_sysfs
#define __IGNORE_uselib
#define __IGNORE__sysctl
+#define __IGNORE_arch_prctl

/* ... including the "new" 32-bit uid syscalls */
#define __IGNORE_lchown32
--
2.9.0


2017-03-23 18:59:14

by Kyle Huey

[permalink] [raw]
Subject: Re: [PATCH] x86/syscalls/32: ignore arch_prctl for other architectures

On Thu, Mar 23, 2017 at 8:18 AM, Arnd Bergmann <[email protected]> wrote:
> sys_arch_prctl is only provided on x86, and there is no reason
> to add it elsewhere. However, including it on the 32-bit syscall
> table caused a warning for most configurations on non-x86:
>
> :1328:2: warning: #warning syscall arch_prctl not implemented [-Wcpp]
>
> This adds an exception to the syscall table checking script.
>
> Fixes: 79170fda313e ("x86/syscalls/32: Wire up arch_prctl on x86-32")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> scripts/checksyscalls.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> Thomas, can you apply this on top of the x86 patch?
>
> diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
> index f7ad07128811..0cce56da3706 100755
> --- a/scripts/checksyscalls.sh
> +++ b/scripts/checksyscalls.sh
> @@ -148,6 +148,7 @@ cat << EOF
> #define __IGNORE_sysfs
> #define __IGNORE_uselib
> #define __IGNORE__sysctl
> +#define __IGNORE_arch_prctl
>
> /* ... including the "new" 32-bit uid syscalls */
> #define __IGNORE_lchown32
> --
> 2.9.0
>

Ah, nice. lgtm.

- Kyle

Subject: [tip:x86/process] x86/syscalls/32: Ignore arch_prctl for other architectures

Commit-ID: f3e4559781bf0c393364baa6b772233088a711db
Gitweb: http://git.kernel.org/tip/f3e4559781bf0c393364baa6b772233088a711db
Author: Arnd Bergmann <[email protected]>
AuthorDate: Thu, 23 Mar 2017 16:18:51 +0100
Committer: Thomas Gleixner <[email protected]>
CommitDate: Fri, 24 Mar 2017 14:13:55 +0100

x86/syscalls/32: Ignore arch_prctl for other architectures

sys_arch_prctl is only provided on x86, and there is no reason
to add it elsewhere. However, including it on the 32-bit syscall
table caused a warning for most configurations on non-x86:

:1328:2: warning: #warning syscall arch_prctl not implemented [-Wcpp]

This adds an exception to the syscall table checking script.

Fixes: 79170fda313e ("x86/syscalls/32: Wire up arch_prctl on x86-32")
Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Kyle Huey <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>

---
scripts/checksyscalls.sh | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
index 2c9082b..116b773 100755
--- a/scripts/checksyscalls.sh
+++ b/scripts/checksyscalls.sh
@@ -148,6 +148,7 @@ cat << EOF
#define __IGNORE_sysfs
#define __IGNORE_uselib
#define __IGNORE__sysctl
+#define __IGNORE_arch_prctl

/* ... including the "new" 32-bit uid syscalls */
#define __IGNORE_lchown32