2013-03-25 16:56:48

by Sylwester Nawrocki

Subject: [PATCH] mfd: syscon: Add missing struct device_node declaration

syscon.h header uses struct device_node in functions' declarations
without declaring it. This causes compilation warnings like:

include/linux/mfd/syscon.h:20: warning: ‘struct device_node’
declared inside parameter list
include/linux/mfd/syscon.h:20: warning: its scope is only this
definition or declaration, which is probably not what you want

Fix it by adding a forward declaration of struct device_node.

Cc: Dong Aisheng <[email protected]>
Signed-off-by: Sylwester Nawrocki <[email protected]>
Signed-off-by: Kyungmin Park <[email protected]>
---
include/linux/mfd/syscon.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
index 6aeb6b8..f7be936 100644
--- a/include/linux/mfd/syscon.h
+++ b/include/linux/mfd/syscon.h
@@ -15,6 +15,8 @@
#ifndef __LINUX_MFD_SYSCON_H__
#define __LINUX_MFD_SYSCON_H__

+struct device_node;
+
extern struct regmap *syscon_node_to_regmap(struct device_node *np);
extern struct regmap *syscon_regmap_lookup_by_compatible(const char *s);
extern struct regmap *syscon_regmap_lookup_by_phandle(
--
1.7.9.5

2013-03-26 07:27:29

by Dong Aisheng

Subject: Re: [PATCH] mfd: syscon: Add missing struct device_node declaration

On 26 March 2013 00:56, Sylwester Nawrocki <[email protected]> wrote:
> syscon.h header uses struct device_node in functions' declarations
> without declaring it. This causes compilation warnings like:
>
> include/linux/mfd/syscon.h:20: warning: ?struct device_node?
> declared inside parameter list
> include/linux/mfd/syscon.h:20: warning: its scope is only this
> definition or declaration, which is probably not what you want
>
> Fix it by adding a forward declaration of struct device_node.
>
> Cc: Dong Aisheng <[email protected]>
> Signed-off-by: Sylwester Nawrocki <[email protected]>
> Signed-off-by: Kyungmin Park <[email protected]>

Acked-by: Dong Aisheng <[email protected]>

Regards
Dong Aisheng

> ---
> include/linux/mfd/syscon.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 6aeb6b8..f7be936 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -15,6 +15,8 @@
> #ifndef __LINUX_MFD_SYSCON_H__
> #define __LINUX_MFD_SYSCON_H__
>
> +struct device_node;
> +
> extern struct regmap *syscon_node_to_regmap(struct device_node *np);
> extern struct regmap *syscon_regmap_lookup_by_compatible(const char *s);
> extern struct regmap *syscon_regmap_lookup_by_phandle(
> --
> 1.7.9.5
>

2013-04-09 09:51:59

by Samuel Ortiz

Subject: Re: [PATCH] mfd: syscon: Add missing struct device_node declaration

Hi Silwester,

On Mon, Mar 25, 2013 at 05:56:23PM +0100, Sylwester Nawrocki wrote:
> syscon.h header uses struct device_node in functions' declarations
> without declaring it. This causes compilation warnings like:
>
> include/linux/mfd/syscon.h:20: warning: ‘struct device_node’
> declared inside parameter list
> include/linux/mfd/syscon.h:20: warning: its scope is only this
> definition or declaration, which is probably not what you want
>
> Fix it by adding a forward declaration of struct device_node.
>
> Cc: Dong Aisheng <[email protected]>
> Signed-off-by: Sylwester Nawrocki <[email protected]>
> Signed-off-by: Kyungmin Park <[email protected]>
> ---
> include/linux/mfd/syscon.h | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/